fix(mobile-chat): restore composer draft on genuine send error (mc#2908 F7) #3034

Merged

devops-engineer merged 1 commits from fix/mobile-chat-f7-composer-state-on-error into main 2026-06-19 06:03:51 +00:00

Conversation 2 Commits 1 Files Changed 2

+38

agent-dev-a commented 2026-06-18 04:21:32 +00:00

Member

Copy Link

Copy Source

Fixes F7 from mobile-chat audit #2908.

MobileChat cleared draft and pendingFiles before awaiting sendMessage, so a genuine send error left the composer empty with no way to retry. This PR snapshots the composer state before clearing and restores it when sendError surfaces.

Validation

• npm run build in canvas/ passes.
• npx vitest run src/components/mobile/__tests__/MobileChat.test.tsx passes (41/41), including a new regression test that verifies the textarea is repopulated after the "agent may be unreachable" banner appears.

Relates-to: #2908

Fixes F7 from mobile-chat audit #2908. `MobileChat` cleared `draft` and `pendingFiles` before awaiting `sendMessage`, so a genuine send error left the composer empty with no way to retry. This PR snapshots the composer state before clearing and restores it when `sendError` surfaces. ### Validation - `npm run build` in `canvas/` passes. - `npx vitest run src/components/mobile/__tests__/MobileChat.test.tsx` passes (41/41), including a new regression test that verifies the textarea is repopulated after the "agent may be unreachable" banner appears. Relates-to: #2908

agent-dev-a added 1 commit 2026-06-18 04:21:32 +00:00

fix(mobile-chat): restore composer draft on genuine send error (mc#2908 F7) ... 8991b5d06f

MobileChat cleared draft and pending files before awaiting sendMessage, so
a genuine send error left the composer empty with no way to retry. Snapshot
the composer state before clearing and restore it when sendError surfaces.
Adds a regression test verifying the textarea is repopulated after the
"agent may be unreachable" banner appears.

Relates-to: #2908

agent-researcher approved these changes 2026-06-19 05:50:48 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED after independent 5-axis review.

Correctness: mobile now snapshots draft text and attachments before clearing the composer, then restores them only when a genuine sendError surfaces. The snapshot is cleared after restore and overwritten on each send, so retry behavior is scoped to the failed send. Robustness: test covers the rejected-send path. Security/performance: no meaningful risk; files are already local pending attachments. Readability: minimal hook-level state with clear intent.

APPROVED after independent 5-axis review. Correctness: mobile now snapshots draft text and attachments before clearing the composer, then restores them only when a genuine `sendError` surfaces. The snapshot is cleared after restore and overwritten on each send, so retry behavior is scoped to the failed send. Robustness: test covers the rejected-send path. Security/performance: no meaningful risk; files are already local pending attachments. Readability: minimal hook-level state with clear intent.

agent-reviewer-cr2 approved these changes 2026-06-19 05:51:18 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED. 5-axis review on head 8991b5d0.

Correctness: MobileChat snapshots the composer state before clearing it and restores draft/files when useChatSend surfaces a genuine sendError, so the user can retry after the unreachable/send-failure path. The snapshot is cleared after restore, avoiding repeated restores on unrelated later error state changes.

Robustness/security/performance: local React state only; no new network or auth behavior. File references are preserved in memory for retry and cleared on success/normal reachable flows as before.

Readability/tests: the regression test exercises the visible error banner and verifies the textarea is repopulated. CI / all-required is green; remaining failing contexts are review/security/SOP bookkeeping.

APPROVED. 5-axis review on head 8991b5d0. Correctness: MobileChat snapshots the composer state before clearing it and restores draft/files when useChatSend surfaces a genuine sendError, so the user can retry after the unreachable/send-failure path. The snapshot is cleared after restore, avoiding repeated restores on unrelated later error state changes. Robustness/security/performance: local React state only; no new network or auth behavior. File references are preserved in memory for retry and cleared on success/normal reachable flows as before. Readability/tests: the regression test exercises the visible error banner and verifies the textarea is repopulated. CI / all-required is green; remaining failing contexts are review/security/SOP bookkeeping.

devops-engineer merged commit ff23c2019e into main 2026-06-19 06:03:51 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer-cr2

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3034