molecule-ai/molecule-core
52
0
Fork 2
Code Issues 176 Pull Requests 42 Actions 4 Packages Projects Releases Wiki Activity

RFC#2843 #43: backfill workspaces.template for pre-#3010 custom-template tenants (data-only; code flaw closed) #3021

New Issue
Open
opened 2026-06-17 20:46:50 +00:00 by core-devops · 0 comments
core-devops commented 2026-06-17 20:46:50 +00:00
Member
Copy Link
Copy Source

RFC#2843 #43 — workspaces.template backfill for pre-existing tenants

Status: CODE design flaw CLOSED; residual is a one-time DATA backfill

The re-stub trap is no longer a broken stub. Two already-merged fixes mean an empty workspaces.template no longer produces the 218-byte stub:

  1. #3010 / create-persist (workspace.go UPDATE workspaces SET template): NEW workspaces persist their template name, so restart restores it. New tenants are fully correct.
  2. Template-name normalization (runtime_registry.go strips -default → templateRepoByName["claude-code"] exists): on SaaS, templateIdentityForTemplateOrRuntime("", "claude-code") falls back to the claude-code-default identity and the asset-fetcher delivers a coherent default config — NOT a stub. (Verified: runtime_registry_test.go asserts the claude-code key resolves.)

Residual (this issue). A tenant created BEFORE #3010 has template=''. On its next per-workspace restart it provisions with the runtime-default config instead of its ORIGINAL custom template — i.e. a custom-template tenant (e.g. seo-agent, platform-agent) reverts to the generic runtime identity. This is an identity regression, not a broken box, and only affects tenants whose intended template ≠ their runtime-default.

Affected set is small + known (the custom-template tenants: JRS SEO + molecules SEO = seo-agent; concierge = platform-agent; any other non-default-template tenant). Generic claude-code tenants are unaffected (default IS their template).

Fix = one-time data backfill (needs source-of-truth decision)

Set workspaces.template for each pre-#3010 custom-template row to its correct template name. Candidate authoritative sources:

  • (a) CP / org bundle — the CP holds each org's template in its create/org records; a CP-side job (or operator) pushes the name to each tenant DB.
  • (b) Live config volume — the currently-running instance's /configs/config.yaml still reflects the original template; read it before the next restart wipes it.

Source-of-truth choice + writing to prod tenant DBs is a CTO-gated call (per ops rules). Until backfilled, the runtime-default fallback keeps every box WORKING (degraded identity, not broken).

No code change required for closure

The design is correct going forward. This issue tracks the operational backfill only.

## RFC#2843 #43 — workspaces.template backfill for pre-existing tenants ### Status: CODE design flaw CLOSED; residual is a one-time DATA backfill **The re-stub trap is no longer a broken stub.** Two already-merged fixes mean an empty `workspaces.template` no longer produces the 218-byte stub: 1. **#3010 / create-persist** (`workspace.go` `UPDATE workspaces SET template`): NEW workspaces persist their template name, so restart restores it. New tenants are fully correct. 2. **Template-name normalization** (`runtime_registry.go` strips `-default` → `templateRepoByName["claude-code"]` exists): on SaaS, `templateIdentityForTemplateOrRuntime("", "claude-code")` falls back to the **claude-code-default** identity and the asset-fetcher delivers a coherent default config — NOT a stub. (Verified: `runtime_registry_test.go` asserts the `claude-code` key resolves.) **Residual (this issue).** A tenant created BEFORE #3010 has `template=''`. On its next per-workspace restart it provisions with the runtime-default config instead of its ORIGINAL custom template — i.e. a **custom-template tenant (e.g. `seo-agent`, `platform-agent`) reverts to the generic runtime identity**. This is an identity regression, not a broken box, and only affects tenants whose intended template ≠ their runtime-default. Affected set is small + known (the custom-template tenants: JRS SEO + molecules SEO = `seo-agent`; concierge = `platform-agent`; any other non-default-template tenant). Generic claude-code tenants are unaffected (default IS their template). ### Fix = one-time data backfill (needs source-of-truth decision) Set `workspaces.template` for each pre-#3010 custom-template row to its correct template name. Candidate authoritative sources: - **(a) CP / org bundle** — the CP holds each org's template in its create/org records; a CP-side job (or operator) pushes the name to each tenant DB. - **(b) Live config volume** — the currently-running instance's `/configs/config.yaml` still reflects the original template; read it before the next restart wipes it. Source-of-truth choice + writing to prod tenant DBs is a CTO-gated call (per ops rules). Until backfilled, the runtime-default fallback keeps every box WORKING (degraded identity, not broken). ### No code change required for closure The design is correct going forward. This issue tracks the operational backfill only.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3021
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?