molecule-ai/molecule-core
53
0
Fork 2
Code Issues 188 Pull Requests 45 Actions 1 Packages Projects Releases Wiki Activity

fix(test): handle COPY --chmod in platform-agent drift gate #2986

Closed
agent-dev-a wants to merge 1 commits from fix/drift-test-copy-chmod into main
pull from: fix/drift-test-copy-chmod
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 1
+88 -7
agent-dev-a commented 2026-06-16 03:26:00 +00:00
Member
Copy Link
Copy Source

Fixes drift-gate regression introduced by #2984.

PR #2984 added --chmod=0755 to the identity-fallback.sh COPY in Dockerfile.platform-agent. The drift-gate string-based matcher only looked for the literal COPY ${PLATFORM_AGENT_TEMPLATE_DIR}/<rel> prefix, so TestPlatformAgentImageDriftGate started failing on the IMAGE-BAKED identity check.

What

  • Extract hasDockerfileCopyForRel to centralise the two valid COPY shapes (top-level file vs directory) and document them.
  • Use a regex matcher that permits optional Dockerfile flags (e.g. --chmod=0755) between COPY and the source path.
  • Keep the test Dockerfile-side checks always-run and SSOT-side checks conditional.

Test plan

  • go test -run TestPlatformAgentImageDriftGate ./internal/provisioner/ passes.
  • Existing CI lanes that run this package should go green.

SOP checklist

  • Comprehensive testing performed: unit test passed locally.
  • Local-postgres E2E run: N/A — test-only change, no runtime surface.
  • Staging-smoke verified or pending: N/A.
  • Root-cause not symptom: fixes the matcher to account for legitimate Dockerfile COPY flags.
  • Five-Axis review walked: trivial test-only change.
  • No backwards-compat shim / dead code added: helper replaces inline logic.
  • Memory consulted: N/A.
Fixes drift-gate regression introduced by #2984. PR #2984 added `--chmod=0755` to the `identity-fallback.sh` COPY in `Dockerfile.platform-agent`. The drift-gate string-based matcher only looked for the literal `COPY ${PLATFORM_AGENT_TEMPLATE_DIR}/<rel>` prefix, so `TestPlatformAgentImageDriftGate` started failing on the IMAGE-BAKED identity check. ## What - Extract `hasDockerfileCopyForRel` to centralise the two valid COPY shapes (top-level file vs directory) and document them. - Use a regex matcher that permits optional Dockerfile flags (e.g. `--chmod=0755`) between `COPY` and the source path. - Keep the test Dockerfile-side checks always-run and SSOT-side checks conditional. ## Test plan - `go test -run TestPlatformAgentImageDriftGate ./internal/provisioner/` passes. - Existing CI lanes that run this package should go green. ## SOP checklist - Comprehensive testing performed: unit test passed locally. - Local-postgres E2E run: N/A — test-only change, no runtime surface. - Staging-smoke verified or pending: N/A. - Root-cause not symptom: fixes the matcher to account for legitimate Dockerfile COPY flags. - Five-Axis review walked: trivial test-only change. - No backwards-compat shim / dead code added: helper replaces inline logic. - Memory consulted: N/A.
agent-dev-a added 1 commit 2026-06-16 03:46:06 +00:00
fix(test): handle COPY --chmod in platform-agent drift gate
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 14s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 14s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
Details
qa-review / approved (pull_request_target) Failing after 8s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 8s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 8s
Details
security-review / approved (pull_request_target) Failing after 8s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 16s
Details
PR Diff Guard / PR diff guard (pull_request) Successful in 16s
Details
E2E Chat / detect-changes (pull_request) Successful in 22s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 16s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 23s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 20s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 35s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1m18s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m21s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge user_tasks (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Workspace Requests (core#2606) (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Creates Workspace (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge (compile+skip) (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Platform Agent (pull_request) Has been cancelled
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 2m2s
Details
CI / Platform (Go) (pull_request) Successful in 2m52s
Details
CI / all-required (pull_request) Successful in 7s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
94a2e538fd 
PR #2984 added `--chmod=0755` to the identity-fallback.sh COPY in
Dockerfile.platform-agent. The drift-gate's string-based matcher only
looked for the literal `COPY ${PLATFORM_AGENT_TEMPLATE_DIR}/<rel>`
prefix, so the test started failing on the IMAGE-BAKED identity check.

- Extract `hasDockerfileCopyForRel` to centralise the two valid COPY
  shapes (top-level file vs directory) and document them.
- Use a regex matcher that permits optional Dockerfile flags (e.g.
  `--chmod=0755`) between `COPY` and the source path.
- Keep the test's Dockerfile-side checks always-run and SSOT-side
  checks conditional.

Fixes drift-gate regression from #2984.
agent-dev-a force-pushed fix/drift-test-copy-chmod from ed8f5b1778 to 94a2e538fd 2026-06-16 03:46:06 +00:00 Compare
agent-dev-a closed this pull request 2026-06-16 04:58:38 +00:00
Some required checks failed
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 14s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Required
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 14s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
Required
Details
qa-review / approved (pull_request_target) Failing after 8s
Required
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 8s
Required
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 8s
Details
security-review / approved (pull_request_target) Failing after 8s
Required
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 16s
Details
PR Diff Guard / PR diff guard (pull_request) Successful in 16s
Details
E2E Chat / detect-changes (pull_request) Successful in 22s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 16s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 23s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 20s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 35s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1m18s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m21s
Required
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge user_tasks (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Workspace Requests (core#2606) (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Creates Workspace (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge (compile+skip) (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Platform Agent (pull_request) Has been cancelled
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 2m2s
Details
CI / Platform (Go) (pull_request) Successful in 2m52s
Details
CI / all-required (pull_request) Successful in 7s
Required
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2986
Delete Branch "fix/drift-test-copy-chmod"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?