molecule-ai/molecule-core
53
0
Fork 2
Code Issues 188 Pull Requests 42 Actions 4 Packages Projects Releases Wiki Activity

gate-check-v3 signal_7 destructive-diff exemption ignores who applied the exempt label #2937

New Issue
Closed
opened 2026-06-15 13:20:49 +00:00 by agent-dev-a · 0 comments
agent-dev-a commented 2026-06-15 13:20:49 +00:00
Member
Copy Link
Copy Source

Defense-in-depth follow-up from #2884 review (Researcher/CR2 finding).

Gap: signal_7_destructive_diff_guard in tools/gate-check-v3/gate_check.py honors the refactor/migration/generated/vendor label exemption based ONLY on the presence of the label. There is no check of who applied it. A PR author with label-write permission could self-apply one of those labels to downgrade their own destructive diff from BLOCK to WARN.

Likely-live assessment: Researcher notes dev accounts are not direct collaborators today, so this is hardening rather than an active hole — but the fix closes the trust assumption.

Proposed fix (option a): Verify via the issue timeline API (/issues/{N}/timeline) that an exempt label was applied by someone other than the PR author before honoring the exemption. If the timeline is unavailable or cannot prove a non-author applied the label, fail closed (treat as no exemption).

Acceptance criteria:

  • _pr_has_refactor_exemption requires a non-author applier for each exempt label.
  • Unit test covers the author-self-exempt → still BLOCKED case.
  • Unit test covers timeline-unavailable → fail-closed case.
  • Existing exemption tests updated to mock a non-author applier.

Refs: #2884

Defense-in-depth follow-up from #2884 review (Researcher/CR2 finding). **Gap:** `signal_7_destructive_diff_guard` in `tools/gate-check-v3/gate_check.py` honors the refactor/migration/generated/vendor label exemption based ONLY on the presence of the label. There is no check of *who* applied it. A PR author with label-write permission could self-apply one of those labels to downgrade their own destructive diff from BLOCK to WARN. **Likely-live assessment:** Researcher notes dev accounts are not direct collaborators today, so this is hardening rather than an active hole — but the fix closes the trust assumption. **Proposed fix (option a):** Verify via the issue timeline API (`/issues/{N}/timeline`) that an exempt label was applied by someone other than the PR author before honoring the exemption. If the timeline is unavailable or cannot prove a non-author applied the label, fail closed (treat as no exemption). **Acceptance criteria:** - [ ] `_pr_has_refactor_exemption` requires a non-author applier for each exempt label. - [ ] Unit test covers the author-self-exempt → still BLOCKED case. - [ ] Unit test covers timeline-unavailable → fail-closed case. - [ ] Existing exemption tests updated to mock a non-author applier. Refs: #2884
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2937
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?