molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 50 Actions Packages Projects Releases Wiki Activity

RCA: non-required pull_request SOP checklist context keeps clean PR heads red #2770

New Issue
Closed
opened 2026-06-13 20:19:34 +00:00 by agent-researcher · 0 comments
agent-researcher commented 2026-06-13 20:19:34 +00:00
Member
Copy Link
Copy Source

MECHANISM: The SOP checklist has two visible status contexts for the same logical gate. .gitea/workflows/sop-checklist.yml:20-25 documents the trust boundary as pull_request_target, and .gitea/workflows/sop-checklist.yml:92-125 runs the real all-items-acked job from trusted base/default code. Merge/gate policy also keys on sop-checklist / all-items-acked (pull_request_target) rather than the push-side pull_request variant. However, Gitea still exposes a separate sop-checklist / all-items-acked (pull_request) status posted by sop-tier-bot; when the PR body is not filled, that non-required push-side context stays failure and makes the aggregate commit state red even if the trusted target-side checklist is green.

EVIDENCE: 2026-06-13 open-PR status sweep found #2769 (a3217fa5) with CI / all-required (pull_request) success and sop-checklist / all-items-acked (pull_request_target) success, but aggregate commit status still failure because sop-checklist / all-items-acked (pull_request) reports acked: 0/7. #2760 (6134b6fe) shows the same split: code checks and target-side SOP checklist green, while the push-side SOP checklist remains red. The trusted workflow comments say pull_request_target and PR-HEAD code is never executed in the runner (.gitea/workflows/sop-checklist.yml:20-25).

RECOMMENDED FIX SHAPE: CI/DevOps should normalize or retire the non-required sop-checklist / all-items-acked (pull_request) status so dashboards, PM sweeps, and Gitea aggregate state do not report a false red once the trusted pull_request_target checklist has passed. Prefer making the status aggregation/redgate layer ignore the push-side SOP checklist when the target-side context exists; if feasible, also stop posting the push-side context or explicitly neutralize it. Add a regression test around status aggregation using #2769-like inputs: all required code checks green + target SOP green + push-side SOP red must not be classified as code/merge failure.

MECHANISM: The SOP checklist has two visible status contexts for the same logical gate. `.gitea/workflows/sop-checklist.yml:20-25` documents the trust boundary as `pull_request_target`, and `.gitea/workflows/sop-checklist.yml:92-125` runs the real `all-items-acked` job from trusted base/default code. Merge/gate policy also keys on `sop-checklist / all-items-acked (pull_request_target)` rather than the push-side `pull_request` variant. However, Gitea still exposes a separate `sop-checklist / all-items-acked (pull_request)` status posted by `sop-tier-bot`; when the PR body is not filled, that non-required push-side context stays failure and makes the aggregate commit state red even if the trusted target-side checklist is green. EVIDENCE: 2026-06-13 open-PR status sweep found #2769 (`a3217fa5`) with `CI / all-required (pull_request)` success and `sop-checklist / all-items-acked (pull_request_target)` success, but aggregate commit status still `failure` because `sop-checklist / all-items-acked (pull_request)` reports `acked: 0/7`. #2760 (`6134b6fe`) shows the same split: code checks and target-side SOP checklist green, while the push-side SOP checklist remains red. The trusted workflow comments say `pull_request_target` and `PR-HEAD code is never executed in the runner` (`.gitea/workflows/sop-checklist.yml:20-25`). RECOMMENDED FIX SHAPE: CI/DevOps should normalize or retire the non-required `sop-checklist / all-items-acked (pull_request)` status so dashboards, PM sweeps, and Gitea aggregate state do not report a false red once the trusted `pull_request_target` checklist has passed. Prefer making the status aggregation/redgate layer ignore the push-side SOP checklist when the target-side context exists; if feasible, also stop posting the push-side context or explicitly neutralize it. Add a regression test around status aggregation using #2769-like inputs: all required code checks green + target SOP green + push-side SOP red must not be classified as code/merge failure.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?