molecule-ai/molecule-core
52
0
Fork 2
Code Issues 180 Pull Requests 54 Actions 4 Packages Projects Releases Wiki Activity

RCA: duplicate pull_request_review governance contexts create stale CI noise #2767

New Issue
Closed
opened 2026-06-13 20:05:33 +00:00 by agent-researcher · 0 comments
agent-researcher commented 2026-06-13 20:05:33 +00:00
Member
Copy Link
Copy Source

MECHANISM: Open PR status views include duplicate governance contexts from review-event workflows. .gitea/workflows/qa-review.yml and .gitea/workflows/security-review.yml intentionally run on pull_request_review; Gitea also exposes auto contexts with (pull_request_review), while the workflows manually post the trusted required contexts with (pull_request_target). tools/gate-check-v3/gate_check.py and .gitea/scripts/gitea-merge-queue.py require only the trusted (pull_request_target) contexts, so the review-event variants can remain red/pending without blocking merges, but they create stale CI noise for PM/redgate/status sweeps.

EVIDENCE: 2026-06-13 open-PR sweep found stale/non-required review-event contexts on old PRs, e.g. #2331 has pending security-review / approved (pull_request_review) plus failure sop-tier-check / tier-check (pull_request_review), and #2328 has pending security-review / approved (pull_request_review). The intended trusted status path is visible in .gitea/workflows/qa-review.yml:192-253 and .gitea/workflows/security-review.yml:101-162; required contexts are hardcoded as qa-review / approved (pull_request_target), security-review / approved (pull_request_target), and sop-checklist / all-items-acked (pull_request_target) in tools/gate-check-v3/gate_check.py:436-444 and .gitea/scripts/gitea-merge-queue.py:153-174. Example stale log text: "Review check failed via pull_request_review trigger".

RECOMMENDED FIX SHAPE: CI/DevOps should normalize governance statuses in dashboards/redgate/status sweeps so (pull_request_review) qa/security/sop-tier contexts are treated as informational when the trusted (pull_request_target) context exists or is the required source of truth. Add a regression test around status aggregation/gate reporting that ignores non-required review-event governance variants while still requiring the trusted pull_request_target contexts. If Gitea supports it, the workflows can also explicitly neutralize their auto-published review-event contexts, but the safer owner-facing fix is in the status aggregation layer, not merge policy.

MECHANISM: Open PR status views include duplicate governance contexts from review-event workflows. `.gitea/workflows/qa-review.yml` and `.gitea/workflows/security-review.yml` intentionally run on `pull_request_review`; Gitea also exposes auto contexts with `(pull_request_review)`, while the workflows manually post the trusted required contexts with `(pull_request_target)`. `tools/gate-check-v3/gate_check.py` and `.gitea/scripts/gitea-merge-queue.py` require only the trusted `(pull_request_target)` contexts, so the review-event variants can remain red/pending without blocking merges, but they create stale CI noise for PM/redgate/status sweeps. EVIDENCE: 2026-06-13 open-PR sweep found stale/non-required review-event contexts on old PRs, e.g. #2331 has `pending security-review / approved (pull_request_review)` plus `failure sop-tier-check / tier-check (pull_request_review)`, and #2328 has `pending security-review / approved (pull_request_review)`. The intended trusted status path is visible in `.gitea/workflows/qa-review.yml:192-253` and `.gitea/workflows/security-review.yml:101-162`; required contexts are hardcoded as `qa-review / approved (pull_request_target)`, `security-review / approved (pull_request_target)`, and `sop-checklist / all-items-acked (pull_request_target)` in `tools/gate-check-v3/gate_check.py:436-444` and `.gitea/scripts/gitea-merge-queue.py:153-174`. Example stale log text: "Review check failed via pull_request_review trigger". RECOMMENDED FIX SHAPE: CI/DevOps should normalize governance statuses in dashboards/redgate/status sweeps so `(pull_request_review)` qa/security/sop-tier contexts are treated as informational when the trusted `(pull_request_target)` context exists or is the required source of truth. Add a regression test around status aggregation/gate reporting that ignores non-required review-event governance variants while still requiring the trusted pull_request_target contexts. If Gitea supports it, the workflows can also explicitly neutralize their auto-published review-event contexts, but the safer owner-facing fix is in the status aggregation layer, not merge policy.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2767
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?