molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 15 Actions 3 Packages Projects Releases Wiki Activity

RCA: chat-separation Playwright spec is orphaned and can false-green on missing fixtures #2764

New Issue
Closed
opened 2026-06-13 19:50:54 +00:00 by agent-researcher · 0 comments
agent-researcher commented 2026-06-13 19:50:54 +00:00
Member
Copy Link
Copy Source

MECHANISM: Current molecule-core main has a chat E2E coverage gap: .gitea/workflows/e2e-chat.yml:422 runs only e2e/chat-desktop.spec.ts and e2e/chat-mobile.spec.ts, so canvas/e2e/chat-separation.spec.ts is orphaned from the E2E Chat lane. If someone runs the orphaned spec manually, it can still false-green because workspace/activity prerequisites skip or return instead of failing: workspace absence is skipped in the tab tests, activity API tests return early, and initial-prompt data-flow tests skip when no canvas activity/response exists.

EVIDENCE: main 8e685f257bf30f41bf6bb65360b96505d3e78275. Workflow selection is .gitea/workflows/e2e-chat.yml:422 (npx playwright test e2e/chat-desktop.spec.ts e2e/chat-mobile.spec.ts). The orphaned file has 11 test.skip( calls and 4 bare if (workspaces.length === 0) return; exits. Concrete lines: canvas/e2e/chat-separation.spec.ts:9, 31, 48, 70, 93, 125, 142, 161, 171, 203, 253, 291. This means chat sub-tab/data-flow regressions can escape both scheduled E2E Chat and manual runs when fixture seeding fails.

RECOMMENDED FIX SHAPE: Canvas/frontend owner. Either wire canvas/e2e/chat-separation.spec.ts into the intended E2E Chat lane with deterministic seeded workspaces/activity, or retire/convert it into unit/component coverage if desktop/mobile specs supersede it. For any required/staging path, replace workspace/activity prerequisite skips with fail-closed fixture setup checks; keep local dev skip behavior behind an explicit opt-out env if needed.

MECHANISM: Current `molecule-core` main has a chat E2E coverage gap: `.gitea/workflows/e2e-chat.yml:422` runs only `e2e/chat-desktop.spec.ts` and `e2e/chat-mobile.spec.ts`, so `canvas/e2e/chat-separation.spec.ts` is orphaned from the E2E Chat lane. If someone runs the orphaned spec manually, it can still false-green because workspace/activity prerequisites skip or return instead of failing: workspace absence is skipped in the tab tests, activity API tests return early, and initial-prompt data-flow tests skip when no canvas activity/response exists. EVIDENCE: main `8e685f257bf30f41bf6bb65360b96505d3e78275`. Workflow selection is `.gitea/workflows/e2e-chat.yml:422` (`npx playwright test e2e/chat-desktop.spec.ts e2e/chat-mobile.spec.ts`). The orphaned file has 11 `test.skip(` calls and 4 bare `if (workspaces.length === 0) return;` exits. Concrete lines: `canvas/e2e/chat-separation.spec.ts:9`, `31`, `48`, `70`, `93`, `125`, `142`, `161`, `171`, `203`, `253`, `291`. This means chat sub-tab/data-flow regressions can escape both scheduled E2E Chat and manual runs when fixture seeding fails. RECOMMENDED FIX SHAPE: Canvas/frontend owner. Either wire `canvas/e2e/chat-separation.spec.ts` into the intended E2E Chat lane with deterministic seeded workspaces/activity, or retire/convert it into unit/component coverage if desktop/mobile specs supersede it. For any required/staging path, replace workspace/activity prerequisite skips with fail-closed fixture setup checks; keep local dev skip behavior behind an explicit opt-out env if needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2764
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?