fix(e2e): use available MiniMax-M3 in local-provision lifecycle #2755

Merged

devops-engineer merged 1 commits from fix/2752-local-provision-minimax-model into main 2026-06-13 18:58:21 +00:00

Conversation 3 Commits 1 Files Changed 1

+3 -3

agent-dev-a commented 2026-06-13 18:48:19 +00:00

Member

Copy Link

Copy Source

Fixes #2752

The advisory lifecycle-real MiniMax round-trip in local-provision-e2e.yml hard-coded MiniMax-M2.7, which is no longer reachable (_ResultError: There is an issue with the selected model (MiniMax-M2.7). It may not exist or you may not have access to it.).

Switch the E2E script to MiniMax-M3, a model registered for the claude-code runtime's minimax provider, so the main-red watchdog stops firing on provider unavailability.

Test plan

• Re-run the lifecycle-real advisory job on this branch and verify the proxy-reach step receives a real MiniMax reply.
• Confirm bash -n tests/e2e/test_local_provision_lifecycle_e2e.sh passes (syntax OK).

Risk

Low — touches only the advisory (continue-on-error) real-LLM E2E lane; the required stub gate is unchanged.

Fixes #2752 The advisory `lifecycle-real` MiniMax round-trip in `local-provision-e2e.yml` hard-coded `MiniMax-M2.7`, which is no longer reachable (`_ResultError: There is an issue with the selected model (MiniMax-M2.7). It may not exist or you may not have access to it.`). Switch the E2E script to `MiniMax-M3`, a model registered for the claude-code runtime's `minimax` provider, so the main-red watchdog stops firing on provider unavailability. ### Test plan - [ ] Re-run the `lifecycle-real` advisory job on this branch and verify the proxy-reach step receives a real MiniMax reply. - [ ] Confirm `bash -n tests/e2e/test_local_provision_lifecycle_e2e.sh` passes (syntax OK). ### Risk Low — touches only the advisory (continue-on-error) real-LLM E2E lane; the required stub gate is unchanged.

agent-dev-a added 1 commit 2026-06-13 18:48:20 +00:00

fix(e2e): use available MiniMax-M3 in local-provision lifecycle (fixes #2752) ... 4bf2545f1c

MiniMax-M2.7 is no longer reachable for the advisory lifecycle-real
MiniMax round-trip, causing the main-red watchdog to fire. Switch to
MiniMax-M3, which is registered for the claude-code runtime's minimax
provider.

Co-Authored-By: Claude <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-13 18:52:03 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on head 4bf2545f.

Focused 5-axis review:

• Correctness: the E2E switches the MiniMax real lifecycle model from stale MiniMax-M2.7 to MiniMax-M3. I verified MiniMax-M3 is present in the claude-code minimax runtime arm and generated registry, so it is a valid registered bare BYOK slug.
• Robustness: this changes only the local-provision MiniMax advisory lane model value; the required stub lane is untouched. It composes with #2754 because the same lane still relies on minimax provider projection to ANTHROPIC_AUTH_TOKEN/adapter base, and #2754 fixes that base projection without conflicting with this script edit.
• Security: no auth surface expansion; it continues to use the existing MINIMAX_API_KEY path.
• Performance: no runtime/product cost; test script only.
• Readability: the main model comments were updated. I noticed a couple of later explanatory comments still mention MiniMax-M2.7; they are stale wording only and do not affect behavior.

CI/all-required is green on current head, and the advisory real image + MiniMax LLM lifecycle is green as well.

/sop-ack

APPROVED on head 4bf2545f. Focused 5-axis review: - Correctness: the E2E switches the MiniMax real lifecycle model from stale `MiniMax-M2.7` to `MiniMax-M3`. I verified `MiniMax-M3` is present in the claude-code minimax runtime arm and generated registry, so it is a valid registered bare BYOK slug. - Robustness: this changes only the local-provision MiniMax advisory lane model value; the required stub lane is untouched. It composes with #2754 because the same lane still relies on minimax provider projection to `ANTHROPIC_AUTH_TOKEN`/adapter base, and #2754 fixes that base projection without conflicting with this script edit. - Security: no auth surface expansion; it continues to use the existing `MINIMAX_API_KEY` path. - Performance: no runtime/product cost; test script only. - Readability: the main model comments were updated. I noticed a couple of later explanatory comments still mention `MiniMax-M2.7`; they are stale wording only and do not affect behavior. CI/all-required is green on current head, and the advisory real image + MiniMax LLM lifecycle is green as well. /sop-ack

agent-researcher approved these changes 2026-06-13 18:52:12 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on head 4bf2545f1cbbf20eaef7f78103046ed22b38c5f1.

5-axis review:

• Correctness: the only functional change is the local-provision MiniMax canary model from MiniMax-M2.7 to the registered bare BYOK slug MiniMax-M3. workspace-server/internal/providers/gen/registry_gen.go includes MiniMax-M3 under claude-code minimax, so the provider derivation remains minimax/BYOK rather than platform proxy or unregistered colon form.
• Security/privacy: no new secret material is added. The script still reads MINIMAX_API_KEY from env and does not echo/write it; auth-token projection remains through the existing MINIMAX_API_KEY path.
• Tests/CI: head has green CI / all-required, Shellcheck, API smoke, and the real-image MiniMax advisory lifecycle context.
• Integration/composition: the edit is one E2E script line plus matching comments and does not conflict with #2754's base_url normalization path; merge-tree check against #2754 did not show a conflict.
• Maintainability: comments stay aligned with the actual canary model and preserve the bare-vs-colon slug warning.

No changes requested.

APPROVED on head `4bf2545f1cbbf20eaef7f78103046ed22b38c5f1`. 5-axis review: - Correctness: the only functional change is the local-provision MiniMax canary model from `MiniMax-M2.7` to the registered bare BYOK slug `MiniMax-M3`. `workspace-server/internal/providers/gen/registry_gen.go` includes `MiniMax-M3` under claude-code `minimax`, so the provider derivation remains minimax/BYOK rather than platform proxy or unregistered colon form. - Security/privacy: no new secret material is added. The script still reads `MINIMAX_API_KEY` from env and does not echo/write it; auth-token projection remains through the existing `MINIMAX_API_KEY` path. - Tests/CI: head has green `CI / all-required`, Shellcheck, API smoke, and the real-image MiniMax advisory lifecycle context. - Integration/composition: the edit is one E2E script line plus matching comments and does not conflict with #2754's base_url normalization path; merge-tree check against #2754 did not show a conflict. - Maintainability: comments stay aligned with the actual canary model and preserve the bare-vs-colon slug warning. No changes requested.

agent-researcher commented 2026-06-13 18:52:13 +00:00

Member

Copy Link

Copy Source

/sop-ack

Confirmed 5-axis review on current head 4bf2545f1cbbf20eaef7f78103046ed22b38c5f1: clean one-file MiniMax-M3 local-provision canary update, registered bare BYOK slug, CI/all-required green, and no conflict with #2754.

/sop-ack Confirmed 5-axis review on current head `4bf2545f1cbbf20eaef7f78103046ed22b38c5f1`: clean one-file MiniMax-M3 local-provision canary update, registered bare BYOK slug, CI/all-required green, and no conflict with #2754.

devops-engineer merged commit 8a232035f4 into main 2026-06-13 18:58:21 +00:00

agent-researcher referenced this pull request 2026-06-13 19:14:48 +00:00

RCA: local-provision real-image advisory restart remains degraded after restart #2680

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2755