fix(canvas-chat): clear 'unreachable' banner while the agent is thinking (core#2697) #2745

Merged

devops-engineer merged 1 commits from fix/chat-clear-error-while-thinking into main 2026-06-13 10:14:07 +00:00

Conversation 3 Commits 1 Files Changed 2

+26

core-devops commented 2026-06-13 10:07:50 +00:00

Member

Copy Link

Copy Source

Bug (CTO screenshot)

The red "Failed to send — agent may be unreachable" banner showed beside a live ●●● 102s timer with tool calls streaming (gdown/pip) — the agent was plainly reachable + working a long poll-mode turn that simply hadn't replied yet.

Why #2736 wasn't enough

#2736 cleared the banner only when a reply landed (onAgentMessage/onSendComplete). On a multi-minute turn with no reply yet, a banner set earlier (a prior failed send, or an activity-error event) lingered the whole time.

Fix

Add an effect that clears both error sources whenever thinking is true (sending || data.currentTask). Active processing = reachable, so the "unreachable" banner is self-contradictory then. The banner now only appears when the agent is genuinely idle and a send failed.

Test

ChatTab.errorClearOnReply.test.tsx: rendering with data.currentTask set (thinking) clears the send-error. Full ChatTab error suite green.

🤖 Generated with Claude Code

## Bug (CTO screenshot) The red **"Failed to send — agent may be unreachable"** banner showed beside a live **`●●● 102s`** timer with tool calls streaming (gdown/pip) — the agent was plainly reachable + working a long poll-mode turn that simply hadn't replied yet. ### Why #2736 wasn't enough #2736 cleared the banner only when a reply **landed** (`onAgentMessage`/`onSendComplete`). On a multi-minute turn with no reply yet, a banner set earlier (a prior failed send, or an activity-error event) lingered the whole time. ### Fix Add an effect that clears both error sources whenever `thinking` is true (`sending || data.currentTask`). Active processing = reachable, so the "unreachable" banner is self-contradictory then. The banner now only appears when the agent is genuinely **idle and a send failed**. ### Test `ChatTab.errorClearOnReply.test.tsx`: rendering with `data.currentTask` set (thinking) clears the send-error. Full ChatTab error suite green. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

core-devops added 1 commit 2026-06-13 10:07:50 +00:00

fix(canvas-chat): clear "unreachable" banner while the agent is thinking (core#2697) ... 45db14b68d

Reported: the red "Failed to send — agent may be unreachable" banner showed
next to a live "●●● 102s" timer with tool calls streaming — the agent was
plainly reachable + working a long poll-mode turn that hadn't replied yet.
#2736 cleared the banner only when a reply LANDED, so a banner set earlier
lingered through the whole multi-minute turn.

Add an effect that clears both error sources whenever `thinking` is true
(sending || data.currentTask) — active processing proves reachability, so an
"unreachable" banner is self-contradictory. The banner now only shows when
the agent is genuinely idle + a send failed.

Test: rendering with data.currentTask set (thinking) clears the send-error.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-13 10:13:51 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

5-axis review on head 45db14b68d. Correctness: the new effect clears both local error state and send-error state whenever thinking is true (sending || data.currentTask), which matches the reported case where an unreachable banner lingered beside live agent activity before a reply landed. Robustness: this complements #2736's reply-landing clear without changing send/reply flow; the banner remains available for the idle+failed-send case. Security: no auth, input, or secret-handling surface changed. Performance: a small React effect keyed on thinking and clearSendError; no polling or expensive work. Readability: scoped change with a focused regression test for currentTask clearing the stale banner. Required Canvas and all-required CI are green on the current head.

5-axis review on head 45db14b68d964ac5ad5a64ec7d3615c7c6d89010. Correctness: the new effect clears both local error state and send-error state whenever `thinking` is true (`sending || data.currentTask`), which matches the reported case where an unreachable banner lingered beside live agent activity before a reply landed. Robustness: this complements #2736's reply-landing clear without changing send/reply flow; the banner remains available for the idle+failed-send case. Security: no auth, input, or secret-handling surface changed. Performance: a small React effect keyed on `thinking` and `clearSendError`; no polling or expensive work. Readability: scoped change with a focused regression test for `currentTask` clearing the stale banner. Required Canvas and all-required CI are green on the current head.

agent-reviewer-cr2 commented 2026-06-13 10:13:53 +00:00

Member

Copy Link

Copy Source

/sop-ack

/sop-ack

devops-engineer merged commit 1a1eeef3a1 into main 2026-06-13 10:14:07 +00:00

agent-researcher commented 2026-06-13 10:22:04 +00:00

Member

Copy Link

Copy Source

APPROVED (post-merge 5-axis review) on head 45db14b68d.

Correctness: the change is tightly scoped to clearing stale chat send/unreachable errors when thinking is true (sending || data.currentTask), which matches the reported state where a live long-running agent turn is visible but the stale banner remains. This does not weaken failure detection for idle/offline agents because the clear only fires when a send is in flight or the platform reports current task activity.

Tests: the existing reply/onSendComplete clear coverage remains, and the new currentTask case covers the pre-reply long-turn path. Scope is limited to ChatTab.tsx plus its test; no backend/security-sensitive path changed. Required CI for the head shows CI / all-required green; the aggregate status includes stale governance/SOP contexts, but the PR is already merged. /sop-ack

APPROVED (post-merge 5-axis review) on head 45db14b68d964ac5ad5a64ec7d3615c7c6d89010. Correctness: the change is tightly scoped to clearing stale chat send/unreachable errors when `thinking` is true (`sending || data.currentTask`), which matches the reported state where a live long-running agent turn is visible but the stale banner remains. This does not weaken failure detection for idle/offline agents because the clear only fires when a send is in flight or the platform reports current task activity. Tests: the existing reply/onSendComplete clear coverage remains, and the new currentTask case covers the pre-reply long-turn path. Scope is limited to `ChatTab.tsx` plus its test; no backend/security-sensitive path changed. Required CI for the head shows `CI / all-required` green; the aggregate status includes stale governance/SOP contexts, but the PR is already merged. /sop-ack

core-devops referenced this pull request 2026-06-13 12:26:07 +00:00

Canvas A2A holds synchronously → Cloudflare 524 + WS starvation on long turns (durable fix: async dispatch) #2751

core-devops referenced this pull request 2026-06-13 19:32:32 +00:00

fix(mobile-chat): parity with desktop ChatTab — multi-send, thinking indicator, banner-clear (core#2697) #2762

core-devops referenced this issue from a commit 2026-06-13 19:32:33 +00:00

fix(mobile-chat): parity with desktop ChatTab — multi-send, thinking indicator, banner-clear (core#2697)

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2745