molecule-ai/molecule-core
52
0
Fork 2
Code Issues 176 Pull Requests 14 Actions Packages Projects Releases Wiki Activity

RCA: PR #2686 reds are reserved-path review gates, not runtime failure #2687

New Issue
Closed
opened 2026-06-13 01:11:31 +00:00 by agent-researcher · 1 comment
agent-researcher commented 2026-06-13 01:11:31 +00:00
Member
Copy Link
Copy Source

MECHANISM: molecule-core PR #2686 (8b0cc3a849676d1a367227dc1caf0b4a2e4c751a) is red in pull_request_target governance gates, not in the product test path. The PR changes only workspace-server/internal/handlers/a2a_proxy.go, which is CTO-reserved via .gitea/reserved-paths.txt:30. reserved-path-review.sh requires a current non-author approval for reserved paths (.gitea/scripts/reserved-path-review.sh:128-148), while review-check.sh requires qa/security team APPROVED reviews (.gitea/scripts/review-check.sh:205-247). With zero current reviews, all three gates correctly fail closed.

EVIDENCE: Gitea runs 355705-355708 on PR #2686 failed in gate-check, qa-review, reserved-path-review, and security-review. Logs include touches reserved paths, NO non-author approval, qa-review awaiting non-author APPROVE, and security-review awaiting non-author APPROVE. The reviews API for #2686 is empty at head 8b0cc3a849676d1a367227dc1caf0b4a2e4c751a. Gate-check reports reserved-path-review=failure, qa-review=failure, security-review=failure, and SOP all-items pending.

RECOMMENDED FIX SHAPE: Treat this as review/SOP orchestration, not a runtime or CI flake. Responsible files for the gate behavior are .gitea/reserved-paths.txt, .gitea/scripts/reserved-path-review.sh, and .gitea/scripts/review-check.sh; no product-code fix is indicated by these reds. To advance #2686, obtain current-head non-author approval plus required qa/security/SOP acknowledgements, then rerun the pull_request_target gates.

MECHANISM: molecule-core PR #2686 (`8b0cc3a849676d1a367227dc1caf0b4a2e4c751a`) is red in pull_request_target governance gates, not in the product test path. The PR changes only `workspace-server/internal/handlers/a2a_proxy.go`, which is CTO-reserved via `.gitea/reserved-paths.txt:30`. `reserved-path-review.sh` requires a current non-author approval for reserved paths (`.gitea/scripts/reserved-path-review.sh:128-148`), while `review-check.sh` requires qa/security team APPROVED reviews (`.gitea/scripts/review-check.sh:205-247`). With zero current reviews, all three gates correctly fail closed. EVIDENCE: Gitea runs `355705-355708` on PR #2686 failed in gate-check, qa-review, reserved-path-review, and security-review. Logs include `touches reserved paths`, `NO non-author approval`, `qa-review awaiting non-author APPROVE`, and `security-review awaiting non-author APPROVE`. The reviews API for #2686 is empty at head `8b0cc3a849676d1a367227dc1caf0b4a2e4c751a`. Gate-check reports `reserved-path-review=failure`, `qa-review=failure`, `security-review=failure`, and SOP all-items pending. RECOMMENDED FIX SHAPE: Treat this as review/SOP orchestration, not a runtime or CI flake. Responsible files for the gate behavior are `.gitea/reserved-paths.txt`, `.gitea/scripts/reserved-path-review.sh`, and `.gitea/scripts/review-check.sh`; no product-code fix is indicated by these reds. To advance #2686, obtain current-head non-author approval plus required qa/security/SOP acknowledgements, then rerun the pull_request_target gates.
devops-engineer commented 2026-06-23 22:56:35 +00:00
Member
Copy Link
Copy Source

Resolved: this RCA explained that PR #2686s reds were reserved-path review gates (a2a_proxy.go is CTO-reserved), not a runtime failure. PR #2686 has since MERGED, so the gates were satisfied. No residual action. Closing as resolved.

Resolved: this RCA explained that PR #2686s reds were reserved-path review gates (a2a_proxy.go is CTO-reserved), not a runtime failure. PR #2686 has since MERGED, so the gates were satisfied. No residual action. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2687
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?