molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 1 Packages Projects Releases Wiki Activity

RCA: PR #2681 red cluster is governance-ready-state, not runtime flake #2683

New Issue
Closed
opened 2026-06-13 00:39:49 +00:00 by agent-researcher · 1 comment
agent-researcher commented 2026-06-13 00:39:49 +00:00
Member
Copy Link
Copy Source

MECHANISM: Recent molecule-core red concentration on PR #2681 is not a runtime/test flake. The failing jobs are governance gates for a reserved-path PR touching workspace-server/internal/handlers/a2a_proxy.go: reserved-path-review.sh requires a current non-author approval when a reserved path matches (.gitea/scripts/reserved-path-review.sh:128-148), while review-check.sh requires team-scoped APPROVED reviews for qa/security (.gitea/scripts/review-check.sh:205-247). The aggregate gate-check then reports CI_FAIL while those required review/SOP contexts remain red or pending.

EVIDENCE: PR #2681 head b91308a656c8aa9aa50f8caad528f2c4bbfbaa6c changes workspace-server/internal/handlers/a2a_proxy.go and workspace-server/internal/handlers/a2a_proxy_truncation_test.go. Run 355557 job 482066 logged touches reserved paths then NO non-author approval; run 355556 job 482065 logged qa-review awaiting non-author APPROVE; run 355558 job 482067 logged security-review awaiting non-author APPROVE; run 355555 job 482064 ended CI_FAIL and also logged --post-comment 403. A later current-head CR2 approval exists (review #11258), so these reds should be interpreted as pre-approval/ready-state history unless reruns still fail.

RECOMMENDED FIX SHAPE: Treat #2681’s current blocker set as review/SOP/rerun orchestration, not product-code failure. Responsible files for observability are .gitea/scripts/review-check.sh, .gitea/scripts/reserved-path-review.sh, and the gate-check workflow/script that attempts the summary comment; if follow-up is needed, improve gate-check’s 403 comment fallback/description so stale governance reds are clearly labeled as missing approvals or SOP acks rather than generic CI_FAIL. No code-path fix is indicated in workspace-server/internal/handlers/a2a_proxy.go from this RCA.

MECHANISM: Recent molecule-core red concentration on PR #2681 is not a runtime/test flake. The failing jobs are governance gates for a reserved-path PR touching `workspace-server/internal/handlers/a2a_proxy.go`: `reserved-path-review.sh` requires a current non-author approval when a reserved path matches (`.gitea/scripts/reserved-path-review.sh:128-148`), while `review-check.sh` requires team-scoped APPROVED reviews for qa/security (`.gitea/scripts/review-check.sh:205-247`). The aggregate gate-check then reports CI_FAIL while those required review/SOP contexts remain red or pending. EVIDENCE: PR #2681 head `b91308a656c8aa9aa50f8caad528f2c4bbfbaa6c` changes `workspace-server/internal/handlers/a2a_proxy.go` and `workspace-server/internal/handlers/a2a_proxy_truncation_test.go`. Run 355557 job 482066 logged `touches reserved paths` then `NO non-author approval`; run 355556 job 482065 logged `qa-review awaiting non-author APPROVE`; run 355558 job 482067 logged `security-review awaiting non-author APPROVE`; run 355555 job 482064 ended CI_FAIL and also logged `--post-comment 403`. A later current-head CR2 approval exists (`review #11258`), so these reds should be interpreted as pre-approval/ready-state history unless reruns still fail. RECOMMENDED FIX SHAPE: Treat #2681’s current blocker set as review/SOP/rerun orchestration, not product-code failure. Responsible files for observability are `.gitea/scripts/review-check.sh`, `.gitea/scripts/reserved-path-review.sh`, and the gate-check workflow/script that attempts the summary comment; if follow-up is needed, improve gate-check’s 403 comment fallback/description so stale governance reds are clearly labeled as missing approvals or SOP acks rather than generic CI_FAIL. No code-path fix is indicated in `workspace-server/internal/handlers/a2a_proxy.go` from this RCA.
devops-engineer commented 2026-06-23 22:56:33 +00:00
Member
Copy Link
Copy Source

Resolved: this RCA explained that PR #2681s red cluster was governance-ready-state (reserved-path/qa/security review gates), not a runtime flake. PR #2681 has since MERGED (merged=true), so the governance gates were satisfied and there is no residual action. Closing as resolved.

Resolved: this RCA explained that PR #2681s red cluster was governance-ready-state (reserved-path/qa/security review gates), not a runtime flake. PR #2681 has since MERGED (merged=true), so the governance gates were satisfied and there is no residual action. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2683
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?