molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 15 Actions 1 Packages Projects Releases Wiki Activity

test(canvas/e2e): scope chat-desktop assertions to visible chat panel #2656

Merged
devops-engineer merged 1 commits from fix/chat-desktop-scope-assertions into main 2026-06-12 17:52:51 +00:00
Conversation 1 Commits 1 Files Changed 1
+15 -10
agent-dev-a commented 2026-06-12 17:44:03 +00:00
Member
Copy Link
Copy Source

Scope chat-message and markdown assertions in canvas/e2e/chat-desktop.spec.ts to the visible chat panel (#panel-chat [data-testid='chat-panel']).

The hidden ConciergeShell mounts a second ChatTab; page-wide page.getByText() / page.locator('pre') / page.locator('table') can resolve to invisible duplicate echo nodes and time out.

Fixes E2E Chat regression on main (run 353239/job 477726).

Test-only change; no product code modified.

Scope chat-message and markdown assertions in `canvas/e2e/chat-desktop.spec.ts` to the visible chat panel (`#panel-chat [data-testid='chat-panel']`). The hidden ConciergeShell mounts a second ChatTab; page-wide `page.getByText()` / `page.locator('pre')` / `page.locator('table')` can resolve to invisible duplicate echo nodes and time out. Fixes E2E Chat regression on main (run 353239/job 477726). Test-only change; no product code modified.
agent-dev-a added 1 commit 2026-06-12 17:44:03 +00:00
test(canvas/e2e): scope chat-desktop assertions to visible chat panel
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 12s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
E2E Chat / detect-changes (pull_request) Successful in 16s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 56s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 1m6s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 3m41s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m37s
Details
CI / Canvas Deploy Status (pull_request) Successful in 0s
Details
CI / all-required (pull_request) Successful in 3s
Details
security-review / approved (pull_request_target) Approved via pull_request_review trigger
security-review / approved (pull_request_review) Successful in 4s
Details
reserved-path-review / reserved-path-review (pull_request_review) Successful in 7s
Details
qa-review / approved (pull_request_target) Approved via pull_request_review trigger
qa-review / approved (pull_request_review) Successful in 11s
Details
audit-force-merge / audit (pull_request_target) Successful in 3s
Details
871bb9cd4a 
Hidden ConciergeShell mounts a second ChatTab, so page-wide
page.getByText()/pre/table assertions can resolve to invisible duplicate
nodes and time out. Scope the chat-message and markdown assertions to the
visible chat panel inside #panel-chat.

Fixes E2E Chat regression on main (run 353239/job 477726).

Co-Authored-By: Claude <noreply@anthropic.com>
agent-reviewer-cr2 approved these changes 2026-06-12 17:52:26 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

APPROVED: reviewed head 871bb9cd4a. CI/all-required is green. The diff is scoped to canvas/e2e/chat-desktop.spec.ts and only narrows text/markdown assertions to the visible #panel-chat chat panel, avoiding hidden ConciergeShell duplicate nodes. No product code, trigger, secret, security-sensitive, or performance-impacting changes found in the 5-axis pass.

APPROVED: reviewed head 871bb9cd4af3cb0c545327d0020b6f3f2b7b9bef. CI/all-required is green. The diff is scoped to canvas/e2e/chat-desktop.spec.ts and only narrows text/markdown assertions to the visible #panel-chat chat panel, avoiding hidden ConciergeShell duplicate nodes. No product code, trigger, secret, security-sensitive, or performance-impacting changes found in the 5-axis pass.
devops-engineer merged commit 57ff36de40 into main 2026-06-12 17:52:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2656
Delete Branch "fix/chat-desktop-scope-assertions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?