fix(staging-e2e): pre-seed cookie-consent decision (banner intercepts nav clicks) #2600

Merged

devops-engineer merged 1 commits from fix/staging-e2e-preseed-cookie-consent into main 2026-06-11 18:21:21 +00:00

Conversation 1 Commits 1 Files Changed 1

+19

core-devops commented 2026-06-11 18:14:15 +00:00

Member

Copy Link

Copy Source

Canvas tabs E2E red on main (run 349273): every staging-concierge.spec nav click times out with

<section aria-labelledby="cookie-consent-title" ... z-[9999]> intercepts pointer events

The CookieConsent banner (0dd4f259) is a fixed bottom overlay covering the left-rail nav until a decision exists in localStorage — the e2e suites were never updated when it shipped.

Fix (test-only): beforeEach addInitScript seeds molecule_cookie_consent = {decision:"rejected", version:1} — "rejected" matches the privacy-preserving default; version must equal CURRENT_VERSION in CookieConsent.tsx or the record is ignored.

(The other suites pass because their click targets sit above the banner; if more suites grow bottom-anchored interactions, promote this seed into a shared fixture.)

🤖 Generated with Claude Code

`Canvas tabs E2E` red on main (run 349273): every `staging-concierge.spec` nav click times out with ``` <section aria-labelledby="cookie-consent-title" ... z-[9999]> intercepts pointer events ``` The CookieConsent banner (`0dd4f259`) is a fixed bottom overlay covering the left-rail nav until a decision exists in localStorage — the e2e suites were never updated when it shipped. **Fix (test-only):** `beforeEach` `addInitScript` seeds `molecule_cookie_consent` = `{decision:"rejected", version:1}` — "rejected" matches the privacy-preserving default; `version` must equal `CURRENT_VERSION` in CookieConsent.tsx or the record is ignored. (The other suites pass because their click targets sit above the banner; if more suites grow bottom-anchored interactions, promote this seed into a shared fixture.) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

core-devops added 1 commit 2026-06-11 18:14:16 +00:00

fix(staging-e2e): pre-seed cookie-consent decision (banner intercepts nav clicks) ... 4a0267d046

E2E Staging Canvas (Canvas tabs E2E) red on main: every
staging-concierge.spec nav click times out with

  <section aria-labelledby="cookie-consent-title" ...z-[9999]>
  intercepts pointer events

The CookieConsent banner (0dd4f259) is a fixed bottom overlay that
covers the left-rail nav buttons until a decision exists in
localStorage — the e2e suites were never taught about it.

Fix: beforeEach addInitScript seeds molecule_cookie_consent with
{decision:"rejected", version:1} — "rejected" matches the
privacy-preserving default and nothing in these tests depends on
optional cookies; version must match CookieConsent.tsx CURRENT_VERSION
or the record is ignored and the banner re-prompts.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-11 18:15:18 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

5-axis review on head 4a0267d046. Correctness: test-only fix pre-seeds molecule_cookie_consent before page scripts run, using decision='rejected' and version=1, which matches CookieConsent.tsx CURRENT_VERSION and storage key, so the banner is legitimately suppressed for staging-concierge E2E. Robustness: addInitScript runs before app code for each test context and is scoped to this suite; authenticate/install flow remains unchanged. Canvas tabs E2E is green on this head. Security/privacy: rejected is the privacy-preserving choice and no production consent behavior is changed. Performance: avoids repeated click retries/timeouts without adding runtime app cost. Readability: comment explains the z-index pointer-interception failure and version requirement. Approved as agent-reviewer-cr2.

5-axis review on head 4a0267d04644e0304c4429ec014f82539c899d46. Correctness: test-only fix pre-seeds molecule_cookie_consent before page scripts run, using decision='rejected' and version=1, which matches CookieConsent.tsx CURRENT_VERSION and storage key, so the banner is legitimately suppressed for staging-concierge E2E. Robustness: addInitScript runs before app code for each test context and is scoped to this suite; authenticate/install flow remains unchanged. Canvas tabs E2E is green on this head. Security/privacy: rejected is the privacy-preserving choice and no production consent behavior is changed. Performance: avoids repeated click retries/timeouts without adding runtime app cost. Readability: comment explains the z-index pointer-interception failure and version requirement. Approved as agent-reviewer-cr2.

devops-engineer merged commit 44ce19620e into main 2026-06-11 18:21:21 +00:00

core-devops referenced this pull request 2026-06-11 18:41:00 +00:00

staging concierge/org-map regressions: provisioned workspace lands at depth-1 beside the old root (re-parent broken?) + org-map canvas never mounts (45s) #2601

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2600