molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 18 Actions 2 Packages Projects Releases Wiki Activity

audit(installPlatformAgent): org_plugin_allowlist UNIQUE collision fails multi-root installs forever + missing FOR UPDATE + status='online' seed lie #2508

New Issue
Closed
opened 2026-06-10 05:29:13 +00:00 by core-devops · 0 comments
core-devops commented 2026-06-10 05:29:13 +00:00
Member
Copy Link
Copy Source

2026-06-10 audit on workspace-server/internal/handlers/platform_agent.go (the install IS correctly one tx + idempotent — these are hardening gaps):

  1. MEDIUM: org_plugin_allowlist has UNIQUE(org_id, plugin_name); with N>1 old roots allowlisting the SAME plugin, the second UPDATE…SET org_id collides 23505 → whole install fails deterministically on every retry (multi-root is in-contract input). Fix: INSERT…SELECT…ON CONFLICT DO NOTHING + DELETE leftovers.
  2. LOW: the old-roots SELECT takes no row locks (READ COMMITTED) — a root created mid-install is never re-parented → permanent two-root org. Add FOR UPDATE.
  3. LOW: the upsert seeds status='online' for a row with no container (green-dot lie until first heartbeat).

🤖 Generated with Claude Code

2026-06-10 audit on workspace-server/internal/handlers/platform_agent.go (the install IS correctly one tx + idempotent — these are hardening gaps): 1. MEDIUM: org_plugin_allowlist has UNIQUE(org_id, plugin_name); with N>1 old roots allowlisting the SAME plugin, the second UPDATE…SET org_id collides 23505 → whole install fails deterministically on every retry (multi-root is in-contract input). Fix: INSERT…SELECT…ON CONFLICT DO NOTHING + DELETE leftovers. 2. LOW: the old-roots SELECT takes no row locks (READ COMMITTED) — a root created mid-install is never re-parented → permanent two-root org. Add FOR UPDATE. 3. LOW: the upsert seeds status='online' for a row with no container (green-dot lie until first heartbeat). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2508
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?