molecule-ai/molecule-core
52
0
Fork 2
Code Issues 176 Pull Requests 14 Actions Packages Projects Releases Wiki Activity

Remove SOP tier system — single uniform gate (CTO 2026-06-07) #2403

New Issue
Closed
opened 2026-06-07 19:36:26 +00:00 by devops-engineer · 0 comments
devops-engineer commented 2026-06-07 19:36:26 +00:00
Member
Copy Link
Copy Source

CTO directive (2026-06-07)

"remove sop-tier-check / tier-check, there should not be such thing as tier, everything go through normal process"

Remove the SOP tier system entirely. Every PR goes through ONE uniform gate — no tier:low/tier:medium/tier:high branching, no sop-tier-check, no sop-tier-refire.

Target uniform gate ("normal process") — applies to EVERY PR

  • 2 genuine official code-review APPROVALs on current head (CR2 + Researcher), no REQUEST_CHANGES
  • CI / all-required green (+ E2E API Smoke, Handlers PG — branch-protection required set, UNCHANGED)
  • qa-review / approved green (now uniform — was only AND-gated for tier:medium)
  • security-review / approved green (now uniform)
  • sop-checklist / all-items-acked green
  • mergeable

Removal map (must be COMPLETE — fail-closed, no dangling gate ref)

DELETE:

  • .gitea/workflows/sop-tier-check.yml, .gitea/workflows/sop-tier-refire.yml
  • .gitea/scripts/sop-tier-check.sh, .gitea/scripts/sop-tier-refire.sh
  • tier tests: .gitea/scripts/tests/test_sop_tier_check_*.sh, test_sop_tier_refire.sh, _mock_tier_check.sh

EDIT:

  • tools/gate-check-v3/gate_check.py — remove TIER_AGENTS, _get_pr_tier, tier OR/AND verdict branching. Replace with a single uniform required-agent set (qa AND security AND engineers AND managers — strict). Update test_gate_check.py.
  • .gitea/scripts/gitea-merge-queue.py — remove _is_tier_low_pending_ok + its call; a pending required sop-checklist ALWAYS holds (no tier:low soft-fail). Update test_gitea_merge_queue.py.
  • required-context drift tests: tests/test_ci_required_drift.py, tests/test_lint_bp_context_emit_match.py, tests/test_lint_required_no_paths.py — drop any sop-tier-check expected context.
  • .gitea/sop-checklist-config.yaml — remove tier refs if any.
  • internal/runbooks/dev-sop.md — remove the tier section; document the single uniform gate.
  • Retire the tier:high|medium|low Gitea labels (cosmetic; after merge).

SOP requirements (merge-blocking)

  • Comprehensive tests + a GATING check that FAILS if a sop-tier-check context or tier-branching reappears (mutation-verified). Ref: file_issues_and_test_every_fix.
  • Fail-closed: removing a gate must not weaken the uniform bar — qa+security now run for ALL PRs (stronger, not weaker).

Supersedes

  • #2397, #2400 (these ADD auto-tier — wrong direction; closing/guarding).

Bootstrap note

The removal PR may be held by sop-tier-check emitted from BASE main until merged (catch-22). Branch-protection does NOT require tier-check, so once gitea-merge-queue.py no longer treats it as governance-red, the cron merges on 2-genuine + BP-green. If still wedged, owner bootstrap-merge (documented, diff-reviewed) per CTO directive.

## CTO directive (2026-06-07) > "remove sop-tier-check / tier-check, there should not be such thing as tier, everything go through normal process" Remove the SOP **tier** system entirely. Every PR goes through ONE uniform gate — no `tier:low`/`tier:medium`/`tier:high` branching, no `sop-tier-check`, no `sop-tier-refire`. ### Target uniform gate ("normal process") — applies to EVERY PR - 2 genuine official code-review APPROVALs on current head (CR2 + Researcher), no REQUEST_CHANGES - `CI / all-required` green (+ E2E API Smoke, Handlers PG — branch-protection required set, UNCHANGED) - `qa-review / approved` green (now uniform — was only AND-gated for tier:medium) - `security-review / approved` green (now uniform) - `sop-checklist / all-items-acked` green - mergeable ### Removal map (must be COMPLETE — fail-closed, no dangling gate ref) DELETE: - `.gitea/workflows/sop-tier-check.yml`, `.gitea/workflows/sop-tier-refire.yml` - `.gitea/scripts/sop-tier-check.sh`, `.gitea/scripts/sop-tier-refire.sh` - tier tests: `.gitea/scripts/tests/test_sop_tier_check_*.sh`, `test_sop_tier_refire.sh`, `_mock_tier_check.sh` EDIT: - `tools/gate-check-v3/gate_check.py` — remove `TIER_AGENTS`, `_get_pr_tier`, tier OR/AND verdict branching. Replace with a single uniform required-agent set (qa AND security AND engineers AND managers — strict). Update `test_gate_check.py`. - `.gitea/scripts/gitea-merge-queue.py` — remove `_is_tier_low_pending_ok` + its call; a pending required `sop-checklist` ALWAYS holds (no tier:low soft-fail). Update `test_gitea_merge_queue.py`. - required-context drift tests: `tests/test_ci_required_drift.py`, `tests/test_lint_bp_context_emit_match.py`, `tests/test_lint_required_no_paths.py` — drop any `sop-tier-check` expected context. - `.gitea/sop-checklist-config.yaml` — remove tier refs if any. - `internal/runbooks/dev-sop.md` — remove the tier section; document the single uniform gate. - Retire the `tier:high|medium|low` Gitea labels (cosmetic; after merge). ### SOP requirements (merge-blocking) - Comprehensive tests + a GATING check that FAILS if a `sop-tier-check` context or tier-branching reappears (mutation-verified). Ref: file_issues_and_test_every_fix. - Fail-closed: removing a gate must not weaken the uniform bar — qa+security now run for ALL PRs (stronger, not weaker). ### Supersedes - #2397, #2400 (these ADD auto-tier — wrong direction; closing/guarding). ### Bootstrap note The removal PR may be held by `sop-tier-check` emitted from BASE main until merged (catch-22). Branch-protection does NOT require tier-check, so once `gitea-merge-queue.py` no longer treats it as governance-red, the cron merges on 2-genuine + BP-green. If still wedged, owner bootstrap-merge (documented, diff-reviewed) per CTO directive.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2403
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?