molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 2 Packages Projects Releases Wiki Activity

fix(test): poll error counter to 0 before asserting in RecordsMetricsOnSuccess #195

Closed
core-fe wants to merge 1 commits from fix/sweeper-race-error-counter into main
pull from: fix/sweeper-race-error-counter
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 1
+7 -3
core-fe commented 2026-05-09 23:23:04 +00:00
Member
Copy Link
Copy Source

Summary

Race-detector CI runs (-race) are slow enough that a prior sweeper goroutine (TestStartSweeper_TransientErrorDoesNotCrashLoop) may still be running and incrementing pendingUploadsSweepErrors after RecordsMetricsOnSuccess captures its metricDelta() baseline, but before the success-path assertion. The test then reads deltaError=1 instead of 0.

Fix: add waitForMetricDelta(t, deltaError, 0, 2*time.Second) before the assertion, matching the polling pattern already used in the error-path test (TestStartSweeper_RecordsMetricsOnError). This ensures the error counter has settled before we assert on it.

Files

  • workspace-server/internal/pendinguploads/sweeper_test.go — RecordsMetricsOnSuccess now polls deltaError to 0 before asserting

Test plan

  • go test -race ./internal/pendinguploads/... in slow CI environment
  • No flakiness in TestStartSweeper_RecordsMetricsOnSuccess

Fixes molecule-core#22.

🤖 Generated with Claude Code

## Summary Race-detector CI runs (-race) are slow enough that a prior sweeper goroutine (TestStartSweeper_TransientErrorDoesNotCrashLoop) may still be running and incrementing pendingUploadsSweepErrors after RecordsMetricsOnSuccess captures its metricDelta() baseline, but before the success-path assertion. The test then reads deltaError=1 instead of 0. Fix: add waitForMetricDelta(t, deltaError, 0, 2*time.Second) before the assertion, matching the polling pattern already used in the error-path test (TestStartSweeper_RecordsMetricsOnError). This ensures the error counter has settled before we assert on it. ## Files - workspace-server/internal/pendinguploads/sweeper_test.go — RecordsMetricsOnSuccess now polls deltaError to 0 before asserting ## Test plan - [ ] go test -race ./internal/pendinguploads/... in slow CI environment - [ ] No flakiness in TestStartSweeper_RecordsMetricsOnSuccess Fixes molecule-core#22. 🤖 Generated with Claude Code
core-fe added 1 commit 2026-05-09 23:23:05 +00:00
fix(test): poll error counter to 0 before asserting in RecordsMetricsOnSuccess
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Failing after 4s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
e522547035 
Race-detector CI runs (-race) are slow enough that a prior sweeper
goroutine (TestStartSweeper_TransientErrorDoesNotCrashLoop) may still
be running and incrementing pendingUploadsSweepErrors after
RecordsMetricsOnSuccess captures its metricDelta() baseline, but before
the success-path assertion. The test then reads deltaError=1 instead
of 0.

Fix: add waitForMetricDelta(t, deltaError, 0, 2*time.Second) before
the assertion, matching the polling pattern already used in the
error-path test (TestStartSweeper_RecordsMetricsOnError). This
ensures the error counter has settled before we assert on it.

Fixes molecule-core#22.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-fe closed this pull request 2026-05-09 23:24:25 +00:00
Some checks are pending
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Required
Details
sop-tier-check / tier-check (pull_request) Failing after 4s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / all-required (pull_request)
Required
E2E API Smoke Test / E2E API Smoke Test (pull_request)
Required
Handlers Postgres Integration / Handlers Postgres Integration (pull_request)
Required
qa-review / approved (pull_request_target)
Required
security-review / approved (pull_request_target)
Required
reserved-path-review / reserved-path-review (pull_request_target)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#195
Delete Branch "fix/sweeper-race-error-counter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?