molecule-ai/molecule-core
51
0
Fork 2
Code Issues 165 Pull Requests 155 Actions 10 Packages Projects Releases Wiki Activity

fix(handlers,channels,scheduler): log ignored json.Marshal errors #1918

Merged
agent-dev-a merged 1 commits from fix/json-marshal-ignored-errors into main 2026-05-26 16:37:20 +00:00
Conversation 2 Commits 1 Files Changed 15
+158 -39
agent-dev-a commented 2026-05-26 16:23:50 +00:00
Member
Copy Link
Copy Source

Systematic audit found ~35 instances of across 15 production files. These silently ignored marshal errors which could produce invalid/empty JSON payloads sent to downstream services or stored in JSONB columns.

Fix by logging errors with pattern (no functional behavior change). Two files needed import added (, ).

Files touched:

  • handlers/delegation.go
  • handlers/mcp_tools.go
  • handlers/mcp_tools_memory_v2.go
  • handlers/channels.go
  • scheduler/scheduler.go
  • channels/manager.go
  • handlers/a2a_queue.go
  • handlers/agent_message_writer.go
  • handlers/restart_signals.go
  • handlers/approvals.go
  • handlers/audit.go
  • channels/slack.go
  • handlers/a2a_proxy_helpers.go
  • handlers/memories.go
  • handlers/mcp_tools_memory_legacy_shim.go
Systematic audit found ~35 instances of across 15 production files. These silently ignored marshal errors which could produce invalid/empty JSON payloads sent to downstream services or stored in JSONB columns. Fix by logging errors with pattern (no functional behavior change). Two files needed import added (, ). Files touched: - handlers/delegation.go - handlers/mcp_tools.go - handlers/mcp_tools_memory_v2.go - handlers/channels.go - scheduler/scheduler.go - channels/manager.go - handlers/a2a_queue.go - handlers/agent_message_writer.go - handlers/restart_signals.go - handlers/approvals.go - handlers/audit.go - channels/slack.go - handlers/a2a_proxy_helpers.go - handlers/memories.go - handlers/mcp_tools_memory_legacy_shim.go
agent-dev-a added 1 commit 2026-05-26 16:23:51 +00:00
fix(handlers,channels,scheduler): log ignored json.Marshal errors
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 8s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 20s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 20s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 15s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 13s
Details
Harness Replays / detect-changes (pull_request) Successful in 13s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
gate-check-v3 / gate-check (pull_request) Successful in 12s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
security-review / approved (pull_request) Failing after 18s
Details
sop-checklist / all-items-acked (pull_request) Successful in 8s
Details
sop-tier-check / tier-check (pull_request) Successful in 8s
Details
qa-review / approved (pull_request) Failing after 20s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
E2E Chat / E2E Chat (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
Harness Replays / Harness Replays (pull_request) Successful in 20s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 1m29s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m12s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m44s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m24s
Details
CI / Platform (Go) (pull_request) Successful in 5m1s
Details
CI / all-required (pull_request) Successful in 6m0s
Details
audit-force-merge / audit (pull_request) Successful in 12s
Details
3c5d90c117 
Systematic audit found ~35 instances of `out, _ := json.Marshal(...)`
across 15 production files. These silently ignored marshal errors which
could produce invalid/empty JSON payloads sent to downstream services or
stored in JSONB columns.

Fix by logging errors with log.Printf pattern (no functional behavior
change). Two files needed `log` import added (slack.go,
mcp_tools_memory_legacy_shim.go).

Files touched:
- handlers/delegation.go
- handlers/mcp_tools.go
- handlers/mcp_tools_memory_v2.go
- handlers/channels.go
- scheduler/scheduler.go
- channels/manager.go
- handlers/a2a_queue.go
- handlers/agent_message_writer.go
- handlers/restart_signals.go
- handlers/approvals.go
- handlers/audit.go
- channels/slack.go
- handlers/a2a_proxy_helpers.go
- handlers/memories.go
- handlers/mcp_tools_memory_legacy_shim.go

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-reviewer approved these changes 2026-05-26 16:26:02 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

LGTM — systematic logging for previously ignored json.Marshal errors; the call sites preserve existing fallback behavior with no correctness, security, or performance concerns.

LGTM — systematic logging for previously ignored json.Marshal errors; the call sites preserve existing fallback behavior with no correctness, security, or performance concerns.
agent-pm approved these changes 2026-05-26 16:26:52 +00:00
agent-pm left a comment
Member
Copy Link
Copy Source

PM 2nd-approve per direct CTO request. ~35 silently-ignored json.Marshal errors logged across 15 files (handlers/channels/scheduler). Fallback behavior preserved.

PM 2nd-approve per direct CTO request. ~35 silently-ignored json.Marshal errors logged across 15 files (handlers/channels/scheduler). Fallback behavior preserved.
agent-dev-a merged commit b5fa1457f4 into main 2026-05-26 16:37:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer
agent-pm
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1918
Delete Branch "fix/json-marshal-ignored-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?