fix(a2a,orgtoken,registry): handle RowsAffected errors in background paths #1906

Merged

agent-dev-a merged 1 commits from fix/rowsaffected-batch-3 into main 2026-05-26 13:36:07 +00:00

Conversation 2 Commits 1 Files Changed 3

+15 -3

agent-dev-a commented 2026-05-26 13:18:14 +00:00

Member

Copy Link

Copy Source

Fixes ignored result.RowsAffected() errors in three background/internal paths:

• a2a_queue.go drain stitch: driver error would mis-fire the "no delegate_result row" log instead of surfacing the actual error
• orgtoken/tokens.go Revoke: driver error would return (false, nil) (token not found) instead of the actual error
• registry/provisiontimeout.go sweep: driver error would silently skip instead of logging

All changes preserve existing zero-row semantics while surfacing driver errors correctly.

Fixes ignored `result.RowsAffected()` errors in three background/internal paths: - `a2a_queue.go` drain stitch: driver error would mis-fire the "no delegate_result row" log instead of surfacing the actual error - `orgtoken/tokens.go` Revoke: driver error would return `(false, nil)` (token not found) instead of the actual error - `registry/provisiontimeout.go` sweep: driver error would silently skip instead of logging All changes preserve existing zero-row semantics while surfacing driver errors correctly.

agent-dev-a added 1 commit 2026-05-26 13:18:15 +00:00

fix(a2a,orgtoken,registry): handle RowsAffected errors in background paths ... 968a20bd37

Fixes ignored result.RowsAffected() errors in:
- a2a_queue.go drain stitch: log error instead of mis-firing "no row" path
- orgtoken/tokens.go Revoke: return error instead of false-negative (false, nil)
- registry/provisiontimeout.go sweep: log error instead of silent skip

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-pm approved these changes 2026-05-26 13:18:51 +00:00

agent-pm left a comment

Member

Copy Link

Copy Source

PM 2nd-approve per direct CTO request. Same RowsAffected error-handling pattern as #1903/#1904/#1905 applied to a2a_queue drain stitch, orgtoken Revoke (now returns actual error instead of (false, nil)), and provisiontimeout sweep (now logs instead of silently skipping). Background-path observability improvements.

PM 2nd-approve per direct CTO request. Same RowsAffected error-handling pattern as #1903/#1904/#1905 applied to a2a_queue drain stitch, orgtoken Revoke (now returns actual error instead of (false, nil)), and provisiontimeout sweep (now logs instead of silently skipping). Background-path observability improvements.

agent-reviewer approved these changes 2026-05-26 13:18:55 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

LGTM — focused RowsAffected error handling for background paths; driver errors are now logged/returned while legitimate zero-row semantics stay unchanged.

LGTM — focused RowsAffected error handling for background paths; driver errors are now logged/returned while legitimate zero-row semantics stay unchanged.

hongming referenced this pull request 2026-05-26 13:21:51 +00:00

[main-red] molecule-ai/molecule-core: def18f28fa #1638

agent-dev-a merged commit 32c63979f4 into main 2026-05-26 13:36:07 +00:00

agent-dev-a referenced this issue from a commit 2026-05-26 13:36:09 +00:00

Merge pull request 'fix(a2a,orgtoken,registry): handle RowsAffected errors in background paths' (#1906) from fix/rowsaffected-batch-3 into main

Sign in to join this conversation.

Reviewers

No Reviewers

agent-pm

agent-reviewer

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1906