molecule-ai/molecule-core
51
0
Fork 2
Code Issues 163 Pull Requests 154 Actions 17 Packages Projects Releases Wiki Activity

fix(canvas): normalize legacy attachment content URLs #1845

Merged
hongming merged 1 commits from fix/legacy-content-attachment-uri into main 2026-05-25 13:19:22 +00:00
Conversation 4 Commits 1 Files Changed 2
+39
hongming commented 2026-05-25 13:10:17 +00:00
Owner
Copy Link
Copy Source

What

  • Rewrite legacy /workspaces/<ws>/content/<file>/content attachment URIs to the current /pending-uploads/<file>/content endpoint.
  • Treat those legacy URIs as platform attachments so preview/download fetches include auth headers instead of the browser loading a raw 404 image URL.

Why

External/poll-mode attachment messages can still contain the older content URL shape. The live canvas currently treats that as a non-platform image URL, causing the browser to request a route that no longer exists.

Verification

  • npm test -- --run src/components/tabs/chat/__tests__/uploads.test.ts
  • git diff --check
## What - Rewrite legacy `/workspaces/<ws>/content/<file>/content` attachment URIs to the current `/pending-uploads/<file>/content` endpoint. - Treat those legacy URIs as platform attachments so preview/download fetches include auth headers instead of the browser loading a raw 404 image URL. ## Why External/poll-mode attachment messages can still contain the older content URL shape. The live canvas currently treats that as a non-platform image URL, causing the browser to request a route that no longer exists. ## Verification - `npm test -- --run src/components/tabs/chat/__tests__/uploads.test.ts` - `git diff --check`
hongming added 1 commit 2026-05-25 13:10:18 +00:00
fix(canvas): normalize legacy attachment content URLs
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 8s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 11s
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
CI / Detect changes (pull_request) Successful in 15s
Details
E2E Chat / detect-changes (pull_request) Successful in 10s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 13s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 10s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
CI / Platform (Go) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 9s
Details
E2E Chat / E2E Chat (pull_request) Successful in 9s
Details
Harness Replays / Harness Replays (pull_request) Successful in 16s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 16s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m5s
Details
security-review / approved (pull_request) Refired via /security-recheck by claude-ceo-assistant
Details
qa-review / approved (pull_request) Refired via /qa-recheck by claude-ceo-assistant
Details
CI / Canvas (Next.js) (pull_request) Successful in 4m48s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 8m0s
Details
audit-force-merge / audit (pull_request) Successful in 6s
Details
850a3c58d4
core-qa approved these changes 2026-05-25 13:16:24 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

[core-qa-agent] APPROVED

Reviewed regression coverage and local verification. Canvas now treats the legacy /workspaces//content//content shape as a platform attachment and rewrites it to the current pending-upload endpoint; malformed legacy paths remain raw. No QA findings.

[core-qa-agent] APPROVED Reviewed regression coverage and local verification. Canvas now treats the legacy /workspaces/<ws>/content/<file>/content shape as a platform attachment and rewrites it to the current pending-upload endpoint; malformed legacy paths remain raw. No QA findings.
core-security approved these changes 2026-05-25 13:16:54 +00:00
core-security left a comment
Member
Copy Link
Copy Source

[core-security-agent] APPROVED

Reviewed auth boundary: the new resolver only recognizes relative legacy platform content URLs and keeps third-party HTTP(S) URLs on the unauthenticated external path. Platform bytes still fetch through the existing auth-header flow. No security findings.

[core-security-agent] APPROVED Reviewed auth boundary: the new resolver only recognizes relative legacy platform content URLs and keeps third-party HTTP(S) URLs on the unauthenticated external path. Platform bytes still fetch through the existing auth-header flow. No security findings.
hongming commented 2026-05-25 13:17:02 +00:00
Author
Owner
Copy Link
Copy Source

/qa-recheck

/qa-recheck
hongming commented 2026-05-25 13:17:02 +00:00
Author
Owner
Copy Link
Copy Source

/security-recheck

/security-recheck
hongming merged commit 02368d8278 into main 2026-05-25 13:19:22 +00:00
hongming deleted branch fix/legacy-content-attachment-uri 2026-05-25 13:19:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1845
Delete Branch "fix/legacy-content-attachment-uri"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?