molecule-ai/molecule-core
51
0
Fork 2
Code Issues 165 Pull Requests 155 Actions 10 Packages Projects Releases Wiki Activity

build(tenant-image): remove memory-backfill binary from Dockerfile.tenant (post-A3) #1812

New Issue
Closed
opened 2026-05-24 23:00:38 +00:00 by hongming · 0 comments
hongming commented 2026-05-24 23:00:38 +00:00
Owner
Copy Link
Copy Source

Summary

cmd/memory-backfill is still bundled into the tenant image via Dockerfile.tenant (added in #1796). After Phase A3 (#1809) dropped the agent_memories source table, the binary is permanently inert — running it now fails with pq: relation "agent_memories" does not exist. Bundling it wastes ~7MB per image and risks an operator running it expecting it to do something.

Reproduction

On any tenant on staging-4a610ca or later:

docker exec molecule-tenant /memory-backfill -apply
# → ERROR:  relation "agent_memories" does not exist

Fix

  1. Remove the memory-backfill build stage from Dockerfile.tenant (the RUN go build ... -o /memory-backfill ./cmd/memory-backfill block + the COPY --from=go-builder /memory-backfill /memory-backfill + reference in the chown line).
  2. Optionally remove cmd/memory-backfill/ and verify.go from the repo entirely. They're documented as one-shot migration tooling that has fulfilled its purpose. Keep for one release cycle if you want the history-via-git log, then remove.

Acceptance

  • Dockerfile.tenant no longer builds or includes /memory-backfill
  • After redeploy, docker exec molecule-tenant ls /memory-backfill returns "No such file"
  • Image size shrinks by ~7MB

Discovered during

2026-05-24 memory-system migration session, called out in #1809 PR body.

## Summary `cmd/memory-backfill` is still bundled into the tenant image via `Dockerfile.tenant` (added in #1796). After Phase A3 (#1809) dropped the `agent_memories` source table, the binary is permanently inert — running it now fails with `pq: relation "agent_memories" does not exist`. Bundling it wastes ~7MB per image and risks an operator running it expecting it to do something. ## Reproduction On any tenant on `staging-4a610ca` or later: ```bash docker exec molecule-tenant /memory-backfill -apply # → ERROR: relation "agent_memories" does not exist ``` ## Fix 1. Remove the memory-backfill build stage from `Dockerfile.tenant` (the `RUN go build ... -o /memory-backfill ./cmd/memory-backfill` block + the `COPY --from=go-builder /memory-backfill /memory-backfill` + reference in the chown line). 2. Optionally remove `cmd/memory-backfill/` and `verify.go` from the repo entirely. They're documented as one-shot migration tooling that has fulfilled its purpose. Keep for one release cycle if you want the history-via-`git log`, then remove. ## Acceptance - [ ] Dockerfile.tenant no longer builds or includes `/memory-backfill` - [ ] After redeploy, `docker exec molecule-tenant ls /memory-backfill` returns "No such file" - [ ] Image size shrinks by ~7MB ## Discovered during 2026-05-24 memory-system migration session, called out in #1809 PR body.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?