molecule-ai/molecule-core
51
0
Fork 2
Code Issues 164 Pull Requests 155 Actions 12 Packages Projects Releases Wiki Activity

build(controlplane): remove dead MEMORY_V2_CUTOVER env from tenant user-data (post-A3) #1811

New Issue
Closed
opened 2026-05-24 23:00:38 +00:00 by hongming · 0 comments
hongming commented 2026-05-24 23:00:38 +00:00
Owner
Copy Link
Copy Source

Summary

molecule-controlplane/internal/provisioner/ec2.go:2232 still injects -e MEMORY_V2_CUTOVER='true' \ into the tenant docker-run command. Post-#1809 (Phase A3 in molecule-core, 2026-05-24) the entrypoint no longer reads this variable — the deprecation shim that bridged it to MEMORY_PLUGIN_URL was removed. The line is now literal dead text in user-data.

No production impact (it's just a no-op env var on the tenant container), but it's the last lingering reference to the v1 deprecation shim across both repos.

Reproduction

grep -n MEMORY_V2_CUTOVER ~/Documents/GitHub/molecule-controlplane/internal/provisioner/ec2.go
# 2232:  -e MEMORY_V2_CUTOVER='true' \

Entrypoint side that no longer cares (workspace-server post-A3):

grep -n MEMORY_V2_CUTOVER workspace-server/entrypoint-tenant.sh
# (no matches)

Fix

Remove the single line -e MEMORY_V2_CUTOVER='true' \ from internal/provisioner/ec2.go. Add a brief comment noting the removal references #1809 / Phase A3.

Acceptance

  • Line removed from controlplane ec2.go
  • CI/tests green on molecule-controlplane
  • After CP redeploy, a fresh tenant boot doesn't include the env var in docker inspect molecule-tenant

Discovered during

2026-05-24 memory-system migration session, called out in #1809 PR body as a follow-up.

## Summary `molecule-controlplane/internal/provisioner/ec2.go:2232` still injects `-e MEMORY_V2_CUTOVER='true' \` into the tenant docker-run command. Post-#1809 (Phase A3 in molecule-core, 2026-05-24) the entrypoint no longer reads this variable — the deprecation shim that bridged it to `MEMORY_PLUGIN_URL` was removed. The line is now literal dead text in user-data. No production impact (it's just a no-op env var on the tenant container), but it's the last lingering reference to the v1 deprecation shim across both repos. ## Reproduction ``` grep -n MEMORY_V2_CUTOVER ~/Documents/GitHub/molecule-controlplane/internal/provisioner/ec2.go # 2232: -e MEMORY_V2_CUTOVER='true' \ ``` Entrypoint side that no longer cares (workspace-server post-A3): ``` grep -n MEMORY_V2_CUTOVER workspace-server/entrypoint-tenant.sh # (no matches) ``` ## Fix Remove the single line `-e MEMORY_V2_CUTOVER='true' \` from `internal/provisioner/ec2.go`. Add a brief comment noting the removal references #1809 / Phase A3. ## Acceptance - [ ] Line removed from controlplane ec2.go - [ ] CI/tests green on molecule-controlplane - [ ] After CP redeploy, a fresh tenant boot doesn't include the env var in `docker inspect molecule-tenant` ## Discovered during 2026-05-24 memory-system migration session, called out in #1809 PR body as a follow-up.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1811
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?