molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

MCP-tool memory writes don't broadcast ACTIVITY_LOGGED — canvas can't live-refresh on them #1754

New Issue
Closed
opened 2026-05-24 00:02:35 +00:00 by hongming · 0 comments
hongming commented 2026-05-24 00:02:35 +00:00
Owner
Copy Link
Copy Source

MCP-tool memory writes don't broadcast ACTIVITY_LOGGED — canvas Memory tab can't live-refresh on them

Problem

MemoryInspectorPanel.tsx (after PR #1749) subscribes to ACTIVITY_LOGGED WS events filtered to memory-write activity_types so the panel auto-refreshes when an agent commits a memory. Discovered while reviewing #1749 that the MCP-tool memory paths (commit_memory, commit_memory_v2, commit_summary, recall_memory, forget_memory) don't actually emit ACTIVITY_LOGGED on the wire.

What's missing

Today, the only emitters of ACTIVITY_LOGGED for memory operations are:

Path Source activity_type
POST /workspaces/:id/memories (REST, GLOBAL only) memories.go:218 via LogActivity memory_write_global
PATCH /workspaces/:id/memories/:id (REST, GLOBAL only) memories.go:617 via LogActivity memory_edit_global
DELETE /workspaces/:id/memories/:id (REST, GLOBAL only) memories.go via LogActivity memory_delete_global
Self-reported via POST /workspaces/:id/activity agent_log (or whatever the agent supplies)

The MCP-tool paths bypass LogActivity:

MCP tool Handler Result
commit_memory (legacy shim) mcp_tools.go:toolCommitMemory → mcp_tools_memory_legacy_shim.go:commitMemoryLegacyShim → plugin (post-#1747) No LogActivity call
commit_memory_v2 mcp_tools_memory_v2.go:toolCommitMemoryV2 → plugin No LogActivity call
commit_summary mcp_tools_memory_v2.go:toolCommitSummary → plugin No LogActivity call
recall_memory (legacy shim) mcp_tools.go:toolRecallMemory → plugin No LogActivity call (reads don't need to broadcast)
forget_memory mcp_tools_memory_v2.go:toolForgetMemory → plugin No LogActivity call

So when an agent calls commit_memory from chat — the most common case — the canvas Memory tab does NOT receive an ACTIVITY_LOGGED event keyed by activity_type='memory_write'. PR #1749's filter handles this over-inclusively by also matching activity_type='agent_log', but that depends on whether the agent self-reports — which is per-runtime and not guaranteed.

Proposed fix

Add LogActivity calls in the MCP tool handlers right after the plugin call succeeds:

// in toolCommitMemoryV2 after h.memv2.plugin.CommitMemory(...) succeeds
_ = activity.LogActivity(ctx, h.database, workspaceID, activity.Payload{
    Type:   "memory_write",
    Source: "agent",
    Summary: fmt.Sprintf("commit_memory to %s", namespace),
})

Plus equivalent for toolCommitSummary (memory_summary_write?), toolForgetMemory (memory_delete?).

recall_memory reads should NOT emit — too noisy and not useful for live UI refresh.

Tracking

Once this lands, the over-inclusive agent_log filter in MemoryInspectorPanel.tsx can be narrowed to just the memory-* types. The component already has a TODO-via-comment naming this issue in its filter block (added in #1749 review).

Tier

area:memory area:observability tier:low — quality-of-life for canvas Memory tab, no security or data implications. Should land after the A0+A1 memory cleanup train (#1742, #1747) so the LogActivity calls land on the v2-only code path.

Refs

  • #1749 (canvas Memory tab live-refresh — this is the server-side counterpart)
  • #1733 (memory SSOT consolidation parent issue)
# MCP-tool memory writes don't broadcast `ACTIVITY_LOGGED` — canvas Memory tab can't live-refresh on them ## Problem `MemoryInspectorPanel.tsx` (after PR #1749) subscribes to `ACTIVITY_LOGGED` WS events filtered to memory-write `activity_type`s so the panel auto-refreshes when an agent commits a memory. Discovered while reviewing #1749 that the MCP-tool memory paths (`commit_memory`, `commit_memory_v2`, `commit_summary`, `recall_memory`, `forget_memory`) don't actually emit `ACTIVITY_LOGGED` on the wire. ## What's missing Today, the only emitters of `ACTIVITY_LOGGED` for memory operations are: | Path | Source | activity_type | |---|---|---| | `POST /workspaces/:id/memories` (REST, GLOBAL only) | `memories.go:218` via `LogActivity` | `memory_write_global` | | `PATCH /workspaces/:id/memories/:id` (REST, GLOBAL only) | `memories.go:617` via `LogActivity` | `memory_edit_global` | | `DELETE /workspaces/:id/memories/:id` (REST, GLOBAL only) | `memories.go` via `LogActivity` | `memory_delete_global` | | Self-reported via `POST /workspaces/:id/activity` | `agent_log` (or whatever the agent supplies) | The MCP-tool paths bypass `LogActivity`: | MCP tool | Handler | Result | |---|---|---| | `commit_memory` (legacy shim) | `mcp_tools.go:toolCommitMemory` → `mcp_tools_memory_legacy_shim.go:commitMemoryLegacyShim` → plugin (post-#1747) | No `LogActivity` call | | `commit_memory_v2` | `mcp_tools_memory_v2.go:toolCommitMemoryV2` → plugin | No `LogActivity` call | | `commit_summary` | `mcp_tools_memory_v2.go:toolCommitSummary` → plugin | No `LogActivity` call | | `recall_memory` (legacy shim) | `mcp_tools.go:toolRecallMemory` → plugin | No `LogActivity` call (reads don't need to broadcast) | | `forget_memory` | `mcp_tools_memory_v2.go:toolForgetMemory` → plugin | No `LogActivity` call | So when an agent calls `commit_memory` from chat — the most common case — the canvas Memory tab does NOT receive an `ACTIVITY_LOGGED` event keyed by `activity_type='memory_write'`. PR #1749's filter handles this over-inclusively by also matching `activity_type='agent_log'`, but that depends on whether the agent self-reports — which is per-runtime and not guaranteed. ## Proposed fix Add `LogActivity` calls in the MCP tool handlers right after the plugin call succeeds: ```go // in toolCommitMemoryV2 after h.memv2.plugin.CommitMemory(...) succeeds _ = activity.LogActivity(ctx, h.database, workspaceID, activity.Payload{ Type: "memory_write", Source: "agent", Summary: fmt.Sprintf("commit_memory to %s", namespace), }) ``` Plus equivalent for `toolCommitSummary` (`memory_summary_write`?), `toolForgetMemory` (`memory_delete`?). `recall_memory` reads should NOT emit — too noisy and not useful for live UI refresh. ## Tracking Once this lands, the over-inclusive `agent_log` filter in `MemoryInspectorPanel.tsx` can be narrowed to just the memory-* types. The component already has a TODO-via-comment naming this issue in its filter block (added in #1749 review). ## Tier `area:memory` `area:observability` `tier:low` — quality-of-life for canvas Memory tab, no security or data implications. Should land after the A0+A1 memory cleanup train (#1742, #1747) so the LogActivity calls land on the v2-only code path. ## Refs - #1749 (canvas Memory tab live-refresh — this is the server-side counterpart) - #1733 (memory SSOT consolidation parent issue)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1754
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?