molecule-ai/molecule-core
49
0
Fork 2
Code Issues 146 Pull Requests 159 Actions 5 Packages Projects Releases Wiki Activity

feat: #1686 add Container Config tab skeleton #1705

Merged
hongming merged 1 commits from feat/1686-container-config-tab into main 2026-05-23 06:50:04 +00:00
Conversation 3 Commits 1 Files Changed 7
+160 -7
hongming commented 2026-05-23 06:33:12 +00:00
Owner
Copy Link
Copy Source

Summary

  • Adds a Canvas side-panel Container tab for the #1686 Track B container/runtime surface.
  • Keeps it separate from EC2 compute shape editing: no instance type, root volume, display mode, GPU, or OS controls are shown here.
  • Shows read-only runtime/container fields from existing canvas node data where available: runtime image, workspace access, max concurrent tasks, mounted container path, privileges, delivery mode, session controls, status, active tasks.

Comprehensive testing performed

  • canvas: npm test -- --run src/components/__tests__/SidePanel.tabs.test.tsx src/components/tabs/__tests__/ContainerConfigTab.test.tsx src/store/__tests__/canvas.test.ts src/store/__tests__/canvas-topology.test.ts
  • canvas: npm run build

Local-postgres E2E run

N/A: Canvas-only read-only tab skeleton. No backend schema, SQL, or Postgres behavior changed.

Staging-smoke verified or pending

Pending: PR CI will run the Canvas and staging-canvas checks. No live staging deploy has been triggered from this feature branch.

Root-cause not symptom

#1686 Track B requested a separate Container Config tab so runtime/container settings do not get mixed into the EC2 compute/display shape editor. This adds that separate surface and keeps it read-only until backend edit endpoints exist.

Five-Axis review walked

  • Correctness: The tab is added to the typed panel tab union, SidePanel render switch, and ARIA tab tests.
  • Readability: New component is a single small read-only view with local row helpers.
  • Architecture: Uses existing canvas node data and avoids a new backend endpoint for a skeleton surface.
  • Security: Does not expose raw host workspace paths or secrets; displays the mounted container path /workspace only.
  • Performance: No new network call; render-only component.

No backwards-compat shim / dead code added

No compatibility shim or dead code added. Existing Config tab remains unchanged; Container tab is a new sibling tab.

Memory/saved-feedback consulted

No saved memory was needed for this slice. Used live #1686 comments, merged PR #1701 state, and repo-local code/tests.

## Summary - Adds a Canvas side-panel Container tab for the #1686 Track B container/runtime surface. - Keeps it separate from EC2 compute shape editing: no instance type, root volume, display mode, GPU, or OS controls are shown here. - Shows read-only runtime/container fields from existing canvas node data where available: runtime image, workspace access, max concurrent tasks, mounted container path, privileges, delivery mode, session controls, status, active tasks. ## Comprehensive testing performed - [x] `canvas: npm test -- --run src/components/__tests__/SidePanel.tabs.test.tsx src/components/tabs/__tests__/ContainerConfigTab.test.tsx src/store/__tests__/canvas.test.ts src/store/__tests__/canvas-topology.test.ts` - [x] `canvas: npm run build` ## Local-postgres E2E run N/A: Canvas-only read-only tab skeleton. No backend schema, SQL, or Postgres behavior changed. ## Staging-smoke verified or pending Pending: PR CI will run the Canvas and staging-canvas checks. No live staging deploy has been triggered from this feature branch. ## Root-cause not symptom #1686 Track B requested a separate Container Config tab so runtime/container settings do not get mixed into the EC2 compute/display shape editor. This adds that separate surface and keeps it read-only until backend edit endpoints exist. ## Five-Axis review walked - Correctness: The tab is added to the typed panel tab union, SidePanel render switch, and ARIA tab tests. - Readability: New component is a single small read-only view with local row helpers. - Architecture: Uses existing canvas node data and avoids a new backend endpoint for a skeleton surface. - Security: Does not expose raw host workspace paths or secrets; displays the mounted container path `/workspace` only. - Performance: No new network call; render-only component. ## No backwards-compat shim / dead code added No compatibility shim or dead code added. Existing Config tab remains unchanged; Container tab is a new sibling tab. ## Memory/saved-feedback consulted No saved memory was needed for this slice. Used live #1686 comments, merged PR #1701 state, and repo-local code/tests.
hongming added 1 commit 2026-05-23 06:33:12 +00:00
Add container config tab skeleton
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 12s
Details
CI / Detect changes (pull_request) Successful in 21s
Details
CI / Python Lint & Test (pull_request) Successful in 12s
Details
E2E Chat / detect-changes (pull_request) Successful in 30s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 31s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 13s
Details
Harness Replays / detect-changes (pull_request) Successful in 17s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 24s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 15s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 12s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
gate-check-v3 / gate-check (pull_request) Successful in 15s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 11s
Details
CI / Platform (Go) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m37s
Details
E2E Chat / E2E Chat (pull_request) Successful in 23s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 4s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m57s
Details
CI / all-required (pull_request) Successful in 9m8s
Details
qa-review / approved (pull_request) Refired via /qa-recheck by core-qa
Details
security-review / approved (pull_request) Refired via /security-recheck by core-security
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 7/7
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
audit-force-merge / audit (pull_request) Successful in 14s
Details
2be87e66a9
hongming requested review from core-qa 2026-05-23 06:33:27 +00:00
hongming requested review from core-security 2026-05-23 06:33:28 +00:00
hongming added the tier:medium label 2026-05-23 06:33:28 +00:00
core-qa approved these changes 2026-05-23 06:44:44 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

QA approval for #1686 Container Config tab skeleton. Scope is Canvas-only, read-only, separate from compute/display shape editing. Local tests/build and PR CI implementation jobs are green.

QA approval for #1686 Container Config tab skeleton. Scope is Canvas-only, read-only, separate from compute/display shape editing. Local tests/build and PR CI implementation jobs are green.
core-security approved these changes 2026-05-23 06:44:46 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Security approval for #1686 Container Config tab skeleton. No backend access expansion, no new network call, no secrets, and host workspace_dir is not surfaced; mounted path is fixed to /workspace.

Security approval for #1686 Container Config tab skeleton. No backend access expansion, no new network call, no secrets, and host workspace_dir is not surfaced; mounted path is fixed to /workspace.
core-devops commented 2026-05-23 06:46:14 +00:00
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing verified local canvas tests/build and PR CI
/sop-ack local-postgres-e2e N/A canvas-only change
/sop-ack staging-smoke staging-canvas PR check passed
/sop-ack root-cause container config separated from compute/display editing
/sop-ack five-axis-review reviewed correctness readability architecture security performance
/sop-ack no-backwards-compat no shim or dead code
/sop-ack memory-consulted live issue/repo context sufficient

/sop-ack comprehensive-testing verified local canvas tests/build and PR CI /sop-ack local-postgres-e2e N/A canvas-only change /sop-ack staging-smoke staging-canvas PR check passed /sop-ack root-cause container config separated from compute/display editing /sop-ack five-axis-review reviewed correctness readability architecture security performance /sop-ack no-backwards-compat no shim or dead code /sop-ack memory-consulted live issue/repo context sufficient
hongming merged commit 5cc570a18f into main 2026-05-23 06:50:04 +00:00
hongming deleted branch feat/1686-container-config-tab 2026-05-23 06:50:08 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label tier:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1705
Delete Branch "feat/1686-container-config-tab"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?