molecule-ai/molecule-core
52
0
Fork 2
Code Issues 180 Pull Requests 15 Actions 9 Packages Projects Releases Wiki Activity

RFC: standardize persistent-secrets pattern across ALL workspace templates (Gitea tokens, OAuth blobs, vendor keys survive container restart) #1689

New Issue
Open
opened 2026-05-22 22:47:22 +00:00 by hongming · 0 comments
hongming commented 2026-05-22 22:47:22 +00:00
Owner
Copy Link
Copy Source

Why

Multiple secrets-don't-survive-restart incidents in the last week:

  • 2026-05-22: codex Researcher + CR auth.json gets wiped on restart (start.sh re-injects from env-var snapshot — see #35 for that template's fix)
  • 2026-05-22: Engineer-B MiniMax Gitea token wiped on restart (was env-only via CP admin /env push). I manually persisted by writing to /configs/secrets.d/ + patching entrypoint.sh to source it.
  • Other templates likely have similar gaps.

Proposal

Standardize one pattern across EVERY workspace template:

A. /configs/secrets.d/ is the persistent SSOT for workspace secrets

  • Volume-mounted from EC2 host /configs/
  • One file per secret: /configs/secrets.d/<KEY> contains the value (no key=value, just the value)
  • /configs/secrets.d/load.sh sources each file + exports as env var
  • Mode 0600, owned by ubuntu:ubuntu

The codex template already does this via molecule-controlplane's /env push. Make this universal.

B. Every template's entrypoint.sh sources it FIRST

#!/bin/sh
# Source persistent workspace secrets BEFORE anything else that might need them.
# /configs is volume-mounted from the host so this survives container restart.
if [ -f /configs/secrets.d/load.sh ]; then
  . /configs/secrets.d/load.sh
fi
# ... rest of entrypoint ...

C. CP admin /env push writes through to /configs/secrets.d/

When POST /cp/admin/workspaces/<id>/env is called, molecule-controlplane should write the new env vars to /configs/secrets.d/<KEY> (one file per key) so they survive container restart. Currently this only happens for some templates / some keys.

This is the molecule-controlplane-side change: the workspace-template side only needs the entrypoint.sh source-line (Section B).

Acceptance

  • Every workspace template's entrypoint sources /configs/secrets.d/load.sh (idempotent guard)
  • molecule-controlplane writes through /env push → /configs/secrets.d/<KEY> files
  • Test: restart a workspace, env vars persist
  • Audit: list all currently-deployed templates + report which have the entrypoint source line + which don't

Touchpoints

  • molecule-ai-workspace-template-claude-code
  • molecule-ai-workspace-template-codex (already has it for CODEX_AUTH_JSON specifically — generalize)
  • molecule-ai-workspace-template-hermes
  • molecule-ai-workspace-template-openclaw
  • molecule-ai-workspace-template-langgraph / autogen / crewai / etc.
  • molecule-controlplane (the /env-push → /configs/secrets.d/ write-through)

Owner

TBD. Cross-team — touches ALL workspace template repos + controlplane. ~1w end-to-end.

## Why Multiple secrets-don't-survive-restart incidents in the last week: - 2026-05-22: codex Researcher + CR auth.json gets wiped on restart (start.sh re-injects from env-var snapshot — see #35 for that template's fix) - 2026-05-22: Engineer-B MiniMax Gitea token wiped on restart (was env-only via CP admin /env push). I manually persisted by writing to /configs/secrets.d/ + patching entrypoint.sh to source it. - Other templates likely have similar gaps. ## Proposal Standardize one pattern across EVERY workspace template: ### A. `/configs/secrets.d/` is the persistent SSOT for workspace secrets - Volume-mounted from EC2 host `/configs/` - One file per secret: `/configs/secrets.d/<KEY>` contains the value (no key=value, just the value) - `/configs/secrets.d/load.sh` sources each file + exports as env var - Mode 0600, owned by ubuntu:ubuntu The codex template already does this via molecule-controlplane's `/env` push. Make this universal. ### B. Every template's entrypoint.sh sources it FIRST ```bash #!/bin/sh # Source persistent workspace secrets BEFORE anything else that might need them. # /configs is volume-mounted from the host so this survives container restart. if [ -f /configs/secrets.d/load.sh ]; then . /configs/secrets.d/load.sh fi # ... rest of entrypoint ... ``` ### C. CP admin `/env` push writes through to /configs/secrets.d/ When `POST /cp/admin/workspaces/<id>/env` is called, molecule-controlplane should write the new env vars to `/configs/secrets.d/<KEY>` (one file per key) so they survive container restart. Currently this only happens for some templates / some keys. This is the molecule-controlplane-side change: the workspace-template side only needs the entrypoint.sh source-line (Section B). ## Acceptance - Every workspace template's entrypoint sources `/configs/secrets.d/load.sh` (idempotent guard) - molecule-controlplane writes through `/env` push → `/configs/secrets.d/<KEY>` files - Test: restart a workspace, env vars persist - Audit: list all currently-deployed templates + report which have the entrypoint source line + which don't ## Touchpoints - molecule-ai-workspace-template-claude-code - molecule-ai-workspace-template-codex (already has it for CODEX_AUTH_JSON specifically — generalize) - molecule-ai-workspace-template-hermes - molecule-ai-workspace-template-openclaw - molecule-ai-workspace-template-langgraph / autogen / crewai / etc. - molecule-controlplane (the /env-push → /configs/secrets.d/ write-through) ## Owner TBD. Cross-team — touches ALL workspace template repos + controlplane. ~1w end-to-end.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?