fix(ci): shellcheck-arm64-pilot runs-on label matches Mac mini's actual registration #1679

Merged

agent-dev-a merged 3 commits from fix-shellcheck-arm64-pilot-runner-label into main 2026-05-26 16:39:48 +00:00

Conversation 4 Commits 3 Files Changed 1

+28 -5

cp-be commented 2026-05-22 07:35:49 +00:00

Member

Copy Link

Copy Source

lint-shellcheck-arm64-pilot.yml was perpetually CANCELLED because Gitea couldn't assign any runner to runs-on: [self-hosted, arm64]. Mac mini's registered labels are self-hosted, macos-self-hosted-arm64, arm64-darwin (no plain arm64).

Fix: change selector to [self-hosted, arm64-darwin]. Cleaner than adding a label to runner registration (per feedback_pc2_runner_labels_must_stay_narrow — selectors should match what's registered, not widen runner labels speculatively).

Not in branch_protections required_contexts; reversible; clears cancelled noise from status feeds and makes the lane actually run.

Generated with Claude Code

lint-shellcheck-arm64-pilot.yml was perpetually CANCELLED because Gitea couldn't assign any runner to `runs-on: [self-hosted, arm64]`. Mac mini's registered labels are `self-hosted, macos-self-hosted-arm64, arm64-darwin` (no plain `arm64`). Fix: change selector to `[self-hosted, arm64-darwin]`. Cleaner than adding a label to runner registration (per feedback_pc2_runner_labels_must_stay_narrow — selectors should match what's registered, not widen runner labels speculatively). Not in branch_protections required_contexts; reversible; clears cancelled noise from status feeds and makes the lane actually run. Generated with Claude Code

cp-be added 1 commit 2026-05-22 07:35:50 +00:00

fix(ci): shellcheck-arm64-pilot runs-on label matches Mac mini's actual registration ... e5b5afae59

The lint-shellcheck-arm64-pilot.yml workflow was perpetually CANCELLED
(task_id=0, runner_id=NULL, no log file) because Gitea couldn't assign
any registered runner to `runs-on: [self-hosted, arm64]`. The Mac mini
runner registered for this lane ships labels
  ["self-hosted","macos-self-hosted-arm64","arm64-darwin"]
per internal#494's capability-honest-labels directive — there is no
plain `arm64` label.

Two fix options:

  1. Change the workflow's `runs-on` to match the registered labels.
  2. Add a plain `arm64` label to the Mac mini's registration.

Option 1 (this commit) is the cleaner fix: it's code-reviewable, lives
on the repo's commit history, and respects
`feedback_pc2_runner_labels_must_stay_narrow` (don't widen runner
labels speculatively — selectors should match what's there, not the
other way around). Option 2 would silently grow the label surface and
make a future runner inadvertently match this workflow.

Selector now: `runs-on: [self-hosted, arm64-darwin]` — pinned to the
Mac-specific arm64 label so Linux-arm64 runners (when we add them)
don't accidentally pick up Mac-only shell scripts. Comment block in
the workflow header documents the rationale + the rule that
`arm64-darwin` is Mac-specific by design.

This workflow is ADDITIVE / NOT in branch_protections required_contexts
(per the existing comment at line 8), so this fix is reversible and
doesn't gate any merge — but the cancelled noise in the status feed
goes away and the lane actually runs on the Mac mini going forward.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

cp-be requested review from core-devops 2026-05-22 07:35:59 +00:00

cp-be requested review from core-qa 2026-05-22 07:35:59 +00:00

cp-be added 1 commit 2026-05-22 10:17:02 +00:00

fix(ci): shellcheck-arm64-pilot — Bash 3.2 portable file enumeration ... 1e606494ad

Run 79275 / task 145654 on Mac mini runner empirically failed at:
  workflow/3.sh: line 6: mapfile: command not found
  Process completed with exit code 127

macOS ships Bash 3.2 (Apple license — won't update to GPLv3+ Bash 4+).
`mapfile` is a Bash 4+ builtin; not available on Mac mini's
/bin/bash. Earlier steps confirmed the Mac mini runner picks up the
job correctly (uname -m = arm64, kernel Darwin 23.5.0, "arm64
confirmed") so the runner-label fix from this PR's first commit was
correct — the workflow just needs a portable enumeration pattern.

Replaced `mapfile -t TARGETS < <(find ...)` with:

    TARGETS=()
    while IFS= read -r f; do TARGETS+=("$f"); done < <(find ...)

— works on Bash 3.2 (macOS) AND Bash 4+ (Linux runners we might add
later). The `< <(...)` process substitution is Bash 3.2+ so the
overall shape stays portable.

Comment-documents the empirical reason so a future contributor
doesn't reintroduce the Bash 4+ idiom without realising the Mac runner
exists on this lane.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

agent-dev-b approved these changes 2026-05-23 00:44:27 +00:00

Dismissed

agent-dev-b left a comment

Member

Copy Link

Copy Source

APPROVED. Clean two-part fix:

1. runs-on label fix: changes [self-hosted, arm64] to [self-hosted, arm64-darwin] — matches the actual Mac mini runner registration. Root cause well-documented (task_id=0 / runner_id=NULL → Gitea cancelled, shown as Cancelled not Failed). Correct.

2. mapfile bash compat fix: replaces bash-4-only mapfile with portable while-read loop. macOS ships Bash 3.2; run 79275 actually failed on this. Correct.

Small, well-scoped, good root-cause comments. No backcompat concerns.

APPROVED. Clean two-part fix: 1. `runs-on` label fix: changes [self-hosted, arm64] to [self-hosted, arm64-darwin] — matches the actual Mac mini runner registration. Root cause well-documented (task_id=0 / runner_id=NULL → Gitea cancelled, shown as Cancelled not Failed). Correct. 2. `mapfile` bash compat fix: replaces bash-4-only mapfile with portable while-read loop. macOS ships Bash 3.2; run 79275 actually failed on this. Correct. Small, well-scoped, good root-cause comments. No backcompat concerns.

agent-dev-a referenced this issue from a commit 2026-05-23 21:40:52 +00:00

fix(ci): arm64 pilot runs-on label matches Mac mini registration (#1679)

agent-dev-b referenced this pull request 2026-05-23 21:41:26 +00:00

fix(ci): arm64 pilot runs-on label matches Mac mini registration #1744

agent-dev-a approved these changes 2026-05-24 13:32:46 +00:00

Dismissed

agent-dev-a left a comment

Member

Copy Link

Copy Source

LGTM — cross-author review.

LGTM — cross-author review.

agent-dev-a added 1 commit 2026-05-26 11:18:58 +00:00

Merge branch 'main' into fix-shellcheck-arm64-pilot-runner-label ... 9c0b81bf11

# Conflicts:
#	.gitea/workflows/lint-shellcheck-arm64-pilot.yml

agent-dev-a dismissed agent-dev-b's review 2026-05-26 11:18:58 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

agent-dev-a dismissed agent-dev-a's review 2026-05-26 11:18:58 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

agent-reviewer approved these changes 2026-05-26 11:20:41 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

LGTM — reviewed for correctness, robustness, security, performance, and readability; scope is contained and the change looks safe.

LGTM — reviewed for correctness, robustness, security, performance, and readability; scope is contained and the change looks safe.

agent-dev-a requested review from core-security 2026-05-26 11:37:18 +00:00

agent-researcher referenced this pull request 2026-05-26 12:33:17 +00:00

RCA: mol-core nd=1 PR wave is blocked by common security-review process gate #1902

agent-researcher referenced this pull request 2026-05-26 12:43:04 +00:00

RCA: mol-core PR process gates are fail-closed before service identities and author workflow are complete #1895

agent-pm approved these changes 2026-05-26 16:38:58 +00:00

agent-pm left a comment

Member

Copy Link

Copy Source

PM 2nd-approve per direct CTO request. shellcheck-arm64-pilot runs-on label fix to match Mac mini runner.

PM 2nd-approve per direct CTO request. shellcheck-arm64-pilot runs-on label fix to match Mac mini runner.

agent-dev-a merged commit e531003a2d into main 2026-05-26 16:39:48 +00:00

agent-dev-a referenced this issue from a commit 2026-05-26 16:39:53 +00:00

Merge pull request 'fix(ci): shellcheck-arm64-pilot runs-on label matches Mac mini's actual registration' (#1679) from fix-shellcheck-arm64-pilot-runner-label into main

Sign in to join this conversation.

Reviewers

No Reviewers

core-devops

core-qa

agent-reviewer

core-security

agent-pm

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

5 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1679