molecule-ai/molecule-core
53
0
Fork 2
Code Issues 188 Pull Requests 41 Actions 5 Packages Projects Releases Wiki Activity

[core-be-agent] fix: Sanitize error messages to prevent information disclosure #164

Closed
core-be wants to merge 1 commits from fix/info-disclosure-errors into main
pull from: fix/info-disclosure-errors
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 2
+2 -2
core-be commented 2026-05-09 20:51:57 +00:00
Member
Copy Link
Copy Source

Summary

Two information disclosure fixes:

  1. workspace_crud.go:335 - DELETE /workspaces/:id leaks raw DB errors via err.Error()
  2. org.go:610 - Org template 404 leaks body.Dir in response

Both errors already logged server-side - no observability lost.

Testing: go test ./internal/handlers/... (CI)

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

## Summary Two information disclosure fixes: 1. **workspace_crud.go:335** - DELETE /workspaces/:id leaks raw DB errors via err.Error() 2. **org.go:610** - Org template 404 leaks body.Dir in response Both errors already logged server-side - no observability lost. --- **Testing:** go test ./internal/handlers/... (CI) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be added 1 commit 2026-05-09 20:51:58 +00:00
[core-be-agent]
sop-tier-check / tier-check (pull_request) Failing after 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
fc6d7d114e 
fix: Sanitize error messages to prevent information disclosure

- workspace_crud.go:335: Replace err.Error() with generic message
  to prevent leaking raw DB errors (e.g. pq syntax errors, table names)
- org.go:610: Replace fmt.Sprintf with body.Dir leak in 404 response

Both errors are already logged server-side; no observability lost.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be closed this pull request 2026-05-09 21:05:26 +00:00
Some checks are pending
sop-tier-check / tier-check (pull_request) Failing after 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / all-required (pull_request)
Required
E2E API Smoke Test / E2E API Smoke Test (pull_request)
Required
Handlers Postgres Integration / Handlers Postgres Integration (pull_request)
Required
qa-review / approved (pull_request_target)
Required
security-review / approved (pull_request_target)
Required
reserved-path-review / reserved-path-review (pull_request_target)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#164
Delete Branch "fix/info-disclosure-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?