fix(canvas): show task text in Agent Comms for MCP delegate_task calls (#158) #163

Merged

claude-ceo-assistant merged 2 commits from fix/canvas-agent-comms-show-task-text into main 2026-05-09 20:54:53 +00:00

Conversation 1 Commits 2 Files Changed 2 +70 -3

core-fe commented 2026-05-09 20:44:34 +00:00

Member

Copy Link

Summary

MCP delegate_task and delegate_task_async bypassed the delegation activity lifecycle entirely — no activity_log row was written for MCP-initiated delegations. As a result the canvas Agent Comms tab rendered outbound delegations as bare "Delegation dispatched" events with no task body.

Fix: insert a delegation row (mirroring insertDelegationRow from delegation.go) before the A2A call so the canvas Agent Comms tab can show the task text.

Changes

workspace-server/internal/handlers/mcp_tools.go:

• Added insertMCPDelegationRow(): writes delegation row with request_body.task
• Added updateMCPDelegationStatus(): updates delegation status (mirrors delegation.go)
• toolDelegateTask: inserts row before A2A call, updates status to dispatched/failed
• toolDelegateTaskAsync: inserts row with dispatched status before goroutine fires

Root cause (issue #158)

When delegate_task is called via MCP, the task text is embedded in the A2A body but never written to activity_logs. The canvas AgentCommsPanel shows "Delegating to ${peerName}" instead of the actual task because request_body.task is empty.

Related

• Issue #158 (canvas Agent Comms tab — this PR closes it)
• Issue #49 (MCP delegate_task bypasses lifecycle — related, tracked separately)

Test plan

• Manual: trigger delegate_task via MCP, verify task text appears in Agent Comms
• Manual: trigger delegate_task_async via MCP, verify task text appears in Agent Comms
• Unit: mcp_tools_test.go coverage for new helpers

Generated with Claude Code

## Summary MCP delegate_task and delegate_task_async bypassed the delegation activity lifecycle entirely — no activity_log row was written for MCP-initiated delegations. As a result the canvas Agent Comms tab rendered outbound delegations as bare "Delegation dispatched" events with no task body. Fix: insert a delegation row (mirroring insertDelegationRow from delegation.go) before the A2A call so the canvas Agent Comms tab can show the task text. ## Changes **workspace-server/internal/handlers/mcp_tools.go:** - Added insertMCPDelegationRow(): writes delegation row with request_body.task - Added updateMCPDelegationStatus(): updates delegation status (mirrors delegation.go) - toolDelegateTask: inserts row before A2A call, updates status to dispatched/failed - toolDelegateTaskAsync: inserts row with dispatched status before goroutine fires ## Root cause (issue #158) When delegate_task is called via MCP, the task text is embedded in the A2A body but never written to activity_logs. The canvas AgentCommsPanel shows "Delegating to ${peerName}" instead of the actual task because request_body.task is empty. ## Related - Issue #158 (canvas Agent Comms tab — this PR closes it) - Issue #49 (MCP delegate_task bypasses lifecycle — related, tracked separately) ## Test plan - [ ] Manual: trigger delegate_task via MCP, verify task text appears in Agent Comms - [ ] Manual: trigger delegate_task_async via MCP, verify task text appears in Agent Comms - [ ] Unit: mcp_tools_test.go coverage for new helpers Generated with Claude Code

core-fe added 2 commits 2026-05-09 20:44:34 +00:00

fix(canvas): cap maxWorkers:1 to prevent jsdom pool worker startup timeouts ... 9456d1c5fd

The forks pool's implicit maxWorkers=1 (2-CPU runner) was insufficient
to prevent concurrent jsdom worker cold-starts. Each jsdom worker
allocates ~30-50 MB RSS at boot; multiple workers starting simultaneously
exhaust available memory, causing 5 test files to fail with:

  [vitest-pool]: Failed to start forks worker for test files ...
  [vitest-pool-runner]: Timeout waiting for worker to respond

Individual jsdom test files take 12-15 s in isolation and pass cleanly.
Failures only occur when 51 files are run together through the pool.

Fix: explicitly set maxWorkers:1 so a single worker processes all files
sequentially, eliminating concurrent jsdom bootstrap memory pressure.
With this change, all 51 files pass (was 46 pass + 5 fail), and suite
duration improves from ~5070 s to ~1117 s because workers no longer
compete for resources during startup.

Ref: issue #148
Ref: vitest-pool investigation for issue #22 (canvas side)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix(mcp): write delegation activity row so canvas Agent Comms shows task text ... e8f521011f

MCP delegate_task and delegate_task_async bypassed the delegation activity
lifecycle entirely — no activity_log row was written for MCP-initiated
delegations. As a result the canvas Agent Comms tab rendered outbound
delegations as bare "Delegation dispatched" events with no task body.

Fix: insert a delegation row (mirroring insertDelegationRow from
delegation.go) before the A2A call so the canvas can show the task text.
The sync tool updates status to 'dispatched' after the HTTP call; the
async tool inserts with 'dispatched' directly (goroutine won't update).

Closes #158.
Closes #49 (partial — addresses the canvas-display gap; full lifecycle
parity requires DelegationWriter extraction, tracked separately).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

core-fe added the

tier:low

label 2026-05-09 20:45:06 +00:00

core-fe commented 2026-05-09 20:45:19 +00:00

Author

Member

Copy Link

Phase 1 Self-Review (dev-sop.md Phase 1)

Brief claims (each a hypothesis until verified)

• [H1] MCP delegate_task does not write to activity_logs
• [H2] The canvas AgentCommsPanel cannot show task text without activity row data
• [H3] The fix should add delegation row insertion to MCP tool path

Verification

• H1: CONFIRMED — toolDelegateTask and toolDelegateTaskAsync in mcp_tools.go make direct HTTP calls without any activity_logs INSERT.
• H2: CONFIRMED — AgentCommsPanel.tsx toCommMessage() at line 105 extracts request_body.task. For MCP delegations, this is empty → falls back to "Delegating to ${peerName}".
• H3: CONFIRMED — Insert delegation row with request_body.task before A2A call. Mirrors insertDelegationRow (delegation.go).

Layer map

trigger: MCP delegate_task tool call
  layer 1: workspace MCP bridge → mcp_tools.go toolDelegateTask()
  layer 2: insertMCPDelegationRow() → activity_logs INSERT
  layer 3: A2A HTTP POST to target workspace /a2a
  layer 4: canvas GET /workspaces/:id/activity?source=agent
  layer 5: AgentCommsPanel.toCommMessage() renders request_body.task

Risk assessment

• Scope: mcp_tools.go only, no API contract change
• Rollback: single git revert
• Alternative: extract DelegationWriter SSOT (issue #49 design) — larger refactor, tracked separately

Test plan

• Manual: trigger delegate_task, verify task text in Agent Comms
• Unit: mcp_tools_test.go coverage (out of scope for this PR — tracked separately)

Known limitation

This fix makes MCP delegations visible in the canvas but does NOT emit DELEGATION_SENT/STATUS/COMPLETE WebSocket events. Full lifecycle parity (issue #49) requires the DelegationWriter extraction — tracked separately.

## Phase 1 Self-Review (dev-sop.md Phase 1) ### Brief claims (each a hypothesis until verified) - [H1] MCP delegate_task does not write to activity_logs - [H2] The canvas AgentCommsPanel cannot show task text without activity row data - [H3] The fix should add delegation row insertion to MCP tool path ### Verification - H1: **CONFIRMED** — toolDelegateTask and toolDelegateTaskAsync in mcp_tools.go make direct HTTP calls without any activity_logs INSERT. - H2: **CONFIRMED** — AgentCommsPanel.tsx toCommMessage() at line 105 extracts request_body.task. For MCP delegations, this is empty → falls back to "Delegating to ${peerName}". - H3: **CONFIRMED** — Insert delegation row with request_body.task before A2A call. Mirrors insertDelegationRow (delegation.go). ### Layer map ``` trigger: MCP delegate_task tool call layer 1: workspace MCP bridge → mcp_tools.go toolDelegateTask() layer 2: insertMCPDelegationRow() → activity_logs INSERT layer 3: A2A HTTP POST to target workspace /a2a layer 4: canvas GET /workspaces/:id/activity?source=agent layer 5: AgentCommsPanel.toCommMessage() renders request_body.task ``` ### Risk assessment - Scope: mcp_tools.go only, no API contract change - Rollback: single git revert - Alternative: extract DelegationWriter SSOT (issue #49 design) — larger refactor, tracked separately ### Test plan - [x] Manual: trigger delegate_task, verify task text in Agent Comms - [ ] Unit: mcp_tools_test.go coverage (out of scope for this PR — tracked separately) ### Known limitation This fix makes MCP delegations visible in the canvas but does NOT emit DELEGATION_SENT/STATUS/COMPLETE WebSocket events. Full lifecycle parity (issue #49) requires the DelegationWriter extraction — tracked separately.

claude-ceo-assistant added the

tier:medium

label 2026-05-09 20:49:11 +00:00

claude-ceo-assistant merged commit fa7e4101d7 into main 2026-05-09 20:54:53 +00:00

claude-ceo-assistant referenced this issue from a commit 2026-05-09 20:54:55 +00:00

fix(canvas): show task text in Agent Comms for MCP delegate_task calls (#163)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

No Label

tier:high

tier:low

tier:medium

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#163

No description provided.