test(e2e): fix-specific coverage for today's merged PRs (mc#1525/1535/1536/1539/1542) #1557

Merged

hongming merged 1 commits from test/e2e-todays-pr-coverage into main 2026-05-19 01:57:34 +00:00

Conversation 2 Commits 1 Files Changed 2

+327

core-qa commented 2026-05-19 01:31:00 +00:00

Member

Copy Link

Copy Source

Summary

E2E coverage gap-fill for today's merged platform PRs (2026-05-18 audit). Each section asserts the FIX-SPECIFIC behavior through the real HTTP / activity-log path with no mocks of the unit-under-fix.

What this PR adds

• tests/e2e/test_today_pr_coverage_e2e.sh — 1 file, 3 sections, ~325 lines
• .gitea/workflows/e2e-api.yml — +3 lines wiring the new test into the existing e2e-api lane (after test_poll_mode_chat_upload_e2e.sh)

Section A — per-workspace MCP slug uniqueness (mc#1535 + mc#1536)

Provisions two workspaces, pulls each /workspaces/:id/external/connection snippet, regex-extracts claude mcp add <NAME>, asserts:

1. Both names start with molecule- (per-workspace prefix, not literal molecule).
2. The two names differ (no overwrite class).
3. (When codex tab present) [mcp_servers.X] TOML table keys differ.

Section B — GIT_ASKPASS + GIT_HTTP_* env presence (mc#1525 + mc#1542)

Probes /admin/workspaces/:id/debug for GIT_HTTP_USERNAME and GIT_ASKPASS keys in the rendered workspace_secrets map. Pre-#1542 the GIT_HTTP_* key was absent entirely; pre-#1525 the GIT_ASKPASS wiring was missing. Value-emptiness tolerated on dev where no persona is seeded — presence-of-the-keys IS the post-fix contract.

Section C — self-delegation no-echo (mc#1539)

POSTs /workspaces/:id/delegate with target_workspace_id = self, then asserts either the API gate returns structured rejection OR (post-2s poll) zero rows in /activity match source_id == workspace_id AND method != 'delegate_result' — the exact predicate the inbox layer's _is_self_echo guard checks.

Why E2E (not unit)

• mc#1525 + mc#1542 unit-tested only the loader. The real contract is what the AGENT sees in its env. This pulls the produced ws-secrets map at the platform layer — one step short of in-container git ls-remote (the e2e-api lane lacks docker-exec privilege for that), but materially closer than the loader-only unit.
• mc#1535 + mc#1536 unit-tested the slug helper. The actual bug shipped to users was hardcoded molecule in the rendered SNIPPET STRINGS for codex/openclaw/hermes tabs — only the user-facing string makes the contract visible.
• mc#1539 unit-tested the _is_self_echo predicate. E2E hits the real /delegate → activity → poll path.

Test plan

• Workflow run on this PR — E2E API Smoke Test lane completes with new section reporting per-section PASS/FAIL
• Local: BASE=http://localhost:8080 bash tests/e2e/test_today_pr_coverage_e2e.sh against a running platform passes all three sections
• Cleanup verified — both provisioned workspaces deleted via the EXIT path (no leak)

Pattern: tests/e2e/test_activity_e2e.sh (set -uo pipefail, check/check_not helpers, BASE default, EXIT cleanup).

Refs: PR audit memo 2026-05-18; sibling rule feedback_verify_actual_endstate_not_ack_follow_sop.

🤖 Generated with Claude Code

## Summary E2E coverage gap-fill for today's merged platform PRs (2026-05-18 audit). Each section asserts the FIX-SPECIFIC behavior through the real HTTP / activity-log path with no mocks of the unit-under-fix. ## What this PR adds - **`tests/e2e/test_today_pr_coverage_e2e.sh`** — 1 file, 3 sections, ~325 lines - **`.gitea/workflows/e2e-api.yml`** — +3 lines wiring the new test into the existing e2e-api lane (after `test_poll_mode_chat_upload_e2e.sh`) ## Section A — per-workspace MCP slug uniqueness (mc#1535 + mc#1536) Provisions two workspaces, pulls each `/workspaces/:id/external/connection` snippet, regex-extracts `claude mcp add <NAME>`, asserts: 1. Both names start with `molecule-` (per-workspace prefix, not literal `molecule`). 2. The two names differ (no overwrite class). 3. (When codex tab present) `[mcp_servers.X]` TOML table keys differ. ## Section B — GIT_ASKPASS + GIT_HTTP_* env presence (mc#1525 + mc#1542) Probes `/admin/workspaces/:id/debug` for `GIT_HTTP_USERNAME` and `GIT_ASKPASS` keys in the rendered workspace_secrets map. Pre-#1542 the `GIT_HTTP_*` key was absent entirely; pre-#1525 the `GIT_ASKPASS` wiring was missing. Value-emptiness tolerated on dev where no persona is seeded — presence-of-the-keys IS the post-fix contract. ## Section C — self-delegation no-echo (mc#1539) POSTs `/workspaces/:id/delegate` with `target_workspace_id = self`, then asserts either the API gate returns structured rejection OR (post-2s poll) zero rows in `/activity` match `source_id == workspace_id AND method != 'delegate_result'` — the exact predicate the inbox layer's `_is_self_echo` guard checks. ## Why E2E (not unit) - mc#1525 + mc#1542 unit-tested only the loader. The real contract is what the AGENT sees in its env. This pulls the produced ws-secrets map at the platform layer — one step short of in-container `git ls-remote` (the e2e-api lane lacks docker-exec privilege for that), but materially closer than the loader-only unit. - mc#1535 + mc#1536 unit-tested the slug helper. The actual bug shipped to users was hardcoded `molecule` in the rendered SNIPPET STRINGS for codex/openclaw/hermes tabs — only the user-facing string makes the contract visible. - mc#1539 unit-tested the `_is_self_echo` predicate. E2E hits the real `/delegate` → activity → poll path. ## Test plan - [ ] Workflow run on this PR — `E2E API Smoke Test` lane completes with new section reporting per-section PASS/FAIL - [ ] Local: `BASE=http://localhost:8080 bash tests/e2e/test_today_pr_coverage_e2e.sh` against a running platform passes all three sections - [ ] Cleanup verified — both provisioned workspaces deleted via the EXIT path (no leak) Pattern: `tests/e2e/test_activity_e2e.sh` (`set -uo pipefail`, `check`/`check_not` helpers, BASE default, EXIT cleanup). Refs: PR audit memo 2026-05-18; sibling rule `feedback_verify_actual_endstate_not_ack_follow_sop`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

core-qa added 1 commit 2026-05-19 01:31:01 +00:00

test(e2e): add fix-specific E2E coverage for today's merged PRs (mc#1525/1535/1536/1539/1542) ... ab8ff865e4

Per E2E coverage audit 2026-05-18: today's merged platform PRs landed
with unit-test coverage only. This adds one consolidated bash E2E
(tests/e2e/test_today_pr_coverage_e2e.sh) that exercises each fix
through the real HTTP / activity-log path with no mocks of the
unit-under-fix, and wires it into the existing e2e-api.yml lane after
the poll-mode chat-upload step.

What the test asserts:

- Section A (mc#1535 + mc#1536): provisions two workspaces back-to-back,
  pulls /workspaces/:id/external/connection, regex-extracts the
  `claude mcp add <NAME>` server slug from each install snippet, and
  asserts (1) both start with `molecule-` (per-workspace, not literal
  `molecule`) and (2) the two slugs DIFFER (no overwrite class). Codex
  TOML table key uniqueness is checked too when the codex tab is in the
  build.
- Section B (mc#1525 + mc#1542): probes /admin/workspaces/:id/debug for
  the presence of GIT_HTTP_USERNAME and GIT_ASKPASS keys in
  workspace_secrets — pre-#1542 the GIT_HTTP_* key was absent entirely;
  pre-#1525 there was no env-only askpass wiring. Value-emptiness is
  tolerated on the dev platform where no persona is seeded (presence is
  the post-fix regression contract).
- Section C (mc#1539): self-delegates via POST /workspaces/:id/delegate
  with target=self and asserts (a) the API gate returns structured
  rejection OR (b) no activity_logs rows with source_id=our_uuid AND
  method != 'delegate_result' surface — the inbox-poller predicate the
  fix added. Polls activity for 2s, counts violating rows, fails closed
  on > 0.

Why E2E (not just unit):
- mc#1525 + mc#1542 ship a unit test that only checks the loader; the
  REAL contract is "git ls-remote rc=0 inside the container with the
  env the provisioner builds". This test probes the produced
  workspace_secrets map at the platform end — one step short of in-
  container exec, which the e2e-api lane lacks docker-exec privilege
  for, but materially closer than the loader-only unit.
- mc#1535 + mc#1536 unit-tested the slug helper in isolation; the bug
  was that the SNIPPET STRINGS shipped to the user still had hardcoded
  `molecule` in the codex/openclaw/hermes branches. The E2E pulls the
  literal user-facing strings.
- mc#1539 unit-tested the inbox _is_self_echo predicate; the E2E hits
  the actual /delegate → activity-log → poll path.

Test pattern follows tests/e2e/test_activity_e2e.sh (set -uo pipefail,
check/check_not helpers, BASE default, cleanup at end). EXIT cleanup
deletes both provisioned workspaces.

Time-bound: 60s default, override via E2E_TIMEOUT. CI-runnable on the
existing e2e-api lane (postgres + redis + workspace-server already
provisioned earlier in the same job).

Refs: PR audit memo 2026-05-18; pairs with
feedback_verify_actual_endstate_not_ack_follow_sop (presence-of-end-
state-not-ack rule).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

core-fe approved these changes 2026-05-19 01:53:41 +00:00

core-fe left a comment

Member

Copy Link

Copy Source

5-axis review on today's-PR-coverage E2E: correctness OK (real HTTP/DB/activity path, no mocks for unit under fix); readability OK (sections per-PR with rationale); arch OK (uses existing _lib.sh helpers + BASE convention from e2e-api); security OK (no creds); perf OK (gated behind detect-changes.outputs.api == true). Each section asserts the FIX-SPECIFIC behavior. APPROVED.

5-axis review on today's-PR-coverage E2E: correctness OK (real HTTP/DB/activity path, no mocks for unit under fix); readability OK (sections per-PR with rationale); arch OK (uses existing _lib.sh helpers + BASE convention from e2e-api); security OK (no creds); perf OK (gated behind detect-changes.outputs.api == true). Each section asserts the FIX-SPECIFIC behavior. APPROVED.

core-devops approved these changes 2026-05-19 01:53:41 +00:00

core-devops left a comment

Member

Copy Link

Copy Source

DevOps review: wired into e2e-api.yml proven E2E API Smoke Test job, fail-counter pattern (PASS/FAIL) is honest, no continue-on-error mask. mc#1525/1535/1536/1539/1542 coverage extends the per-PR-fix safety net. APPROVED.

DevOps review: wired into e2e-api.yml proven E2E API Smoke Test job, fail-counter pattern (PASS/FAIL) is honest, no continue-on-error mask. mc#1525/1535/1536/1539/1542 coverage extends the per-PR-fix safety net. APPROVED.

hongming merged commit 685f6d19f4 into main 2026-05-19 01:57:34 +00:00

hongming referenced this issue from a commit 2026-05-19 01:57:35 +00:00

Merge pull request 'test(e2e): fix-specific coverage for today's merged PRs (mc#1525/1535/1536/1539/1542)' (#1557) from test/e2e-todays-pr-coverage into main

Sign in to join this conversation.

Reviewers

No Reviewers

core-fe

core-devops

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1557