fix(canvas/chat): surface actionable error reason in chat banner + link to Activity tab (internal#212) #1550

Merged

hongming merged 1 commits from fix/canvas-surface-error-detail into main 2026-05-19 01:56:13 +00:00

Conversation 2 Commits 1 Files Changed 5

+355 -19

core-devops commented 2026-05-19 00:39:37 +00:00

Member

Copy Link

Copy Source

Summary

• useChatSocket now forwards ACTIVITY_LOGGED.error_detail (introduced server-side in #1549) into onSendError so the banner shows the provider's actionable reason — provider HTTP status + error code + human message — instead of the hardcoded opaque "Agent error (Exception) — see workspace logs for details." (which pointed at a workspace-logs tab that doesn't exist)
• new ChatErrorBanner component with a working View activity log button that calls setPanelTab("activity"), turning the dangling "see workspace logs" reference into a real affordance; the offline-only Restart button is preserved
• graceful degradation against an older ws-server: when error_detail is absent the hook falls back to the legacy boilerplate so we never silently swallow a failure (boundary requirement from the task spec)

Reason field shape (consumed)

From ACTIVITY_LOGGED.payload.error_detail — a single string, already secret-safe (server-side scrubber + this trust boundary stays defensive). Examples the user will now see verbatim:

• Anthropic 403 oauth_org_not_allowed: Your organization has disabled Claude subscription access for Claude Code — use an Anthropic API key or ask your admin to enable access.
• kimi 401 invalid_api_key: provided key is wrong

Before / after

Before (internal#212):

┌────────────────────────────────────────────────────────────┐
│ Agent error (Exception) — see workspace logs for details.  │
└────────────────────────────────────────────────────────────┘

("workspace logs" tab does not exist; nothing to click)

After:

┌────────────────────────────────────────────────────────────────────────┐
│ Anthropic 403 oauth_org_not_allowed: Your organization has disabled    │
│ Claude subscription access for Claude Code — use an Anthropic API key  │
│ or ask your admin to enable access.                                    │
│                                              [View activity log]       │
└────────────────────────────────────────────────────────────────────────┘

(View activity log switches the side panel to the Activity tab)

Test plan

• vitest run — 285 tests across touched files green (3 new hook tests, 5 new banner tests)
  • useChatSocket.test.tsx — forwards detail when present, falls back when absent, ignores cross-workspace events
  • ChatTab.errorBanner.test.tsx — renders reason verbatim, falls back to legacy boilerplate, navigates to Activity tab, Restart preserved offline, null message renders nothing
• tsc --noEmit clean on changed files
• depends on #1549 (ws-server adds the error_detail field to the broadcast payload). This canvas PR is forward-compatible — if it lands first, behavior is unchanged (fallback path).

Refs: internal#212, feedback_surface_actionable_failure_reason_to_user
Depends-on: #1549

## Summary - `useChatSocket` now forwards `ACTIVITY_LOGGED.error_detail` (introduced server-side in #1549) into `onSendError` so the banner shows the provider's actionable reason — provider HTTP status + error code + human message — instead of the hardcoded opaque `"Agent error (Exception) — see workspace logs for details."` (which pointed at a workspace-logs tab that doesn't exist) - new `ChatErrorBanner` component with a working `View activity log` button that calls `setPanelTab("activity")`, turning the dangling "see workspace logs" reference into a real affordance; the offline-only `Restart` button is preserved - graceful degradation against an older ws-server: when `error_detail` is absent the hook falls back to the legacy boilerplate so we never silently swallow a failure (boundary requirement from the task spec) ## Reason field shape (consumed) From `ACTIVITY_LOGGED.payload.error_detail` — a single string, already secret-safe (server-side scrubber + this trust boundary stays defensive). Examples the user will now see verbatim: - `Anthropic 403 oauth_org_not_allowed: Your organization has disabled Claude subscription access for Claude Code — use an Anthropic API key or ask your admin to enable access.` - `kimi 401 invalid_api_key: provided key is wrong` ## Before / after **Before** (internal#212): ``` ┌────────────────────────────────────────────────────────────┐ │ Agent error (Exception) — see workspace logs for details. │ └────────────────────────────────────────────────────────────┘ ``` ("workspace logs" tab does not exist; nothing to click) **After**: ``` ┌────────────────────────────────────────────────────────────────────────┐ │ Anthropic 403 oauth_org_not_allowed: Your organization has disabled │ │ Claude subscription access for Claude Code — use an Anthropic API key │ │ or ask your admin to enable access. │ │ [View activity log] │ └────────────────────────────────────────────────────────────────────────┘ ``` (`View activity log` switches the side panel to the Activity tab) ## Test plan - [x] `vitest run` — 285 tests across touched files green (3 new hook tests, 5 new banner tests) - `useChatSocket.test.tsx` — forwards detail when present, falls back when absent, ignores cross-workspace events - `ChatTab.errorBanner.test.tsx` — renders reason verbatim, falls back to legacy boilerplate, navigates to Activity tab, Restart preserved offline, null message renders nothing - [x] `tsc --noEmit` clean on changed files - [ ] depends on #1549 (ws-server adds the `error_detail` field to the broadcast payload). This canvas PR is forward-compatible — if it lands first, behavior is unchanged (fallback path). Refs: internal#212, feedback_surface_actionable_failure_reason_to_user Depends-on: #1549

core-devops added 1 commit 2026-05-19 00:39:37 +00:00

fix(canvas/chat): surface actionable error reason in chat banner + link to Activity tab (internal#212) ... 44affbde24

The chat error banner used to render the hardcoded
"Agent error (Exception) — see workspace logs for details." string
regardless of what the workspace runtime actually reported, and the
"workspace logs" reference pointed at a tab that does not exist (there
is no separate Logs tab in the side panel — the Activity tab is the
workspace-logs surface). Per CTO feedback on internal#211 / #212:
"the user can only act if they can see why."

useChatSocket now forwards the new ACTIVITY_LOGGED.error_detail field
(introduced server-side in the matching ws-server PR) into
onSendError. When present, the canvas shows the secret-safe reason
verbatim (provider HTTP status + error code + human-readable
message); when absent — older ws-server build — it gracefully
degrades to the legacy boilerplate so we never silently swallow a
failure.

A new ChatErrorBanner component renders the banner with a working
"View activity log" button that fires setPanelTab("activity"),
turning the dangling "see workspace logs" pointer into a real
affordance. The existing offline-Restart button is preserved.

Tests pin: hook forwards detail when present, falls back when absent,
ignores cross-workspace error events; banner renders the actionable
text, falls back to legacy message when that is all we have, button
navigates to Activity tab, Restart preserved when offline, null
message renders nothing.

Refs: internal#212, feedback_surface_actionable_failure_reason_to_user

core-fe approved these changes 2026-05-19 01:53:34 +00:00

core-fe left a comment

Member

Copy Link

Copy Source

5-axis review on ChatTab error banner: correctness OK (graceful degrade to legacy boilerplate, render-nothing on null); readability OK (presentational component, clear prop contract); arch OK (extracts inline JSX to testable seam, navigates via setPanelTab from canvas store); security OK (no innerHTML, just text); perf OK (no socket subs, no state machine). Tests cover all four banner states including 'View activity log' click. APPROVED.

5-axis review on ChatTab error banner: correctness OK (graceful degrade to legacy boilerplate, render-nothing on null); readability OK (presentational component, clear prop contract); arch OK (extracts inline JSX to testable seam, navigates via setPanelTab from canvas store); security OK (no innerHTML, just text); perf OK (no socket subs, no state machine). Tests cover all four banner states including 'View activity log' click. APPROVED.

core-uiux approved these changes 2026-05-19 01:53:35 +00:00

core-uiux left a comment

Member

Copy Link

Copy Source

UX review: actionable affordance (View activity log → Activity tab) replaces the dangling 'see workspace logs' pointer-to-nowhere. Restart button preserved for offline path. internal#212 surface complete. APPROVED.

UX review: actionable affordance (View activity log → Activity tab) replaces the dangling 'see workspace logs' pointer-to-nowhere. Restart button preserved for offline path. internal#212 surface complete. APPROVED.

hongming merged commit acc149e18e into main 2026-05-19 01:56:13 +00:00

hongming referenced this issue from a commit 2026-05-19 01:56:18 +00:00

Merge pull request 'fix(canvas/chat): surface actionable error reason in chat banner + link to Activity tab (internal#212)' (#1550) from fix/canvas-surface-error-detail into main

Sign in to join this conversation.

Reviewers

No Reviewers

core-fe

core-uiux

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1550