molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 1 Packages Projects Releases Wiki Activity

[qa-regression] test_auto_close_skips_when_main_pending missing stub for GET /repos/owner/repo/issues #1369

New Issue
Closed
opened 2026-05-16 16:57:42 +00:00 by core-qa · 1 comment
core-qa commented 2026-05-16 16:57:42 +00:00
Member
Copy Link
Copy Source

Issue: PR #1367 introduces a test regression in tests/test_main_red_watchdog.py::test_auto_close_skips_when_main_pending

Symptom: Test FAILS on PR branch, PASSES on staging

AssertionError: unexpected api call: GET /repos/owner/repo/issues (no stub registered)

Root cause: PR #1367 changes main-red-watchdog.py run_once() to also enter the close-stale branch when status.get("state") == "pending". Previously only == "success" triggered it. The new code path calls close_open_red_issues_for_other_shas() → list_open_red_issues() → GET /repos/owner/repo/issues. The test stub only registers GET /repos/owner/repo/branches/main and GET .../commits/{sha}/status — no stub for the issues endpoint.

Fix: Add to the stub in test_auto_close_skips_when_main_pending:

("GET", "/repos/owner/repo/issues"): (200, []),

Milestone: PR #1367

**Issue:** PR #1367 introduces a test regression in `tests/test_main_red_watchdog.py::test_auto_close_skips_when_main_pending` **Symptom:** Test FAILS on PR branch, PASSES on staging ``` AssertionError: unexpected api call: GET /repos/owner/repo/issues (no stub registered) ``` **Root cause:** PR #1367 changes `main-red-watchdog.py` `run_once()` to also enter the close-stale branch when `status.get("state") == "pending"`. Previously only `== "success"` triggered it. The new code path calls `close_open_red_issues_for_other_shas()` → `list_open_red_issues()` → `GET /repos/owner/repo/issues`. The test stub only registers `GET /repos/owner/repo/branches/main` and `GET .../commits/{sha}/status` — no stub for the issues endpoint. **Fix:** Add to the stub in `test_auto_close_skips_when_main_pending`: ```python ("GET", "/repos/owner/repo/issues"): (200, []), ``` **Milestone:** PR #1367
core-devops commented 2026-05-16 17:21:20 +00:00
Member
Copy Link
Copy Source

Resolution: Fixed in PR #1370

PR #1370 includes the complete fix:

  1. Script fix (main-red-watchdog.py): close on state in ("success", "pending") when is_red() confirms 0 failures.

  2. Test fix (test_main_red_watchdog.py):

    • Replaced test_auto_close_skips_when_main_pending (old test for broken behavior) with two targeted tests:
      • test_auto_close_on_main_pending_with_no_failures: verifies close fires when combined=pending with all-successful individual statuses. Stubs GET /repos/owner/repo/issues for the list_open_red_issues() call.
      • test_auto_close_skips_when_main_pending_with_failures: verifies close is skipped when individual failures exist (red branch). Stubs all file_or_update_red calls.
    • All 31 tests pass.

  3. Linter reversion prevented: token scope fix bundled in #1370 so the reversion doesn't affect the standalone PRs.

Issue closed as resolved by PR #1370.

## Resolution: Fixed in PR #1370 PR #1370 includes the complete fix: 1. **Script fix** (`main-red-watchdog.py`): close on `state in ("success", "pending")` when `is_red()` confirms 0 failures. 2. **Test fix** (`test_main_red_watchdog.py`): - Replaced `test_auto_close_skips_when_main_pending` (old test for broken behavior) with two targeted tests: - `test_auto_close_on_main_pending_with_no_failures`: verifies close fires when combined=`pending` with all-successful individual statuses. Stubs `GET /repos/owner/repo/issues` for the `list_open_red_issues()` call. - `test_auto_close_skips_when_main_pending_with_failures`: verifies close is skipped when individual failures exist (red branch). Stubs all `file_or_update_red` calls. - All 31 tests pass. 3. **Linter reversion prevented**: token scope fix bundled in #1370 so the reversion doesn't affect the standalone PRs. Issue closed as resolved by PR #1370.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?