fix(workspace_provision): preserve MODEL secret over MODEL_PROVIDER slug on restart #136

Merged

claude-ceo-assistant merged 1 commits from fix/preserve-model-secret-on-restart into main 2026-05-08 21:31:52 +00:00

Conversation 0 Commits 1 Files Changed 2 +89 -8

claude-ceo-assistant commented 2026-05-08 21:31:42 +00:00

Owner

Copy Link

Phase 4 follow-up to template-claude-code PR #9 (2026-05-08 dev-tree wedge).

Problem

applyRuntimeModelEnv unconditionally overwrote envVars["MODEL"] with the MODEL_PROVIDER slug whenever payload.Model was empty (the restart path). This silently wiped the operator's explicit per-persona MODEL secret on every restart.

Symptom: dev-tree workspaces booted correctly on first /org/import (the envVars map was populated direct from the persona env file with both MODEL=MiniMax-M2.7-highspeed and MODEL_PROVIDER=minimax), then on the next Restart the MODEL secret got clobbered to literal "minimax" — a provider slug, not a valid model id — and the workspace template's adapter failed to match any registry prefix, fell through to providers[0] (anthropic-oauth), and wedged at SDK initialize.

Fix

Resolution order in applyRuntimeModelEnv is now:

1. payload.Model — caller passed the canvas-picked model id verbatim.
2. envVars["MODEL"] — workspace_secret persisted from persona env (/org/import).
3. envVars["MODEL_PROVIDER"] — legacy canvas Save+Restart shape.

Tests

• New TestApplyRuntimeModelEnv_PersonaEnvMODELSecretPreserved — four cases locking in the precedence.
• Existing TestApplyRuntimeModelEnv_SetsUniversalMODELForAllRuntimes continues to pass.

Phase 4 follow-up to [template-claude-code PR #9](https://git.moleculesai.app/molecule-ai/molecule-ai-workspace-template-claude-code/pulls/9) (2026-05-08 dev-tree wedge). ## Problem `applyRuntimeModelEnv` unconditionally overwrote `envVars["MODEL"]` with the `MODEL_PROVIDER` slug whenever `payload.Model` was empty (the restart path). This silently wiped the operator's explicit per-persona `MODEL` secret on every restart. Symptom: dev-tree workspaces booted correctly on first `/org/import` (the `envVars` map was populated direct from the persona env file with both `MODEL=MiniMax-M2.7-highspeed` and `MODEL_PROVIDER=minimax`), then on the next `Restart` the `MODEL` secret got clobbered to literal `"minimax"` — a provider slug, not a valid model id — and the workspace template's adapter failed to match any registry prefix, fell through to `providers[0]` (`anthropic-oauth`), and wedged at SDK initialize. ## Fix Resolution order in `applyRuntimeModelEnv` is now: 1. `payload.Model` — caller passed the canvas-picked model id verbatim. 2. `envVars["MODEL"]` — workspace_secret persisted from persona env (`/org/import`). 3. `envVars["MODEL_PROVIDER"]` — legacy canvas `Save+Restart` shape. ## Tests * New `TestApplyRuntimeModelEnv_PersonaEnvMODELSecretPreserved` — four cases locking in the precedence. * Existing `TestApplyRuntimeModelEnv_SetsUniversalMODELForAllRuntimes` continues to pass.

claude-ceo-assistant added 1 commit 2026-05-08 21:31:43 +00:00

fix(workspace_provision): preserve MODEL secret over MODEL_PROVIDER slug on restart ... 15c5f32491

Phase 4 follow-up to template-claude-code PR #9 (2026-05-08 dev-tree wedge).

Pre-fix: applyRuntimeModelEnv unconditionally overwrote envVars["MODEL"]
with the MODEL_PROVIDER slug whenever payload.Model was empty (the restart
path). This silently wiped the operator'\''s explicit per-persona MODEL
secret on every restart.

Symptom: dev-tree workspaces booted correctly on first /org/import (the
envVars map was populated direct from the persona env file with both
MODEL=MiniMax-M2.7-highspeed and MODEL_PROVIDER=minimax), then on the
next Restart the MODEL secret got clobbered to literal "minimax" — a
provider slug, not a valid model id — and the workspace template'\''s
adapter failed to match any registry prefix, fell through to providers[0]
(anthropic-oauth), and wedged at SDK initialize.

Fix: resolution order in applyRuntimeModelEnv is now:
  1. payload.Model (caller passed the canvas-picked model id verbatim)
  2. envVars["MODEL"] (workspace_secret persisted from persona env)
  3. envVars["MODEL_PROVIDER"] (legacy canvas Save+Restart shape)

Tests
-----
TestApplyRuntimeModelEnv_PersonaEnvMODELSecretPreserved — locks in
the new resolution order with four cases:
  - MODEL secret wins over MODEL_PROVIDER slug (persona-env shape)
  - MODEL secret wins even when same as MODEL_PROVIDER
  - MODEL absent → fall back to MODEL_PROVIDER (legacy shape)
  - Both absent → no MODEL set (no-op)

Existing TestApplyRuntimeModelEnv_SetsUniversalMODELForAllRuntimes
continues to pass — fix is strictly additive on the precedence chain.

claude-ceo-assistant merged commit 6f861926bd into main 2026-05-08 21:31:52 +00:00

claude-ceo-assistant referenced this issue from a commit 2026-05-08 21:31:54 +00:00

Merge pull request 'fix(workspace_provision): preserve MODEL secret over MODEL_PROVIDER slug on restart' (#136) from fix/preserve-model-secret-on-restart into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

No Label

tier:high

tier:low

tier:medium

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#136

No description provided.