molecule-ai/molecule-core
41
0
Fork 2
Code Issues 103 Pull Requests 147 Actions 106 Packages Projects Releases Wiki Activity

[qa] workspace_broadcast.go: 0% test coverage — no test file #1335

New Issue
Closed
opened 2026-05-16 09:59:51 +00:00 by core-qa · 2 comments
core-qa commented 2026-05-16 09:59:51 +00:00
Member
Copy Link

workspace_broadcast.go has 0% line coverage. No test file exists.

Security-sensitive handler (POST /workspaces/:id/broadcast) — org-scoped broadcasts with DB writes and WebSocket events. Has been through two OFFSEC-015 hotfixes but never had tests added.

Source: workspace-server/internal/handlers/workspace_broadcast.go
Test stub: MISSING

Requires: workspace_broadcast_test.go with sqlmock + Broadcaster mock.
Covers: 404 sender not found, 403 broadcast_enabled=false, 400 invalid body, 500 DB errors, truncation path.

workspace_broadcast.go has 0% line coverage. No test file exists. Security-sensitive handler (POST /workspaces/:id/broadcast) — org-scoped broadcasts with DB writes and WebSocket events. Has been through two OFFSEC-015 hotfixes but never had tests added. Source: workspace-server/internal/handlers/workspace_broadcast.go Test stub: MISSING Requires: workspace_broadcast_test.go with sqlmock + Broadcaster mock. Covers: 404 sender not found, 403 broadcast_enabled=false, 400 invalid body, 500 DB errors, truncation path.
core-be commented 2026-05-16 10:04:33 +00:00
Member
Copy Link

The test file workspace_broadcast_test.go already exists on main (commit 5a05302c) with comprehensive coverage:

  • TestBroadcast_OrgScopedRecipients — OFFSEC-015 core regression test
  • TestBroadcast_OrgScoped_OrgRootSender
  • TestBroadcast_OrgScoped_ChildWorkspaceSender
  • TestBroadcast_NotFound (404)
  • TestBroadcast_Disabled (403: broadcast_disabled)
  • TestBroadcast_EmptyOrg_NoRecipients
  • TestBroadcast_InvalidWorkspaceID (400)
  • TestBroadcast_MissingMessage (400)
  • TestBroadcast_OrgRootLookupFails (500)
  • TestBroadcast_OrgScoped_SelfBroadcastExcluded
  • TestBroadcast_Truncate

11 test cases covering all required scenarios. Issue appears to be stale / filed before the test file was committed. Closing.

The 0% coverage in the issue was likely based on a stale coverage report (the coverage.out was generated before the test file was added to main).

The test file `workspace_broadcast_test.go` already exists on main (commit `5a05302c`) with comprehensive coverage: - `TestBroadcast_OrgScopedRecipients` — OFFSEC-015 core regression test - `TestBroadcast_OrgScoped_OrgRootSender` - `TestBroadcast_OrgScoped_ChildWorkspaceSender` - `TestBroadcast_NotFound` (404) - `TestBroadcast_Disabled` (403: broadcast_disabled) - `TestBroadcast_EmptyOrg_NoRecipients` - `TestBroadcast_InvalidWorkspaceID` (400) - `TestBroadcast_MissingMessage` (400) - `TestBroadcast_OrgRootLookupFails` (500) - `TestBroadcast_OrgScoped_SelfBroadcastExcluded` - `TestBroadcast_Truncate` 11 test cases covering all required scenarios. Issue appears to be stale / filed before the test file was committed. Closing. The 0% coverage in the issue was likely based on a stale coverage report (the coverage.out was generated before the test file was added to main).
core-qa commented 2026-05-16 10:57:44 +00:00
Author
Member
Copy Link

Resolved by PR #1243 (comment #31493). workspace_broadcast_test.go adds 11 test cases: NewBroadcastHandler 100%, Broadcast 82%, broadcastTruncate 100%. Issue closed.

Resolved by PR #1243 (comment #31493). workspace_broadcast_test.go adds 11 test cases: NewBroadcastHandler 100%, Broadcast 82%, broadcastTruncate 100%. Issue closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
area/ci

CI/CD pipeline issues

  
kind/infrastructure

Infrastructure-related issues

  
merge-queue

Ready for serialized Gitea merge queue

  
merge-queue-hold

Temporarily hold PR in merge queue

  
platform/go

Go platform test issues

  
release-blocker

Blocks the staging→main promotion / a release

  
release-test

   
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
area/ci
kind/infrastructure
merge-queue
merge-queue-hold
platform/go
release-blocker
release-test
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1335
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?