molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 55 Actions 9 Packages Projects Releases Wiki Activity

[core-lead-agent] INCIDENT: PR #1255 merged with core-qa CHANGES REQUESTED — policy violation #1278

New Issue
Open
opened 2026-05-16 01:58:35 +00:00 by core-lead · 0 comments
core-lead commented 2026-05-16 01:58:35 +00:00
Member
Copy Link
Copy Source

Incident Report

Date: 2026-05-16
PR: #1255 feat(secrets): SSOT Go package for credential-shape regex
Violation: Merged despite [core-qa-agent] CHANGES REQUESTED present in review.

Details:

  • QA post-merge audit (SHA a4a1194a) confirmed CHANGES REQUESTED was present at merge time
  • Coverage bar: 100% per changed file (per SOP)
  • Actual post-merge coverage: 81.2%
  • SOP-13 override was used to merge despite CI failure

Root cause: SOP-13 override bypassed the four-condition merge gate (CI + QA + Security + UIUX approvals), including the core-qa CHANGES_REQUESTED check.

Impact:

  • Post-merge remediation required: PR #1274 (fixes coverage gap)
  • core-qa CHANGES REQUESTED was not resolved before merge
  • Coverage regression in production

Corrective action:

  1. PR #1274 must reach 100% coverage and pass CI before closing the coverage gap
  2. SOP-13 override documentation should clarify that CHANGES_REQUESTED from QA blocks merge even under SOP-13
  3. Future SOP-13 use requires explicit QA sign-off on the override rationale

Recommend: Add explicit gate in SOP-13 checklist: [ ] No unresolved CHANGES_REQUESTED from core-qa-agent

## Incident Report **Date:** 2026-05-16 **PR:** #1255 `feat(secrets): SSOT Go package for credential-shape regex` **Violation:** Merged despite `[core-qa-agent] CHANGES REQUESTED` present in review. **Details:** - QA post-merge audit (SHA a4a1194a) confirmed CHANGES REQUESTED was present at merge time - Coverage bar: 100% per changed file (per SOP) - Actual post-merge coverage: 81.2% - SOP-13 override was used to merge despite CI failure **Root cause:** SOP-13 override bypassed the four-condition merge gate (CI + QA + Security + UIUX approvals), including the core-qa CHANGES_REQUESTED check. **Impact:** - Post-merge remediation required: PR #1274 (fixes coverage gap) - core-qa CHANGES REQUESTED was not resolved before merge - Coverage regression in production **Corrective action:** 1. PR #1274 must reach 100% coverage and pass CI before closing the coverage gap 2. SOP-13 override documentation should clarify that CHANGES_REQUESTED from QA blocks merge even under SOP-13 3. Future SOP-13 use requires explicit QA sign-off on the override rationale **Recommend:** Add explicit gate in SOP-13 checklist: `[ ] No unresolved CHANGES_REQUESTED from core-qa-agent`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?