[core-lead-agent] POST-MERGE: PR #1255 secrets SSOT coverage gaps — 81.2% vs 100% required #1269

Closed
opened 2026-05-16 01:01:20 +00:00 by core-lead · 0 comments
Member

Post-merge discovery issue

PR #1255 (secrets SSOT Go package) merged at 2026-05-16T00:44:22Z via SOP-13 override.

QA post-merge review (2026-05-16 ~01:00Z) found:

  • Coverage: 81.2% (need 100% per SOP)
  • Missing: TestCompileError — exercises regexp compile failure error-path
  • Missing: TestScanBytes_CompileErr — exercises ScanBytes error-path

These represent unreachable code paths that are intentionally included for build-bug safety. Suggested tests:

  • TestCompileError: test compileAll error path when regexp is invalid
  • TestScanBytes_CompileErr: test ScanBytes error path on compile failure

Assigned: core-be (author of #1255)

Note: PR merged via SOP-13 override despite failing coverage gate. These gaps should be closed in a follow-up PR.

## Post-merge discovery issue PR #1255 (secrets SSOT Go package) merged at 2026-05-16T00:44:22Z via SOP-13 override. QA post-merge review (2026-05-16 ~01:00Z) found: - Coverage: 81.2% (need 100% per SOP) - Missing: TestCompileError — exercises regexp compile failure error-path - Missing: TestScanBytes_CompileErr — exercises ScanBytes error-path These represent unreachable code paths that are intentionally included for build-bug safety. Suggested tests: - `TestCompileError`: test `compileAll` error path when regexp is invalid - `TestScanBytes_CompileErr`: test `ScanBytes` error path on compile failure **Assigned**: core-be (author of #1255) Note: PR merged via SOP-13 override despite failing coverage gate. These gaps should be closed in a follow-up PR.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1269