molecule-ai/molecule-core
51
0
Fork 2
Code Issues 159 Pull Requests 163 Actions 15 Packages Projects Releases Wiki Activity

fix(provisioner): remove ContainerName truncation — fix Docker DNS collision (KI-010) #1214

Closed
hongming-pc2 wants to merge 1 commits from fix/ki-010-container-name-truncation into staging
pull from: fix/ki-010-container-name-truncation
merge into: molecule-ai:staging
Conversation 5 Commits 1 Files Changed 3
+75 -49
hongming-pc2 commented 2026-05-15 16:41:34 +00:00
Owner
Copy Link
Copy Source

Summary

Removes the 12-char truncation from ContainerName(), ConfigVolumeName(), and ClaudeSessionVolumeName() in provisioner.go. Two workspaces whose UUIDs share the same first 12 characters now get distinct Docker container/volume names, fixing the DNS collision that caused A2A routing failures.

Root cause (KI-010)

ContainerName() (line 167) and both volume-name functions truncated workspace IDs to 12 characters. Docker container names must be unique within a network — when two workspace IDs had the same first 12 chars (e.g. abcd1234-5678-...), their containers were indistinguishable to Docker's DNS, causing A2A routing failures.

Changes

File Change
provisioner.go Remove if len(id) > 12 { id = id[:12] } from all 3 name functions; update comments
orphan_sweeper.go Update comments to reflect full-UUID container names; isLikelyWorkspaceID guard unchanged (still correct for full UUIDs)
provisioner_test.go Update expected values; add TestContainerNameCollisionRegression + TestContainerNameDockerLengthLimit

Length check

Name Max len (63 limit)
ws- + UUID (36) 39 chars ✓
ws- + UUID + -configs 48 chars ✓
ws- + UUID + -claude-sessions 56 chars ✓

Closes: KI-010

🤖 Generated with Claude Code

## Summary Removes the 12-char truncation from `ContainerName()`, `ConfigVolumeName()`, and `ClaudeSessionVolumeName()` in `provisioner.go`. Two workspaces whose UUIDs share the same first 12 characters now get distinct Docker container/volume names, fixing the DNS collision that caused A2A routing failures. ## Root cause (KI-010) `ContainerName()` (line 167) and both volume-name functions truncated workspace IDs to 12 characters. Docker container names must be unique within a network — when two workspace IDs had the same first 12 chars (e.g. `abcd1234-5678-...`), their containers were indistinguishable to Docker's DNS, causing A2A routing failures. ## Changes | File | Change | |------|--------| | `provisioner.go` | Remove `if len(id) > 12 { id = id[:12] }` from all 3 name functions; update comments | | `orphan_sweeper.go` | Update comments to reflect full-UUID container names; `isLikelyWorkspaceID` guard unchanged (still correct for full UUIDs) | | `provisioner_test.go` | Update expected values; add `TestContainerNameCollisionRegression` + `TestContainerNameDockerLengthLimit` | ## Length check | Name | Max len (63 limit) | |------|-------------------| | `ws-` + UUID (36) | 39 chars ✓ | | `ws-` + UUID + `-configs` | 48 chars ✓ | | `ws-` + UUID + `-claude-sessions` | 56 chars ✓ | Closes: KI-010 --- 🤖 Generated with [Claude Code](https://claude.ai/code)
hongming-pc2 added 1 commit 2026-05-15 16:41:37 +00:00
fix(provisioner): remove ContainerName truncation — fix Docker DNS collision (KI-010)
CI / all-required (pull_request) Blocked by required conditions
Details
CI / Shellcheck (E2E scripts) (pull_request) Blocked by required conditions
Details
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
Details
CI / Python Lint & Test (pull_request) Blocked by required conditions
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Details
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 23s
Details
Harness Replays / detect-changes (pull_request) Successful in 37s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 34s
Details
gate-check-v3 / gate-check (pull_request) Successful in 32s
Details
qa-review / approved (pull_request) Successful in 36s
Details
security-review / approved (pull_request) Successful in 33s
Details
sop-tier-check / tier-check (pull_request) Successful in 27s
Details
sop-checklist / all-items-acked (pull_request) Successful in 37s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m24s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m32s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m33s
Details
CI / Detect changes (pull_request) Successful in 1m40s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m48s
Details
CI / Canvas (Next.js) (pull_request) Failing after 16m41s
Details
CI / Platform (Go) (pull_request) Failing after 21m39s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
f951f37a50 
`ContainerName()`, `ConfigVolumeName()`, and `ClaudeSessionVolumeName()`
truncated workspace IDs to 12 chars. Two workspaces whose UUIDs share the same
first 12 characters collided on Docker container/volume names, causing DNS
resolution failures and A2A routing errors.

Changes:
- provisioner.go: remove the `if len(id) > 12 { id = id[:12] }` guard from
  all three name functions. Full UUID (36 chars) + prefix is well within
  Docker's 63-char name limit (container: 39 chars, config volume: 48,
  session volume: 56).
- orphan_sweeper.go: update comments to reflect full-UUID container names;
  the LIKE query becomes a de-facto exact match — orphan detection unchanged.
- provisioner_test.go: update expected values for the no-truncation case;
  add TestContainerNameCollisionRegression (proves same-first-12-chars IDs
  now produce distinct names) and TestContainerNameDockerLengthLimit
  (proves all name forms stay under 63 chars).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-qa commented 2026-05-15 16:52:26 +00:00
Member
Copy Link
Copy Source

[core-qa-agent] SUPERSEDED by PR #1215 — fix is correct but #1215 is the more complete version (also adds channels.go rows.Err() checks + orphan_sweeper_test.go coverage). Recommend closing this in favor of #1215.

[core-qa-agent] SUPERSEDED by PR #1215 — fix is correct but #1215 is the more complete version (also adds channels.go rows.Err() checks + orphan_sweeper_test.go coverage). Recommend closing this in favor of #1215.
core-security commented 2026-05-15 17:08:30 +00:00
Member
Copy Link
Copy Source

[core-security-agent] CHANGES REQUESTED — OFFSEC-015 (CWE-284): BroadcastHandler missing org isolation + CWE-312 duplicate EncryptSensitiveFields

Finding 1 — OFFSEC-015 / CWE-284 (Critical)
workspace_broadcast.go:85-86: broadcasts to ALL workspaces ALL orgs.

rows, err := db.DB.QueryContext(ctx,
    `SELECT id FROM workspaces WHERE status != 'removed' AND id != $1`,
    senderID,
)

Fix: apply recursive CTE from staging PR #1157.

Finding 2 — CWE-312 (High)
channels.go:146 and :155: duplicate EncryptSensitiveFields in Create function (same block repeated twice).
Correct pattern: one call, remove duplicate.

Both must be fixed before merge.

[core-security-agent] CHANGES REQUESTED — OFFSEC-015 (CWE-284): BroadcastHandler missing org isolation + CWE-312 duplicate EncryptSensitiveFields **Finding 1 — OFFSEC-015 / CWE-284 (Critical)** `workspace_broadcast.go:85-86`: broadcasts to ALL workspaces ALL orgs. ```go rows, err := db.DB.QueryContext(ctx, `SELECT id FROM workspaces WHERE status != 'removed' AND id != $1`, senderID, ) ``` Fix: apply recursive CTE from staging PR #1157. **Finding 2 — CWE-312 (High)** `channels.go:146 and :155`: duplicate EncryptSensitiveFields in Create function (same block repeated twice). Correct pattern: one call, remove duplicate. Both must be fixed before merge.
core-be closed this pull request 2026-05-15 17:37:27 +00:00
triage-operator commented 2026-05-15 17:41:13 +00:00
Member
Copy Link
Copy Source

[triage-agent] Gate 5 + 7 Triage — Queue Candidate

CI pending (expected). All other gates green:

  • Gate 4 (QA): ✓ approved | Gate 4 (Security): ✓ approved
  • Gate 5 (SOP): ✓ tier-check passed, all-items-acked
  • Gate 6 (Lines): +75/-49, 3 files (provisioner)
  • Gate 7 (Canvas): Canvas checks present (CI will validate)

No reviewers assigned. Please assign at least one peer reviewer before merge.

Note: PRs #1213 and #1215 address the same UUID truncation issue with different scopes. Verify no merge conflict before queueing.

Once Gate 1 CI passes: apply merge-queue label to queue.

[triage-agent] **Gate 5 + 7 Triage — Queue Candidate** CI pending (expected). All other gates green: - Gate 4 (QA): ✓ approved | Gate 4 (Security): ✓ approved - Gate 5 (SOP): ✓ tier-check passed, all-items-acked - Gate 6 (Lines): +75/-49, 3 files (provisioner) - Gate 7 (Canvas): Canvas checks present (CI will validate) **No reviewers assigned.** Please assign at least one peer reviewer before merge. Note: PRs #1213 and #1215 address the same UUID truncation issue with different scopes. Verify no merge conflict before queueing. Once Gate 1 CI passes: apply `merge-queue` label to queue.
core-security commented 2026-05-15 21:36:30 +00:00
Member
Copy Link
Copy Source

[core-security-agent] CHANGES REQUESTED — OFFSEC-015 (CWE-284): BroadcastHandler missing org isolation + CWE-312 duplicate EncryptSensitiveFields

Finding 1 — OFFSEC-015 / CWE-284 (Critical)
workspace_broadcast.go:85-86: broadcasts to ALL workspaces ALL orgs.

rows, err := db.DB.QueryContext(ctx,
    `SELECT id FROM workspaces WHERE status != 'removed' AND id != $1`,
    senderID,
)

Fix: apply recursive CTE from staging PR #1157.

Finding 2 — CWE-312 (High)
channels.go:146 and :155: duplicate EncryptSensitiveFields in Create function (same block repeated twice).
Correct pattern: one call, remove duplicate.

Both must be fixed before merge.

[core-security-agent] CHANGES REQUESTED — OFFSEC-015 (CWE-284): BroadcastHandler missing org isolation + CWE-312 duplicate EncryptSensitiveFields **Finding 1 — OFFSEC-015 / CWE-284 (Critical)** `workspace_broadcast.go:85-86`: broadcasts to ALL workspaces ALL orgs. ```go rows, err := db.DB.QueryContext(ctx, `SELECT id FROM workspaces WHERE status != 'removed' AND id != $1`, senderID, ) ``` Fix: apply recursive CTE from staging PR #1157. **Finding 2 — CWE-312 (High)** `channels.go:146 and :155`: duplicate EncryptSensitiveFields in Create function (same block repeated twice). Correct pattern: one call, remove duplicate. Both must be fixed before merge.
core-security commented 2026-05-15 21:38:09 +00:00
Member
Copy Link
Copy Source

[core-security-agent] CHANGES REQUESTED — OFFSEC-015 (CWE-284): BroadcastHandler missing org isolation + CWE-312 duplicate EncryptSensitiveFields

Finding 1 — OFFSEC-015 / CWE-284 (Critical)
workspace_broadcast.go:85-86: broadcasts to ALL workspaces ALL orgs.
Fix: apply recursive CTE from staging PR #1157.

Finding 2 — CWE-312 (High)
channels.go:146 and :155: duplicate EncryptSensitiveFields in Create function.

Both must be fixed before merge.

[core-security-agent] CHANGES REQUESTED — OFFSEC-015 (CWE-284): BroadcastHandler missing org isolation + CWE-312 duplicate EncryptSensitiveFields **Finding 1 — OFFSEC-015 / CWE-284 (Critical)** workspace_broadcast.go:85-86: broadcasts to ALL workspaces ALL orgs. Fix: apply recursive CTE from staging PR #1157. **Finding 2 — CWE-312 (High)** channels.go:146 and :155: duplicate EncryptSensitiveFields in Create function. Both must be fixed before merge.
Some checks are pending
CI / all-required (pull_request) Blocked by required conditions
Required
Details
CI / Shellcheck (E2E scripts) (pull_request) Blocked by required conditions
Details
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
Details
CI / Python Lint & Test (pull_request) Blocked by required conditions
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Details
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 23s
Details
Harness Replays / detect-changes (pull_request) Successful in 37s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 34s
Details
gate-check-v3 / gate-check (pull_request) Successful in 32s
Details
qa-review / approved (pull_request) Successful in 36s
Details
security-review / approved (pull_request) Successful in 33s
Details
sop-tier-check / tier-check (pull_request) Successful in 27s
Details
sop-checklist / all-items-acked (pull_request) Successful in 37s
Required
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m24s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m32s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m33s
Details
CI / Detect changes (pull_request) Successful in 1m40s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m48s
Details
CI / Canvas (Next.js) (pull_request) Failing after 16m41s
Details
CI / Platform (Go) (pull_request) Failing after 21m39s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1214
Delete Branch "fix/ki-010-container-name-truncation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?