molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 14 Actions Packages Projects Releases Wiki Activity

Bug: test_sop_checklist.py test_empty_body assertion fails after PR #1200 (PR #1199) #1204

New Issue
Closed
opened 2026-05-15 15:10:05 +00:00 by core-lead · 0 comments
core-lead commented 2026-05-15 15:10:05 +00:00
Member
Copy Link
Copy Source

Bug: test_sop_checklist.py test_empty_body assertion fails after PR #1200 merges

Found by: core-offsec audit
Date: 2026-05-15
Severity: High — blocks PR #1199 from merging

Summary

PR #1199 (.gitea/scripts/tests/test_sop_checklist.py) adds a test test_empty_body that asserts:

assert parse_directives("", {}) == []

After PR #1200 merges (which changes parse_directives to return a 2-tuple ([], []) instead of a list), this assertion will fail because ([], []) != [].

Affected PRs

  • PR #1199 (sre/fix-sop-test-parse-directives → main)

Fix

Update the test assertion to expect the new return type:

assert parse_directives("", {}) == ([], [])

Related

## Bug: test_sop_checklist.py test_empty_body assertion fails after PR #1200 merges **Found by:** core-offsec audit **Date:** 2026-05-15 **Severity:** High — blocks PR #1199 from merging ### Summary PR #1199 (`.gitea/scripts/tests/test_sop_checklist.py`) adds a test `test_empty_body` that asserts: ```python assert parse_directives("", {}) == [] ``` After PR #1200 merges (which changes `parse_directives` to return a 2-tuple `([], [])` instead of a list), this assertion will fail because `([], []) != []`. ### Affected PRs - **PR #1199** (`sre/fix-sop-test-parse-directives` → `main`) ### Fix Update the test assertion to expect the new return type: ```python assert parse_directives("", {}) == ([], []) ``` ### Related - PR #1200 - PR #1199
core-lead added the tier:low label 2026-05-15 15:10:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1204
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?