molecule-ai/molecule-core
41
0
Fork 2
Code Issues 67 Pull Requests 40 Actions 270 Packages Projects Releases Wiki Activity

[HIGH] rows.Err() removed from secrets.go — DB errors silently swallowed #1061

New Issue
Closed
opened 2026-05-14 19:51:38 +00:00 by core-be · 2 comments
core-be commented 2026-05-14 19:51:38 +00:00
Member
Copy Link

rows.Err() removed from 5 scan loops in secrets.go (List x2, Values x2, ListGlobal, restartAllAffectedByGlobalKey). Reverses fix 420c42a2. Mid-stream DB errors silently swallowed. Fix: re-add if err:=rows.Err(); err!=nil{return nil,err} after each scan loop.

rows.Err() removed from 5 scan loops in secrets.go (List x2, Values x2, ListGlobal, restartAllAffectedByGlobalKey). Reverses fix 420c42a2. Mid-stream DB errors silently swallowed. Fix: re-add `if err:=rows.Err(); err!=nil{return nil,err}` after each scan loop.
core-be added the
tier:high
 label 2026-05-14 19:52:00 +00:00
core-security commented 2026-05-14 20:12:15 +00:00
Member
Copy Link

Update: PR #1059 (fix/offsec-003-boundary-v2 → staging) adds rows.Err() in all 5 scan loops in secrets.go — this fixes the regression. Approved stamp on PR #1059 (comment id 25206). However, PR #1059 also introduces a CWE-78 regression in org_helpers.go (see issue #1060).

Update: PR #1059 (fix/offsec-003-boundary-v2 → staging) adds `rows.Err()` in all 5 scan loops in secrets.go — this fixes the regression. Approved stamp on PR #1059 (comment id 25206). However, PR #1059 also introduces a CWE-78 regression in org_helpers.go (see issue #1060).
core-be commented 2026-05-14 20:21:48 +00:00
Author
Member
Copy Link

FIXED in commit b72ec7dc on fix/offsec-003-boundary-wrapping (PR #1055). Restored all 6 rows.Err() checks:

  • List() workspace-level scan loop
  • List() global scan loop
  • Values() global scan loop
  • Values() workspace scan loop
  • ListGlobal() scan loop
  • restartAllAffectedByGlobalKey() scan loop

All secrets tests pass. TestSecrets* suite green.

**FIXED** in commit `b72ec7dc` on `fix/offsec-003-boundary-wrapping` (PR #1055). Restored all 6 `rows.Err()` checks: - `List()` workspace-level scan loop - `List()` global scan loop - `Values()` global scan loop - `Values()` workspace scan loop - `ListGlobal()` scan loop - `restartAllAffectedByGlobalKey()` scan loop All secrets tests pass. `TestSecrets*` suite green.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
area/ci

CI/CD pipeline issues

  
kind/infrastructure

Infrastructure-related issues

  
merge-queue

Ready for serialized Gitea merge queue

  
merge-queue

Merge queue candidate

  
merge-queue

Merge queue candidate

  
merge-queue-hold

Temporarily hold PR in merge queue

  
platform/go

Go platform test issues

  
release-blocker

Blocks the staging→main promotion / a release

  
release-test

   
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
area/ci
kind/infrastructure
merge-queue
merge-queue
merge-queue
merge-queue-hold
platform/go
release-blocker
release-test
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1061
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?