240 Commits

Author	SHA1	Message	Date
Molecule AI Core-BE	deeff950be	fix(inbox): drop self-delegation-echo rows from inbox poller ... Internal #469: when a workspace delegates to a target that never picks up the task, tool_delegate_task calls report_activity("a2a_receive", ...) which POSTs to the platform with source_id = the sender's workspace UUID (spoof- defense). The activity API exposes that row under type=a2a_receive, so the inbox poller re-fetches it and message_from_activity sets peer_id = the workspace's own UUID — the workspace sees its own delegation-failure echoed back as if a peer had delegated to it. Fix adds _is_self_echo_row(row, workspace_id) that returns True when source_id == workspace_id, mirroring the existing _is_self_notify_row pattern. The guard is wired into _poll_once after the self-notify check: self-echo rows are skipped from the queue, the cursor still advances, and the notification callback does not fire. The real delegate_result push path (delegate_result method) is unaffected. 8 new tests cover the predicate (same-workspace, different-workspace, None source, empty workspace_id, absent key) and the integrated poller behavior (skipped from queue, cursor advances, no notification). Live-repro confirmed on hongming.moleculesai.app prior to this fix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-16 12:38:55 +00:00
fullstack-engineer	0e13a80121	chore: promote staging→main (chat E2E + accumulated fixes) ... Promotes the following staging-only changes to main: - feat(e2e): stabilize Playwright chat tests for desktop + mobile (PR #1142) - feat(workspace): broadcast and talk-to-user platform abilities - feat(adapter-base): ProviderRegistry type + resolve_provider_routing - fix(staging): OFFSEC-010 CP config wiring + CWE-78 rows.Err fixes - fix(staging): restore goAsync tracking in dispatch calls - fix(ci): needs-based all-required sentinel - fix(canvas): load chat history in MobileChat (closes #1062) Merge-conflict resolutions: - ThemeToggle.tsx: take staging (INDEX_SIZE_ERR test fix) - MobileChat.tsx + test: take staging (shared hooks refactor) - workspace_broadcast.go: take main (OFFSEC-015 org isolation) - org_helpers.go + tests: combine both (CWE-78 guard + rows.Err) - secrets.go: take staging (descriptive rows.Err log messages) - workspace.go: combine (goAsync tracking + SaaS tier hard-gate) - cp_provisioner.go: combine (OFFSEC-010 comments + main formatting) - ci.yml: combine (mc#774 trackers + all-required needs cleanup) - test_a2a_offsec003_sanitization.py: delete (redundant per mc#62d38667)	2026-05-15 15:20:52 -07:00
hongming-codex-laptop	29b4bffb13	feat(workspace): add broadcast and talk-to-user platform abilities ... Two new workspace-level ability flags (broadcast_enabled, talk_to_user_enabled) with full backend enforcement, MCP tool, and canvas UI: - Migration: adds broadcast_enabled (default false) and talk_to_user_enabled (default true) columns to workspaces table - PATCH /workspaces/:id/abilities (AdminAuth) toggles either flag independently - POST /workspaces/:id/broadcast (WorkspaceAuth) fans out a broadcast_receive activity_log entry + WS BROADCAST_MESSAGE event to all non-removed peers; requires broadcast_enabled=true on the sender - AgentMessageWriter checks talk_to_user_enabled; returns ErrTalkToUserDisabled which surfaces as HTTP 403 on /notify and the send_message_to_user MCP tool - broadcast_message MCP tool added to registry + a2a_tools_messaging.py - Canvas ChatTab shows "Agent is not enabled to chat with you" banner with Enable button when talkToUserEnabled=false on the workspace node Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-15 12:03:08 -07:00
hongming-codex-laptop	026d1c5fae	feat(workspace): add broadcast and talk-to-user platform abilities ... Two new workspace-level ability flags (broadcast_enabled, talk_to_user_enabled) with full backend enforcement, MCP tool, and canvas UI: - Migration: adds broadcast_enabled (default false) and talk_to_user_enabled (default true) columns to workspaces table - PATCH /workspaces/:id/abilities (AdminAuth) toggles either flag independently - POST /workspaces/:id/broadcast (WorkspaceAuth) fans out a broadcast_receive activity_log entry + WS BROADCAST_MESSAGE event to all non-removed peers; requires broadcast_enabled=true on the sender - AgentMessageWriter checks talk_to_user_enabled; returns ErrTalkToUserDisabled which surfaces as HTTP 403 on /notify and the send_message_to_user MCP tool - broadcast_message MCP tool added to registry + a2a_tools_messaging.py - Canvas ChatTab shows "Agent is not enabled to chat with you" banner with Enable button when talkToUserEnabled=false on the workspace node Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-15 00:19:44 -07:00
core-devops	4bdb10b5e2	feat(adapter-base): add ProviderRegistry type + resolve_provider_routing utility ... Adds a shared resolver that maps `provider:model` strings to (api_key, base_url, model_id). Each adapter defines its own registry; the base only provides the type alias and the routing mechanism. URL override precedence: <PREFIX>_BASE_URL env > runtime_config["provider_url"] > registry default. Unknown prefixes fall back to OpenAI credentials. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-14 23:02:09 -07:00
Molecule AI Core-QA	25866ec200	fix(workspace/OFFSEC-003): correct boundary wrapping + add closer truncation ... Two bugs fixed in tool_delegate_task wrapping logic: 1. Wrapping used raw _A2A_BOUNDARY_START/_END markers, which appeared in the output alongside the escaped form of the peer content (e.g. "[A2A_RESULT_FROM_PEER]\n[/ A2A_RESULT...]"). Fixed: wrap with _A2A_BOUNDARY_START_ESCAPED/_END_ESCAPED so the output contains no raw closer that could confuse downstream parsers. 2. A malicious peer could inject a fake closer ([/A2A_RESULT_FROM_PEER]) to make legitimate content appear truncated. Fixed: truncate at the raw closer BEFORE sanitization (truncation loses the raw form, so escaping afterward cannot retroactively remove it). Also fixes 10 regressions in test_a2a_offsec003_sanitization.py: tests were written expecting ZWSP (U+200B) escaping but implementation uses "[/ " prefix. Updated test invariants to match actual behavior. Also fixed 5 tests using [A2A_ERROR] in summary fields (not a boundary marker — no escaping applied) and updated test assertions in test_a2a_tools_impl.py and test_delegation_sync_via_polling.py to expect escaped wrapper forms. Cherry-picked fix/test-stdio-function-name (e478b5b2) from main: renamed _warn_if_stdio_not_pipe → _assert_stdio_is_pipe_compatible and added deprecated alias, fixing dangling monkeypatch targets that caused 5 test failures (issue #957). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 21:01:34 +00:00
Molecule AI Core-DevOps	e51f7004b3	fix(workspace): rename _warn_if_stdio_not_pipe → _assert_stdio_is_pipe_compatible ... Rename the canonical function to `_assert_stdio_is_pipe_compatible` with a deprecated alias `_warn_if_stdio_not_pipe` for backward compat. Updates all 5 test import sites. Fixes dangling monkeypatch targets in test_a2a_mcp_server_http.py (which patches `_assert_stdio_is_pipe_compatible`; main's source defined the old name, causing patches to silently no-op). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 20:05:56 +00:00
Molecule AI Core-QA	d241dd7f9e	fix(workspace/OFFSEC-003): correct boundary wrapping + add closer truncation ... Two bugs fixed in tool_delegate_task wrapping logic: 1. Wrapping used raw _A2A_BOUNDARY_START/_END markers, which appeared alongside the escaped form of peer content. Fixed: wrap with _A2A_BOUNDARY_START_ESCAPED/_END_ESCAPED so output contains no raw closer that could confuse downstream parsers. 2. A malicious peer could inject a fake closer ([/A2A_RESULT_FROM_PEER]) to make legitimate content appear truncated. Fixed: truncate at the raw closer BEFORE sanitization (truncation loses the raw form). Updated test assertions across 3 test files to match new escaped wrapper form (previous tests expected raw markers in output). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 19:48:55 +00:00
Molecule AI Core-QA	62d3866764	fix(workspace/tests): remove redundant offsec003 file + fix mcp_server test ... - Remove test_a2a_offsec003_sanitization.py (403 lines): Added in PR #539 with WRONG assertions — expects ZWSP (U+200B) escaping but _sanitize_a2a._escape_boundary_markers() uses text.replace() which produces "[/ /A2A_RESULT_FROM_PEER]". The sibling file test_a2a_sanitization.py (which passes) covers the same surface correctly. Fixes 10 Python test failures. - Fix test_a2a_mcp_server_http.py (5 cli_main tests): Rename in PR #778 changed _assert_stdio_is_pipe_compatible() to _warn_if_stdio_not_pipe() but test mocks were never updated. All 5 tests now pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 06:34:10 +00:00
molecule-operator	6b0dd62a60	chore: promote main→staging v4 (OFFSEC-003 revert + delegation tests)	2026-05-14 05:18:58 +00:00
Molecule AI Core-QA	6a0383bbf8	fix(workspace): revert OFFSEC-003 test assertions — original expectations were correct ... PR #946 incorrectly changed test assertions to expect ZWSP/regex-based stripping behavior that the production code never had. The actual sanitizer uses simple string replacement (e.g. [/A2A_RESULT_FROM_PEER] → [/ /A2A_RESULT_FROM_PEER]) and does NOT strip content after closers. Reverts test file to the correct string-replacement expectations from commit 40ca44aa. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 05:03:36 +00:00
Molecule AI Core-DevOps	d3c671d77c	Merge remote-tracking branch 'origin/staging' into promote/main-to-staging ... # Conflicts: # .gitea/scripts/sop-checklist-gate.py	2026-05-14 04:00:16 +00:00
Molecule AI Core-QA	fa81626b71	fix(workspace): correct OFFSEC-003 test assertions to match ZWSP-escaping behavior ... Corrects 12 broken test assertions in test_a2a_sanitization.py that were introduced by the PR #916 merge. Assertions mischaracterized the sanitizer's ZWSP-escaping behavior, especially around the (?<=\\n) lookbehind in _strip_closed_blocks. Key corrections: - test_escape_close_marker: closer preceded by \\n IS stripped (matches the (?<=\\n) lookbehind); injected closer + all content after removed - test_escape_open_marker: opener at start-of-line IS ZWSP-escaped (ZWSP inserted between \\n and [) - test_escape_full_fake_boundary_pair: opener ZWSP-escaped, closer stripped - test_empty_string_returns_empty: None coerced by first if-check → "" - All TestInjectionPatternDefenseInDepth tests: use bracketed [SYSTEM] form matching _CONTROL_PATTERNS regex, not colon-prefixed form - test_check_task_status_*: JSON fields have no boundary markers (no wrapping) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:39:34 +00:00
Molecule AI Infra-Runtime-BE	8faae1c9d9	test(a2a_mcp_server): add 5 tool-branch coverage cases to HTTP transport tests ... Cover remaining elif branches in handle_tool_call: - send_message_to_user: mixed-type attachments are filtered (line 116) - wait_for_message: dispatched with timeout_secs argument - inbox_peek: dispatched with limit argument - inbox_pop: dispatched with activity_id argument - chat_history: dispatched with peer_id/limit/before_ts arguments Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 00:27:57 +00:00
Molecule AI Infra-Runtime-BE	ed47e89d13	test(builtin_tools): add 16-case coverage for _redact_secrets (C2, #834) ... Bring builtin_tools/security._redact_secrets from 58% to 100% coverage. Contextual keyword=value patterns, idempotency, boundary cases, mixed content. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 00:27:57 +00:00
Molecule AI Infra-Runtime-BE	07ea7bdd82	feat(workspace): add HTTP/SSE transport to a2a_mcp_server ... Port HTTP/SSE transport (from workspace-runtime PR #16) to the canonical monorepo source. Enables the Hermes MCP-native runtime to communicate with the A2A platform tools via HTTP/SSE instead of stdio. The SSE event_stream() is an async generator — Starlette's Response requires sync content and raises AttributeError for async generators. Switch the SSE handler to StreamingResponse which properly handles async generators via anyio.create_task_group (Starlette 1.0.0). Adds test_a2a_mcp_server_http.py: 24 tests covering _handle_http_mcp, Starlette app routes, SSE queue delivery, and cli_main argparse. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 00:27:56 +00:00
Molecule AI Release Manager	39a2dc9871	Merge main into staging (sync v4 — release manager) ... Brings 659 main commits into staging. Resolves all conflicts with staging's version (staging is current production state). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:35:50 +00:00
Molecule AI Infra-Runtime-BE	3e9a2665f3	test(executor): update error-handling tests for sanitize_agent_error ... The sanitize_agent_error(exc=e) fix produces the sanitized format "Agent error (RuntimeError) — see workspace logs for details." instead of the raw exception string. Update two assertions in test_agent_error_handling and test_terminal_error_routes_via_updater_failed to expect the secure format, and assert raw message is NOT present. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:50:59 +00:00
Molecule AI Infra-Runtime-BE	d0611d4eee	Merge origin/main into fix/stdio-fallback-all-environments ... Conflicts resolved: - workspace/a2a_client.py: accept HEAD (TTL cache check, full comment) - workspace/a2a_executor.py: accept HEAD (sanitize_agent_error(exc=e)) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:44:23 +00:00
hongming-kimi-laptop (Molecule AI agent)	e1aac92539	fix(mcp): universal stdio transport + runtime-adaptive notifications ... Root fix for molecule-ai-workspace-runtime#61: - Replace asyncio.connect_read_pipe/connect_write_pipe with direct sys.stdin.buffer/sys.stdout.buffer I/O. The asyncio pipe transport rejects regular files, PTYs, and sockets — breaking openclaw, CI tests, and tee-captured debugging. Direct buffer I/O works with ANY file descriptor. - Replace fatal _assert_stdio_is_pipe_compatible() with non-fatal _warn_if_stdio_not_pipe() — operators get diagnostic signal without the hard exit. Runtime detection for adaptive push notifications: - Detect MCP host from env vars: CLAUDE_CODE, OPENCLAW_SESSION_ID, CURSOR_MCP, HERMES_RUNTIME - Emit the correct JSON-RPC notification method per host: notifications/claude/channel, notifications/openclaw/channel, etc. - Unifies the molecule-mcp-claude-channel plugin behavior into the universal MCP server — one implementation for all runtimes. Tests: - Update TestStdioPipeAssertion for warning-based behavior - Patch runtime detection in channel-notification tests - 80 passed, 5 pre-existing failures (enrichment cache unrelated)	2026-05-12 19:55:45 -07:00
Molecule AI Infra-Runtime-BE	965710eb00	Merge PR #619: fix(platform): fail-fast checkShellDeps in localbuild + fix async test pollution	2026-05-12 02:47:16 +00:00
Molecule AI · core-devops	1301f50509	Merge pull request 'test(workspace): OFFSEC-003 sanitization backstop for A2A exit points' (#539) from test/offsec-003-sanitization-backstop into staging	2026-05-12 02:29:35 +00:00
Molecule AI Fullstack Engineer	e2cc86b26d	test(workspace): add push-mode queue envelope coverage for a2a_response.py (closes #308) ... Adds 5 test cases + 3 fixtures to test_a2a_response.py covering the push-mode queue handling added in PR #278 (a2a_proxy.go): Fixtures: - push_queued_full: {queued: True, method: tasks/send, message, queue_id} - push_queued_no_method: {queued: True, message} → defaults to message/send - push_queued_message_only: {queued: True, message} → still Queued Test cases (TestQueuedVariant_PushMode): - test_push_queued_full_returns_Queued - test_push_queued_no_method_defaults_to_message_send - test_push_queued_message_only_returns_Queued - test_push_queued_logs_info_with_queue_id - test_push_queued_delivery_mode_defaults_to_poll Also updates test_every_fixture_classifies_to_expected_variant to enumerate the 3 new fixtures so future additions must update the table. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 00:46:38 +00:00
Molecule AI Fullstack Engineer	9d8f773bec	fix(platform): fail-fast checkShellDeps in localbuild + fix async test pollution in test_a2a_tools_inbox_wrappers (closes #529, #307) ... platform/localbuild.go: - Add checkShellDeps field + checkShellDepsProd() pre-flight check. Replaces cryptic "exec: docker: executable file not found in $PATH" with an actionable error: names the missing binary and points at the fix (install both OR set MOLECULE_IMAGE_REGISTRY). - checkShellDeps is a seam on LocalBuildOptions so existing tests stub it. platform/localbuild_test.go: - makeTestOpts now stubs checkShellDeps → nil (no-op in test env). - Add TestEnsureLocalImage_MissingShellDeps: verify early-exit with actionable message. - Add TestCheckShellDepsProd_ErrorMessage_Actionable: error names missing binary and MOLECULE_IMAGE_REGISTRY fix path. workspace/test_a2a_tools_inbox_wrappers.py (#307): - Replace _run(coro) anti-pattern with proper async def + await. The old pattern bypassed pytest-asyncio lifecycle, creating a nested event loop that caused coroutine warnings in full-suite runs (14 tests passed in isolation, failed in suite). Fix: convert all 14 test methods to async def owned by pytest-asyncio. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 00:42:24 +00:00
Molecule AI Core-DevOps	7f90630f98	fix(tests): correct test_sanitize_agent_error_stderr_and_exc assertion ... The test expected the exception class to be hidden when stderr is provided, but the implementation always uses the exc type as the tag. Fix the assertion to match actual (correct) behavior: ValueError is in the tag, stderr is the body. Also add a check that we don't fall back to the generic "workspace logs" form. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 22:59:41 +00:00
Molecule AI Core-QA	34214ac4dc	test(workspace): OFFSEC-003 sanitization backstop — full coverage of A2A exit points ... Add regression tests for every public A2A tool exit point that returns peer-sourced content without sanitize_a2a_result wrapping. Covers: - tool_delegate_task: sync success path, queued-fallback path - _delegate_sync_via_polling: completed/failed delegation results - tool_check_task_status: filtered lookup, delegation list, not-found References: #491, #537 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 18:38:38 +00:00
Molecule AI Infra-Runtime-BE	389613bb95	fix(tests): correct assert in test_sanitize_agent_error_stderr_and_exc ... The exc class IS the tag when stderr is provided: "Agent error (ValueError): rate limit exceeded" Fixes the incorrect assertion added in PR #517. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 18:21:19 +00:00
Molecule AI Fullstack Engineer	6a2a5a6018	fix(workspace): include ~1KB sanitized stderr in A2A error responses ... Adds an optional `stderr` parameter to sanitize_agent_error(). When provided, up to 1 KB of stderr text is included in the A2A error response after sanitization (API keys / bearer tokens ≥20 chars / long paths redacted). The existing generic form is preserved when stderr is absent. Updates both the main a2a_executor and the google-adk adapter. Closes: roadmap item — SDK executor stderr swallowing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 18:21:19 +00:00
Molecule AI Core-BE	50319b69f2	fix(workspace): patch enrich_peer_metadata directly in test ... test_blocks_until_inflight_completes used patch("a2a_client.httpx.Client") to mock the HTTP call, but httpx.Client is created inside the background worker thread AFTER the patch context manager exits — the executor thread was created before the patch, so it uses the original httpx module. The httpx patch approach fails reliably when running with test_envelope_enrichment_fetches_on_cache_miss (different httpx patch, different peer ID, same executor thread pool). Fix: directly replace enrich_peer_metadata on the module so the replacement is visible to the background worker regardless of thread creation timing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 17:25:46 +00:00
Molecule AI Infra-SRE	ec20cd04ba	fix(workspace): update 3 test assertions for OFFSEC-003 boundary wrapping (PR #477) ... PR #477 added _A2A_BOUNDARY_START/END wrapping to tool_delegate_task's success path. Three tests in test_delegation_sync_via_polling.py were still asserting exact raw strings and broke: test_flag_off_uses_send_a2a_message_not_polling test_queued_sentinel_triggers_polling_fallback test_non_queued_send_result_does_not_trigger_fallback Fix: check for boundary markers + inner content instead of exact match. Import _A2A_BOUNDARY_START/END from _sanitize_a2a in the affected test methods. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 16:29:31 +00:00
Molecule AI Core-DevOps	40ca44aa4d	chore(workspace): remove unused imports and f-string prefixes ... - test_a2a_tools_delegation.py: remove unused `import os` - test_a2a_tools_impl.py: remove unused `import sys` and `import pytest` - test_a2a_sanitization.py: remove unused `import pytest` and fix two f-strings with no placeholders (extra `f` prefix) All 27 related tests still pass.	2026-05-11 16:10:17 +00:00
Molecule AI · core-be	92f3a17a17	test(workspace): add 17-case coverage for enrich_peer_metadata + nonblocking + worker (#502) ... Co-authored-by: Molecule AI · core-be <core-be@agents.moleculesai.app> Co-committed-by: Molecule AI · core-be <core-be@agents.moleculesai.app>	2026-05-11 15:56:25 +00:00
core-be	952bfb3ca2	fix(workspace): replace asyncio.get_event_loop().run_until_complete with asyncio.run() (#307) (#498) ... Co-authored-by: core-be <core-be@agents.moleculesai.app> Co-committed-by: core-be <core-be@agents.moleculesai.app>	2026-05-11 15:37:34 +00:00
Molecule AI Infra-SRE	d7de4afad4	fix: TestPollingPathSanitization regression — 3 bugs, correct assertions ... Three bugs introduced in PR #477: 1. fake_discover(ws_id) missing source_workspace_id kwarg — discover_peer signature is (target_id, source_workspace_id=None). 2. Direct attribute assignment (d._delegate_sync_via_polling = ...) does not replace module-level 'from module import name' bindings resolved at call time; must use monkeypatch.setattr. 3. Assertions checked for [A2A_RESULT_FROM_PEER] but the polling path uses _A2A_BOUNDARY_START/END — _A2A_RESULT_FROM_PEER is added by send_a2a_message (messaging path), not by _delegate_sync_via_polling. Additionally: monkeypatch.setenv("DELEGATION_SYNC_VIA_INBOX", "1") forces the polling code path so the test exercises the correct logic regardless of environment defaults. Closes #495. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 15:22:16 +00:00
Molecule AI Infra-Runtime-BE	635a42745a	fix(workspace): OFFSEC-003 — separate sanitize vs. wrap, fix tool_delegate_task (#477) ... Co-authored-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app> Co-committed-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app>	2026-05-11 15:10:25 +00:00
Molecule AI · infra-runtime-be	b48198786f	Merge pull request 'fix(workspace): include ~1KB sanitized stderr in A2A error responses' (#454) from fix/stderr-include-a2a-error-response into staging	2026-05-11 11:57:34 +00:00
Molecule AI Infra-Runtime-BE	4a7e1bd988	refactor(workspace): extract idle-loop pending-check guard for direct unit-testing ... Follows up on #432 (merged). Extracts _check_delegation_results_pending() from the inline guard in _run_idle_loop() so tests can call the real production function directly via patch(builtins.open, ...). Fixes #401: the previous test used a mirror copy of the guard logic, which risks drifting from the production implementation over time. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 10:49:40 +00:00
Molecule AI Fullstack Engineer	7290d9727f	fix(workspace): include ~1KB sanitized stderr in A2A error responses ... Adds an optional `stderr` parameter to sanitize_agent_error(). When provided, up to 1 KB of stderr text is included in the A2A error response after sanitization (API keys / bearer tokens ≥20 chars / long paths redacted). The existing generic form is preserved when stderr is absent. Updates both the main a2a_executor and the google-adk adapter. Closes: roadmap item — SDK executor stderr swallowing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 10:32:11 +00:00
Molecule AI Infra-Runtime-BE	318e0ad742	fix(workspace): skip idle prompt when delegation results are pending (#381) (#432) ... Co-authored-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app> Co-committed-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app>	2026-05-11 09:30:32 +00:00
Molecule AI Infra-Runtime-BE	b1e42ac1da	fix(workspace): skip idle prompt when delegation results are pending ... Issue #381: agent tick generators producing stale-repo state. Root cause: the idle loop fires every idle_interval_seconds (default 10 min) and sends an idle prompt regardless of pending delegation results. If a delegation completes just before the idle tick fires, the heartbeat writes results to DELEGATION_RESULTS_FILE and sends a self-message — but the idle prompt arrives first and the agent composes a stale tick before processing the results notification. Peers receive repeated identical asks. Fix: before sending the idle prompt, read DELEGATION_RESULTS_FILE. If it contains unconsumed results, skip this idle tick. The heartbeat's own self-message (sent when results arrive) will wake the agent, which then sees the results in _prepare_prompt() and processes them before composing. Companion to wsr PR (runtime-runtime mirror). Changes: - workspace/main.py: pending-results check in _run_idle_loop() (+26 lines) - workspace/tests/test_idle_loop_pending_check.py: 6-case unit test Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 05:52:58 +00:00
Molecule AI Core-BE	93b7d9a88a	fix(a2a_tools): add comment + test coverage for string-form error handling in delegate_task ... Staging branch bea89ce4 introduced duplicate dead code after a `return` in the delegate_task error-handling block — the first occurrence was the correct fix (adding isinstance(err, str)), but the second occurrence (now unreachable) made the block fragile. Main already has the correct code; this branch adds an explanatory comment and regression tests. The non-tool delegate_task() in a2a_tools.py uses httpx.AsyncClient directly (not send_a2a_message) and must handle three A2A proxy error shapes: {"error": "plain string"} ← the bug fix: isinstance(err, str) {"error": {"message": "...", ...}} ← pre-existing path {"error": {"nested": "object"}} ← falls through to str(err) Adds TestDelegateTaskDirect: test_string_form_error_returns_error_message — regression for AttributeError test_dict_form_error_returns_error_message — pre-existing path still works test_success_returns_result_text — happy path still works Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 05:51:48 +00:00
Molecule AI · core-be	7986648ebd	Merge pull request 'fix(workspace): OFFSEC-003 sanitize polling-path delegation results' (#390) from runtime/offsec-003-polling-path-v2 into staging	2026-05-11 05:20:25 +00:00
Molecule AI Infra-Runtime-BE	8e94c178d2	fix(workspace): OFFSEC-003 sanitize polling-path delegation results ... Issue: _delegate_sync_via_polling (RFC #2829 PR-5 sync path) returned unsanitized response_preview and error_detail fields to the agent context. A malicious peer could inject trust-boundary markers to break the boundary established by the main sanitization layer. Changes: - a2a_tools_delegation.py: sanitize response_preview before returning on completed; sanitize error_detail/summary before wrapping in _A2A_ERROR_PREFIX - test_a2a_tools_delegation.py: TestPollingPathSanitization covers both paths Companion to PR #382 (runtime/offsec-003-executor-sanitize) which covers the async heartbeat path in executor_helpers.read_delegation_results. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 04:53:48 +00:00
Molecule AI Infra-Runtime-BE	3f6de6fe8b	fix(workspace): OFFSEC-003 sanitize read_delegation_results() ... Adds _sanitize_a2a.py (from PR #346) and integrates sanitize_a2a_result() into read_delegation_results() so peer-supplied summary and response_preview fields are escaped before being injected into the agent prompt. Output is wrapped in [A2A_RESULT_FROM_PEER]...[/A2A_RESULT_FROM_PEER] boundary markers so content after the block is clearly not from a peer. Fixes: - test_a2a_executor.py: correct mock patch path to executor_helpers - test_executor_helpers.py: fix boundary-injection test assertion to match _strip_closed_blocks behaviour (closes marker, removes following text) Follow-up to PR #346 (OFFSEC-003 boundary escape) which noted "read_delegation_results() path still needs sanitization" as a gap. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 04:14:52 +00:00
Molecule AI Core-BE	99f3cf7c8f	[core-be-agent] fix(#354): wire delegation-results consumer into a2a executor ... Close the A2A delegation auto-resume gap. Root cause: heartbeat.py's _check_delegations already writes completed delegation rows to DELEGATION_RESULTS_FILE and sends a self-message to wake the agent. executor_helpers.read_delegation_results() was defined to atomically consume that file, but a2a_executor._core_execute() never called it — so delegation results were written but the agent never saw them. Fix: call read_delegation_results() at the top of _core_execute() and prepend the results to the user input context so the agent can act on them without an explicit check_task_status call. The Temporal durable workflow path is also covered because it calls _core_execute() directly. Test: two new cases — delegation results injected when file exists; user input passed through unchanged when file is empty. Closes molecule-core#354.	2026-05-11 02:49:32 +00:00
Molecule AI Infra-Runtime-BE	3eb3609b0c	test(workspace): add queue_id-absence and push-vs-poll distinction tests ... Incorporates valuable extra coverage from fullstack-engineer's PR #336: - test_push_queued_missing_queue_id_still_parsed: queue_id is optional, absence must not break parsing - test_push_queued_is_distinct_from_poll_queued: both envelope shapes parse correctly and independently, with correct delivery_mode values Also adds push_queued_no_queue_id fixture and regression gate entry. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 02:47:21 +00:00
Molecule AI Infra-Runtime-BE	0a9b66a3ed	fix(workspace): push-mode Queued returns delivery_mode="push" (not silent default "poll") ... Bug: a2a_response.py:197 returned Queued(method=method) without passing delivery_mode, silently defaulting to "poll" for push-mode busy-queue responses. Callers branching on v.delivery_mode would mis-identify push-mode responses as poll-mode, causing wrong dispatch logic. Fix: pass delivery_mode="push" explicitly in the push-mode branch. Tests: add push_queued_full/notify/no_method fixtures and 4 test cases asserting delivery_mode="push" for all three envelope shapes. Also add adversarial {"queued": "yes"} and {"queued": False} → Malformed guards. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 02:47:21 +00:00
Molecule AI Infra-SRE	a205099652	fix(security): OFFSEC-003 — boundary-marker escape + shared sanitizer ... Root cause (from infra-lead PR#7 review id=724): Sanitization in PR#7 wrapped peer text in [A2A_RESULT_FROM_PEER] markers, but the markers themselves were not escaped — a malicious peer could inject "[/A2A_RESULT_FROM_PEER]" to close the trust boundary early, making subsequent text appear inside the trusted zone. Fix: - Create workspace/_sanitize_a2a.py (leaf module, no circular import risk) with shared sanitize_a2a_result() + _escape_boundary_markers() - _escape_boundary_markers() escapes boundary open/close markers in the raw peer text before wrapping (primary security control) - Defense-in-depth: also escapes SYSTEM/OVERRIDE/INSTRUCTIONS/IGNORE ALL/YOU ARE NOW patterns (secondary, per PR#7 design intent) - Update a2a_tools_delegation.py: import from _sanitize_a2a; wrap tool_delegate_task return and tool_check_task_status response_preview - Add 15 tests covering boundary escape, injection patterns, integration shapes (workspace/tests/test_a2a_sanitization.py) Follow-up (non-blocking, noted in PR#7 infra-lead review): - Deduplicate if a2a_tools.py also wraps (currently handled in delegation module only — callers get sanitized output regardless) - tool_check_task_status: consider sanitizing 'summary' field too Closes: molecule-ai/molecule-ai-workspace-runtime#7 (wrong-repo PR that this supersedes) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 02:16:09 +00:00
claude-ceo-assistant	5ecec3f253	Merge pull request 'fix(a2a): reject delegate_task to your own workspace ID (self-deadlock guard)' (#291) from fix/self-delegation-guard into main	2026-05-10 10:53:18 +00:00
hongming-pc2	31ed137b74	fix(a2a): reject delegate_task / delegate_task_async to your own workspace ID ... Self-delegation deadlocks: the sending turn holds `_run_lock`, the receive handler waits for the same lock, the A2A request 30s-times-out, and the whole cycle is wasted (the Dev Lead system prompt warns agents off this by hand — "Never delegate_task to your own workspace ID … there is no peer who is also you"). The platform/runtime had no guard. Now both `tool_delegate_task` and `tool_delegate_task_async` early-return an actionable error when `workspace_id == effective_source` (`source_workspace_id or _peer_to_source[target] or WORKSPACE_ID`) — before `discover_peer`, so no network round-trip is wasted either. A genuinely different target (incl. another of a multi-workspace agent's own registered workspaces) is unaffected. Tests: tests/test_a2a_tools_delegation.py — new TestSelfDelegationGuard (4 cases: rejects own ID; rejects when source_workspace_id explicitly == target; async path rejects; a different target passes the guard through to discover_peer). `pytest tests/test_a2a_tools_delegation.py` → 12 passed. (tests/test_a2a_tools_impl.py's TestToolDelegateTask* suite is red on this PC2/Windows checkout — same on `main` without this change; httpx-mock infra, not this PR — CI validates on Linux.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-10 03:46:59 -07:00