866 Commits

Author	SHA1	Message	Date
Molecule AI Core-BE	424ffbdb43	test(handlers/org): add unit tests for walkOrgWorkspaceNames, resolveProvisionConcurrency, errString ... Issue #741: three pure helpers in org.go had no unit tests. Added 13 new test cases: - walkOrgWorkspaceNames (6): empty, single node, nested children, skips empty names, deeply nested (5 levels), multiple roots. - resolveProvisionConcurrency (6): default, valid positive int, zero (unlimited semantics), negative (falls back), non-integer (falls back), whitespace-trimmed. - errString (3): nil error, non-nil error, wrapped error (%w). Closes: molecule-ai/molecule-core#741 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:53:40 +00:00
hongming	4a8e7e4a73	fix(test): align bundle import expectations	2026-05-13 23:49:13 +00:00
hongming	0cf425e8bd	fix(bundle): reject imports without a bundle name	2026-05-13 23:49:13 +00:00
hongming	8ac21a0cb5	fix(test): avoid delegation integration constant collision	2026-05-13 23:48:55 +00:00
hongming-codex-laptop	7ce65ac4cb	fix(handlers): repair current main test blockers	2026-05-13 22:55:29 +00:00
Molecule AI Infra-SRE	b5b24ab64b	fix(main): heal ADMIN_TOKEN placeholder in global_secrets on startup (#831) ... Cherry-pick from staging (PR #893) — that PR was accidentally merged to staging instead of main, leaving the production fix stranded. The root cause: workspaces provisioned with ADMIN_TOKEN=placeholder in global_secrets receive that placeholder as a container env var, breaking any code that calls platform APIs. This runs once at startup (SaaS only) and replaces the placeholder with the real token from the host environment. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 22:42:32 +00:00
Molecule AI Infra-Runtime-BE	081b570525	fix(delegations): ListDelegations falls back to delegations table before activity_logs ... RFC #2829 PR-1/4: GET /workspaces/:id/delegations previously queried only activity_logs, returning [] for active/completed delegations while the agent's check_delegation_status showed them correctly. The new delegations table (migration 049) now holds durable state for active delegations. The handler now tries the ledger first (delegations table), falls back to activity_logs for pre-migration data, and returns [] only when both are empty. This closes the mismatch where: - GET /delegations → [] - check_delegation_status(task_id) → active/completed 6 new tests: TestListDelegations_LedgerRowsReturned TestListDelegations_LedgerEmptyFallsBackToActivityLogs TestListDelegations_BothEmptyReturnsEmptyArray TestListDelegations_LedgerQueryErrorFallsBackToActivityLogs TestListDelegations_LedgerCompletedIncludesResultPreview TestListDelegations_LedgerFailedIncludesErrorDetail Updated existing tests TestListDelegations_Empty and TestListDelegations_WithResults to use the ledger-first flow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 21:50:03 +00:00
hongming-codex-laptop	5043532d30	fix(go): remove ineffectual pgplugin index increment	2026-05-13 14:32:41 -07:00
Molecule AI Core-DevOps	b9ca3b0653	fix(provisioner): inject ADMIN_TOKEN into workspace container env (core#831) ... CPProvisioner.Start() reads ADMIN_TOKEN from os.Getenv() and uses it for CP→platform HTTP auth, but never passes it to the workspace container's runtime env. Without ADMIN_TOKEN in the container, the integration-tester workspace (ID: 33bb2f71) gets 401 from /admin/liveness, blocking Gate 5 and the release promotion cycle. Fix (CP/SaaS mode): inject p.adminToken into the Env map sent to the control plane so it reaches the EC2 instance's container env. Fix (Docker/local mode): inject os.Getenv("ADMIN_TOKEN") from the platform server into the Docker container env via buildContainerEnv. This mirrors the SaaS path so any workspace in any mode can reach /admin/liveness. Safe: both paths only inject when ADMIN_TOKEN is non-empty (Docker/local dev without ADMIN_TOKEN set is unaffected; the platform server's env carries it in SaaS/prod). Refs: core#831 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 21:05:02 +00:00
hongming-codex-laptop	093b6df3dc	fix(ci): repair handler test compile drift	2026-05-13 20:31:27 +00:00
devops-engineer	7e30a85463	Merge pull request 'test: add handler test coverage — workspace_crud, mcp_tools, org_layout, hub' (#860) from feat/platform-handler-test-coverage into main	2026-05-13 18:11:57 +00:00
devops-engineer	cbef4ca3d4	Merge pull request 'fix(handlers): restore bundle import test build' (#850) from fix/main-red-sqlmock-import into main	2026-05-13 18:10:06 +00:00
devops-engineer	761c590cd0	Merge pull request 'test(store/pgplugin): fix TestStore_PatchNamespace_DualFields using regexp.QuoteMeta' (#857) from fix/test-patchnamespace-dualfields into main	2026-05-13 18:08:14 +00:00
Molecule AI Core-BE	2d68f2c8be	chore: drop workspace_dispatchers_test.go — superseded by PR #868 (staging)	2026-05-13 18:04:00 +00:00
Molecule AI Core-BE	74864af1fb	chore: drop org_layout_test, hub.go, hub_test.go (already in staging with better coverage)	2026-05-13 18:04:00 +00:00
Molecule AI Core-BE	59c573d8de	fix(test): mock workspace_auth_tokens in TestState_LegacyWorkspaceNoLiveToken ... State handler always calls wsauth.HasAnyLiveToken (queries workspace_auth_tokens) before the main workspaces query. The legacy test was missing this mock expectation, causing an unexpected-query sqlmock error. Add the EXISTS(false) expectation to match the other State test cases. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:04:00 +00:00
Molecule AI Core-BE	293e3abcb7	test: add handler test coverage — workspace_crud, mcp_tools, org_layout, hub, a2a queue ... Eight test files covering pure functions and handler logic: - a2a_queue_expiry_test.go: expiry queue TTL and cleanup (88 lines) - mcp_tools_test.go: extractA2AText parsing edge cases (193 lines) - org_layout_test.go: childSlot/sizeOfSubtree/childSlotInGrid grid helpers (244 lines) - plugins_atomic_test.go: tarWalk prefix normalization, symlink filtering, nested dirs, dir-entry trailing slash (167 lines) - workspace_crud_test.go: workspace state/update/delete/CascadeDelete + validators (601 lines) - workspace_dispatchers_test.go: DispatchWorkspaceRequest handler pure helpers (128 lines) - ws/hub.go: nil-guard on client.Conn in Hub.Close - ws/hub_test.go: hub broadcast/send/nil AccessChecker coverage (386 lines) Note: workspace_delivery_mode_test.go and instructions_test.go were removed from this PR — they are covered by parallel branches targeting staging (PR #868 and fix/321-cwe22 respectively). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:04:00 +00:00
devops-engineer	c74d7c13d7	Merge remote-tracking branch 'origin/main' into fix/main-red-sqlmock-import	2026-05-13 17:09:35 +00:00
devops-engineer	7c5b3e89f9	Merge remote-tracking branch 'origin/main' into fix/test-patchnamespace-dualfields	2026-05-13 17:08:57 +00:00
devops-engineer	a709609a3c	Merge remote-tracking branch 'origin/main' into fix/stdio-fallback-all-environments	2026-05-13 17:04:44 +00:00
core-be	7f2b218cd3	feat(kimi): Kimi as first-class BYO-compute runtime + delegation retry fix ... - Add isExternalLikeRuntime() helper for kimi/kimi-cli/external - Extend runtime_registry, workspace handler, canvas UX for Kimi - Fix delegation retry: skip retry when response body already received - Restore a2a_client cache-first path (peer_name KeyError, already on main) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-13 09:01:30 -07:00
platform-engineer	2067070f93	fix(ci): resolve 4 CI failures on PR#778 ... 1. ci-mcp-stdio-transport.yml: install pytest-cov so --no-cov flag doesn't conflict with workspace/pytest.ini addopts (exit code 4). Run 26124 (MCP stdio with regular-file stdout). 2. ci-mcp-stdio-transport.yml: add # mc#774 tracker on continue-on-error: true to satisfy lint-continue-on-error-tracking Tier 2e. Run 26132. 3. ci-mcp-stdio-transport.yml: add # bp-exempt directive comment above mcp-stdio-regular-file job key to satisfy lint-required-context-exists-in-bp Tier 2g. Run 26135. 4. bundle_test.go: import github.com/DATA-DOG/go-sqlmock explicitly so the package identifier resolves when compiled with -tags=integration. Run 26130 (Handlers Postgres Integration). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-13 08:16:09 -07:00
devops-engineer	ecdae882b6	Merge pull request 'feat(canvas): mount SearchDialog in desktop + mobile canvas shells' (#837) from design/826-searchdialog-mount-v2 into main	2026-05-13 14:20:08 +00:00
devops-engineer	1231177325	Merge branch 'main' into fix/stdio-fallback-all-environments	2026-05-13 14:14:42 +00:00
hongming-codex-laptop	3dd6d91142	fix(handlers): restore bundle import test build	2026-05-13 06:20:38 -07:00
Molecule AI Infra-Runtime-BE	d0611d4eee	Merge origin/main into fix/stdio-fallback-all-environments ... Conflicts resolved: - workspace/a2a_client.py: accept HEAD (TTL cache check, full comment) - workspace/a2a_executor.py: accept HEAD (sanitize_agent_error(exc=e)) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:44:23 +00:00
Molecule AI Core-OffSec	4b5614cbdd	fix(memory/pgplugin): restore idx++ in PatchNamespace (OFFSEC-004) ... Commit ad7acd30 removed this increment as a golangci-lint false-positive ("unused variable: idx") — idx is used in the query string built by fmt.Sprintf, so the lint was wrong. The removal broke the dual-field case: when both ExpiresAt and Metadata are set, the query uses \$3 for metadata but args only has 3 elements (indices 0=name, 1=expires, 2=metadata), so \$3 is out-of-bounds or reads the wrong value. Fix: restore idx++ after the metadata args append. Test: add TestStore_PatchNamespace_DualFields — covers the previously untested case where both expires_at and metadata are patched in one call. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:35:07 +00:00
devops-engineer	3db93d3d44	Merge pull request '[core-be-agent] test(handlers/bundle): add bundle_test.go — 5 cases + fix nil broadcaster panic' (#801) from feat/workspace-dispatchers-test-coverage into main	2026-05-13 08:29:41 +00:00
devops-engineer	871f8f52b5	Merge pull request 'fix(lint): resolve 64 pre-existing golangci-lint violations in workspace-server' (#803) from fix/golangci-lint-preexisting-violations into main	2026-05-13 07:55:29 +00:00
devops-engineer	f06a8e76fc	Merge pull request 'fix(platform): install docker-cli-buildx in workspace-server image (mc#765 follow-up)' (#796) from fix/workspace-server-docker-cli-buildx-mc765-followup into main	2026-05-13 07:42:04 +00:00
hongming-codex-laptop	c2e462ca26	fix(lint): resolve 64 pre-existing golangci-lint violations in workspace-server ... Fixes all ineffassign (7), staticcheck (31), and unused (26) violations reported by golangci-lint in workspace-server/ so the linter gate is clean. Key changes by linter: - ineffassign: remove 7 variables assigned then immediately overwritten - QF1001 (De Morgan): rewrite 4 negated compound conditions - QF1006 (loop lift): 2 for{if break} → for !cond{} - QF1008 (embedded field): drop .Resources. from hostCfg/hc selectors (provisioner + tests) - QF1012 (Fprintf): 3 sb.WriteString(fmt.Sprintf) → fmt.Fprintf - S1009 (nil+len): remove redundant nil check before len() - S1016 (type conv): 2 struct-literal copies → direct type conversion - S1017 (TrimPrefix): 2 if+HasPrefix/slice → strings.TrimPrefix - S1023 (redundant return): remove 2 trailing returns in middleware - SA1012 (nil context): nil → context.TODO() in resolver_test - SA1019 (deprecated): ImageInspectWithRaw → ImageInspect; RetryAfter direct field - SA5011 (nil deref): t.Error → t.Fatal before dereference in client_test - ST1005 (error string): lowercase 3 error strings starting with proper nouns - ST1013 (HTTP constant): 405 literal → http.StatusMethodNotAllowed - unused: delete 26 unused consts/types/funcs/fields across 12 files All three checks pass after this commit: go build ./... → success go vet ./... → success golangci-lint run --timeout 3m ./... → 0 issues Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 23:47:36 -07:00
hongming-codex-laptop	ad7acd30db	fix(platform): clear golangci-lint findings	2026-05-12 22:53:22 -07:00
Molecule AI Core-BE	0d74b1fa79	[core-be-agent] fix(bundle_test): TestBundleImport_ValidJSON nil broadcaster panic ... TestBundleImport_ValidJSON passed nil broadcaster to BundleHandler. bundle.Import calls broadcaster.RecordAndBroadcast unconditionally → panic when broadcaster is nil. Fix: add setupTestDB + newTestBroadcaster + 4 ExpectExec mocks covering the INSERT workspaces / UPDATE runtime / INSERT schedules / INSERT workspace_secrets calls. Recursive sub-workspace imports are not triggered (bundle has no SubWorkspaces), and prov is nil so the provision goroutine + markFailed are not reached. Also caught: the original test never called setupTestDB, so db.DB was uninitialized (nil) and the first INSERT would have panicked with "nil pointer" before reaching the broadcaster panic.	2026-05-13 05:37:43 +00:00
Molecule AI Core-BE	da3015c72e	test(handlers/bundle): add bundle_test.go — 5 cases covering Import + Export error paths ... Covers: - BundleHandler.Import: invalid JSON (7 sub-cases) → 400 - BundleHandler.Import: valid JSON → 201 - BundleHandler.Export: workspace not found (ErrNoRows) → 404 - BundleHandler.Export: DB query error → 404 Branch: feat/workspace-dispatchers-test-coverage Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 05:15:28 +00:00
hongming-pc2	1c17f0ff73	fix(platform): install docker-cli-buildx in workspace-server image (mc#765 follow-up) ... mc#765 added `docker-cli` to the workspace-server Alpine runtime, but the Alpine package is just the CLI binary — it does NOT include the buildx plugin. Modern Docker (26.x in this image) defaults BuildKit=on, so `docker build` immediately fails with: local-build: pre-flight OK (docker=/usr/bin/docker) Provisioner: workspace start failed for <id>: local-build mode: ensure image for runtime "claude-code": local-build: docker build molecule-local/workspace-template-claude-code:<sha>: exit status 1: ERROR: BuildKit is enabled but the buildx component is missing or broken. Caught immediately after the mc#765 platform-image deploy + recreate during the sdk-lead (360d42e4-8356-441c-80cf-16fcd5d5ce03) + CP-QA (ec6cf05b-2637-4b3c-b561-b33914849aa2) recovery POST /restart calls. Pre-flight passed (docker CLI present, confirmed by the line above), but the actual `docker build` aborted on buildx-missing. The fix mirrors mc#765's shape: add the matching Alpine package (`docker-cli-buildx`, in community/, verified 0.14.0-r3 on alpine:3.20) to the apk add line in workspace-server/Dockerfile. Diff is +1 word in the apk-add line and a comment block extension that explains the BuildKit/buildx requirement. Related: mc#765 (parent fix), Task #194 / Issue #63 (local-build path).	2026-05-12 22:14:46 -07:00
hongming	738e54593c	Merge pull request 'fix(platform): install docker-cli in workspace-server image — unblocks RegistryModeLocal' (#765) from infra/dockerfile-add-docker-cli-for-local-build into main	2026-05-13 04:39:13 +00:00
hongming	03e7a2d8a5	Merge pull request 'test(handlers): drain preflight restart goroutine' (#780) from fix/core-main-red-race-20260512 into main	2026-05-13 04:30:05 +00:00
hongming-codex-laptop	381c710f8a	test(handlers): drain preflight restart goroutine	2026-05-12 21:07:40 -07:00
Molecule AI Core-Security	40edbd3aae	Merge main into feat/a2a-proxy-helpers-test-coverage	2026-05-12 20:43:27 -07:00
Molecule AI Core-Security	e5069012fb	Merge commit '806bbb464ee0df5f2537815ad9509aa28b51dbae' into mm2-700	2026-05-12 20:19:30 -07:00
Molecule AI Core-Security	181a8f9ca7	Merge commit '806bbb464ee0df5f2537815ad9509aa28b51dbae' into mm2-699	2026-05-12 20:19:24 -07:00
Molecule AI Core-Security	2ec3f72857	Merge commit 'd332a854d545' into mm-700	2026-05-12 20:04:13 -07:00
Molecule AI Core-Security	6d98d84255	Merge commit 'd332a854d545' into mm-699	2026-05-12 20:04:05 -07:00
Molecule AI Core-Security	598e0471c4	Merge commit 'd332a854d545cb5a8157fb710688c6995c4811e6' into merge-main-698b	2026-05-12 20:03:18 -07:00
dev-lead	a65cea7b66	fix: handle json null and empty array in extractToolTrace ... JSON null unmarshals to []byte("null") (4 bytes), not nil, so len(trace)==0 missed it. Empty array []byte("[]")==2 bytes was also returned unchanged. Add explicit string checks for both cases. Also fix TestExtractToolTrace_ValidNonEmpty: json.Marshal compacts spacing, so byte-exact comparison against spaced literal fails on round-trip. Use compact literal instead. Fixes mc#669 (null tool_trace panic path).	2026-05-12 19:44:22 -07:00
Molecule AI Core-Security	a224740d4d	Merge remote-tracking branch 'dev-lead/main' into pr693-test	2026-05-12 19:12:23 -07:00
Molecule AI Core-Security	a8f8e07c02	Merge remote-tracking branch 'dev-lead/main' into pr698-test	2026-05-12 18:46:30 -07:00
Molecule AI Core-Security	85c2db6248	Merge remote-tracking branch 'dev-lead/main' into pr700-test	2026-05-12 18:46:27 -07:00
Molecule AI Core-Security	8dae36277f	Merge remote-tracking branch 'dev-lead/main' into pr699-test	2026-05-12 18:46:25 -07:00
Molecule AI Core-Security	8aa409211c	fix(test): correct org_import_helpers_test logic errors and remove duplicates ... Remove TestCollectOrgEnv_Empty and TestCollectOrgEnv_RequiredWinsOverRecommended which are already declared in org_test.go. Fix TestSanitizeEnvMembers_MaxLength to use printable chars instead of null bytes, fix TestSanitizeEnvMembers_DigitsAndUnderscore to drop leading-underscore names that fail ^[A-Z] regex, fix TestFlattenAndSortRequirements_GroupsSortedByMemberKey assertion order (A < B), and fix TestCollectOrgEnv_GroupWithOneInvalid_KeepsRest to use valid/invalid names that the sanitizer will actually filter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 18:45:53 -07:00