3 Commits

Author	SHA1	Message	Date
hongming-codex-laptop	ad7acd30db	fix(platform): clear golangci-lint findings	2026-05-12 22:53:22 -07:00
Hongming Wang	64e58fb390	test(memory-v2-e2e): update expectChainQueryRoot for new name column ... PR #2990 root cause: the resolver SQL added `name` to the SELECT for DisplayName plumbing, but the e2e test's sqlmock fixture (expectChainQueryRoot at swap_test.go:216) still scripts the 3-column shape. Three e2e tests fail with: sql: expected 3 destination arguments in Scan, not 4 Fix: bump the fixture to 4 columns (id, name, parent_id, depth) and pass an empty name. The e2e tests don't assert on label rendering — they pin the namespace string flow ("workspace:root-1" etc), which is unchanged. Empty name is fine: ReadableNamespaces still emits the correct namespace strings; only DisplayName is empty. Caught by CI's Platform (Go) check on PR #2990 — would have been a silent missed-coverage case in the resolver_test.go run because that package doesn't import the e2e package. 🤖 Generated with [Claude Code](https://claude.com/claude-code)	2026-05-05 19:10:18 -07:00
Hongming Wang	b937415e1e	Memory v2 PR-11: E2E test — flat-plugin swap proves contract works ... Final implementation PR. Builds on PR-1..10 (all merged or queued). Proves the central design property of the plugin contract: ANY plugin satisfying the v1 OpenAPI spec works as a drop-in replacement for the built-in postgres plugin. If this test fails after a refactor, the contract has drifted in a way that breaks ecosystem plugins. What ships: * internal/memory/e2e/swap_test.go — five E2E tests against a deliberately minimal "flat-memory" stub plugin (~50 LOC, single map, zero capabilities) * MCPHandler.Dispatch — small exported wrapper around dispatch so out-of-package E2E tests can drive tools by name without duplicating the whole MCP RPC stack E2E coverage: * TestE2E_FlatPluginRoundTrip: full lifecycle - list_writable_namespaces returns 3 entries - commit_memory_v2 writes through plugin - search_memory finds it back - commit_summary writes a summary - forget_memory deletes - search after forget excludes the deleted memory * TestE2E_LegacyShimRoutesThroughFlatPlugin: PR-6 shim wired up - Legacy commit_memory(scope=LOCAL) ends up in plugin storage - Legacy recall_memory finds it back through plugin search - Response shapes preserved (scope:LOCAL stays scope:LOCAL) * TestE2E_OrgMemoriesDelimiterWrap: prompt-injection mitigation - Org-namespace memory committed - Audit INSERT into activity_logs verified - Search returns content with [MEMORY id=... scope=ORG ns=...] prefix applied * TestE2E_StubPluginCapabilitiesAreEmpty: capability negotiation - Stub plugin reports zero capabilities - Client.SupportsCapability returns false for FTS, embedding - Confirms graceful degradation when plugin doesn't support a feature * TestE2E_PluginUnreachable_AgentSeesClearError: failure surface - Plugin URL pointing at bogus port - commit_memory_v2 returns informative error - No nil-pointer dereference; error message is actionable The flat plugin is intentionally minimal — it has no namespaces table distinct from memory records, no FTS, no semantic search, no TTL. The test proves operators can drop in a 50-line plugin and the agent behavior is identical (modulo capability-gated features).	2026-05-04 08:20:35 -07:00