304 Commits

Author	SHA1	Message	Date
Molecule AI Core-QA	25866ec200	fix(workspace/OFFSEC-003): correct boundary wrapping + add closer truncation ... Two bugs fixed in tool_delegate_task wrapping logic: 1. Wrapping used raw _A2A_BOUNDARY_START/_END markers, which appeared in the output alongside the escaped form of the peer content (e.g. "[A2A_RESULT_FROM_PEER]\n[/ A2A_RESULT...]"). Fixed: wrap with _A2A_BOUNDARY_START_ESCAPED/_END_ESCAPED so the output contains no raw closer that could confuse downstream parsers. 2. A malicious peer could inject a fake closer ([/A2A_RESULT_FROM_PEER]) to make legitimate content appear truncated. Fixed: truncate at the raw closer BEFORE sanitization (truncation loses the raw form, so escaping afterward cannot retroactively remove it). Also fixes 10 regressions in test_a2a_offsec003_sanitization.py: tests were written expecting ZWSP (U+200B) escaping but implementation uses "[/ " prefix. Updated test invariants to match actual behavior. Also fixed 5 tests using [A2A_ERROR] in summary fields (not a boundary marker — no escaping applied) and updated test assertions in test_a2a_tools_impl.py and test_delegation_sync_via_polling.py to expect escaped wrapper forms. Cherry-picked fix/test-stdio-function-name (e478b5b2) from main: renamed _warn_if_stdio_not_pipe → _assert_stdio_is_pipe_compatible and added deprecated alias, fixing dangling monkeypatch targets that caused 5 test failures (issue #957). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 21:01:34 +00:00
Molecule AI Core-DevOps	e51f7004b3	fix(workspace): rename _warn_if_stdio_not_pipe → _assert_stdio_is_pipe_compatible ... Rename the canonical function to `_assert_stdio_is_pipe_compatible` with a deprecated alias `_warn_if_stdio_not_pipe` for backward compat. Updates all 5 test import sites. Fixes dangling monkeypatch targets in test_a2a_mcp_server_http.py (which patches `_assert_stdio_is_pipe_compatible`; main's source defined the old name, causing patches to silently no-op). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 20:05:56 +00:00
Molecule AI Core-QA	6a0383bbf8	fix(workspace): revert OFFSEC-003 test assertions — original expectations were correct ... PR #946 incorrectly changed test assertions to expect ZWSP/regex-based stripping behavior that the production code never had. The actual sanitizer uses simple string replacement (e.g. [/A2A_RESULT_FROM_PEER] → [/ /A2A_RESULT_FROM_PEER]) and does NOT strip content after closers. Reverts test file to the correct string-replacement expectations from commit 40ca44aa. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 05:03:36 +00:00
Molecule AI Core-QA	fa81626b71	fix(workspace): correct OFFSEC-003 test assertions to match ZWSP-escaping behavior ... Corrects 12 broken test assertions in test_a2a_sanitization.py that were introduced by the PR #916 merge. Assertions mischaracterized the sanitizer's ZWSP-escaping behavior, especially around the (?<=\\n) lookbehind in _strip_closed_blocks. Key corrections: - test_escape_close_marker: closer preceded by \\n IS stripped (matches the (?<=\\n) lookbehind); injected closer + all content after removed - test_escape_open_marker: opener at start-of-line IS ZWSP-escaped (ZWSP inserted between \\n and [) - test_escape_full_fake_boundary_pair: opener ZWSP-escaped, closer stripped - test_empty_string_returns_empty: None coerced by first if-check → "" - All TestInjectionPatternDefenseInDepth tests: use bracketed [SYSTEM] form matching _CONTROL_PATTERNS regex, not colon-prefixed form - test_check_task_status_*: JSON fields have no boundary markers (no wrapping) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:39:34 +00:00
Molecule AI Infra-Runtime-BE	8faae1c9d9	test(a2a_mcp_server): add 5 tool-branch coverage cases to HTTP transport tests ... Cover remaining elif branches in handle_tool_call: - send_message_to_user: mixed-type attachments are filtered (line 116) - wait_for_message: dispatched with timeout_secs argument - inbox_peek: dispatched with limit argument - inbox_pop: dispatched with activity_id argument - chat_history: dispatched with peer_id/limit/before_ts arguments Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 00:27:57 +00:00
Molecule AI Infra-Runtime-BE	ed47e89d13	test(builtin_tools): add 16-case coverage for _redact_secrets (C2, #834) ... Bring builtin_tools/security._redact_secrets from 58% to 100% coverage. Contextual keyword=value patterns, idempotency, boundary cases, mixed content. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 00:27:57 +00:00
Molecule AI Infra-Runtime-BE	07ea7bdd82	feat(workspace): add HTTP/SSE transport to a2a_mcp_server ... Port HTTP/SSE transport (from workspace-runtime PR #16) to the canonical monorepo source. Enables the Hermes MCP-native runtime to communicate with the A2A platform tools via HTTP/SSE instead of stdio. The SSE event_stream() is an async generator — Starlette's Response requires sync content and raises AttributeError for async generators. Switch the SSE handler to StreamingResponse which properly handles async generators via anyio.create_task_group (Starlette 1.0.0). Adds test_a2a_mcp_server_http.py: 24 tests covering _handle_http_mcp, Starlette app routes, SSE queue delivery, and cli_main argparse. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 00:27:56 +00:00
Molecule AI Core-DevOps	37b01b4e24	[core-devops-agent] fix: add HEALTHCHECK to workspace/Dockerfile ... Probe the A2A agent-card endpoint so orchestrators and container runtimes can detect a live, responsive workspace agent without requiring a registered agent token. - Uses curl (present in python:3.11-slim base) - Targets uvicorn server on configurable PORT (default 8000) - interval=30s, timeout=5s, retries=3 — balances responsiveness vs. false-positive tolerance on busy containers - ${PORT:-8000} substitution is safe because: (a) the base image EXPOSEs 8000 (b) molecule-runtime defaults config.a2a.port to 8000 (c) the entrypoint uses exec form so HEALTHCHECK exec succeeds Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 22:29:45 +00:00
Molecule AI Infra-Runtime-BE	3e9a2665f3	test(executor): update error-handling tests for sanitize_agent_error ... The sanitize_agent_error(exc=e) fix produces the sanitized format "Agent error (RuntimeError) — see workspace logs for details." instead of the raw exception string. Update two assertions in test_agent_error_handling and test_terminal_error_routes_via_updater_failed to expect the secure format, and assert raw message is NOT present. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:50:59 +00:00
Molecule AI Infra-Runtime-BE	d0611d4eee	Merge origin/main into fix/stdio-fallback-all-environments ... Conflicts resolved: - workspace/a2a_client.py: accept HEAD (TTL cache check, full comment) - workspace/a2a_executor.py: accept HEAD (sanitize_agent_error(exc=e)) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:44:23 +00:00
Molecule AI Infra-Runtime-BE	c12da5a241	fix(a2a_executor): restore sanitize_agent_error on subprocess errors ... The stdio-fallback branch replaced the sanitize_agent_error() wrapper with a bare f-string, causing raw exception messages to surface in the chat UI instead of the sanitized "Agent error ({type}) — see workspace logs for details." format. This restores the original sanitize_agent_error(exc=e) call in the updater.failed() path — same category of regression as the OFFSEC-003 sanitization fix (261a8e24) and the TTL cache fix (c2325f1a). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:42:58 +00:00
Molecule AI Infra-Runtime-BE	261a8e2498	fix(builtin_tools/a2a): restore OFFSEC-003 peer-result sanitization ... The stdio-fallback branch removed the OFFSEC-003 sanitization from builtin_tools/a2a_tools.py (the LangChain adapter's A2A tools): - Removed the `from _sanitize_a2a import sanitize_a2a_result` import - Removed `sanitize_a2a_result()` wrapping from all delegate_task() return paths (peer text, error messages, raw data) Without this, the LangChain adapter passes raw peer content directly into the agent's LLM context — the same OFFSEC-003 injection surface that was fixed in a2a_tools_delegation.py (#492/#537). This patch restores the exact original sanitization calls. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:34:51 +00:00
Molecule AI Infra-Runtime-BE	c2325f1a17	fix(a2a): restore TTL cache check in enrich_peer_metadata_nonblocking ... The stdio-fallback branch removed the cache-first check from enrich_peer_metadata_nonblocking, causing 5 tests to fail: test_envelope_enrichment_uses_cache_when_present test_envelope_enrichment_fetches_on_cache_miss test_envelope_enrichment_re_fetches_after_ttl test_enrich_peer_metadata_nonblocking_cache_hit_returns_immediately test_enrich_peer_metadata_nonblocking_cache_miss_schedules_fetch The removed lines checked the peer metadata cache (TTL-bounded) and returned immediately on a cache hit. Without this, every push for a known peer schedules a background fetch — a performance regression and a deviation from the documented contract (PR #2484). This patch restores the cache check to the exact original logic. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:09:54 +00:00
hongming-kimi-laptop (Molecule AI agent)	e1aac92539	fix(mcp): universal stdio transport + runtime-adaptive notifications ... Root fix for molecule-ai-workspace-runtime#61: - Replace asyncio.connect_read_pipe/connect_write_pipe with direct sys.stdin.buffer/sys.stdout.buffer I/O. The asyncio pipe transport rejects regular files, PTYs, and sockets — breaking openclaw, CI tests, and tee-captured debugging. Direct buffer I/O works with ANY file descriptor. - Replace fatal _assert_stdio_is_pipe_compatible() with non-fatal _warn_if_stdio_not_pipe() — operators get diagnostic signal without the hard exit. Runtime detection for adaptive push notifications: - Detect MCP host from env vars: CLAUDE_CODE, OPENCLAW_SESSION_ID, CURSOR_MCP, HERMES_RUNTIME - Emit the correct JSON-RPC notification method per host: notifications/claude/channel, notifications/openclaw/channel, etc. - Unifies the molecule-mcp-claude-channel plugin behavior into the universal MCP server — one implementation for all runtimes. Tests: - Update TestStdioPipeAssertion for warning-based behavior - Patch runtime detection in channel-notification tests - 80 passed, 5 pre-existing failures (enrichment cache unrelated)	2026-05-12 19:55:45 -07:00
Molecule AI Core-DevOps	7f90630f98	fix(tests): correct test_sanitize_agent_error_stderr_and_exc assertion ... The test expected the exception class to be hidden when stderr is provided, but the implementation always uses the exc type as the tag. Fix the assertion to match actual (correct) behavior: ValueError is in the tag, stderr is the body. Also add a check that we don't fall back to the generic "workspace logs" form. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 22:59:41 +00:00
Molecule AI Core-DevOps	a92839e39a	ci: verify publish-runtime pipeline end-to-end (internal#327) ... Marker file triggers workspace/** path filter on publish-runtime-autobump.yml, exercising the full runtime publish pipeline after publish-runtime-bot provisioning + stale-tag resolution. Acceptance: bump-and-tag green, tag exists, publish-runtime.yml green, PyPI updated, 9 template repos updated. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 20:26:55 +00:00
Molecule AI Core Platform Lead	6d5fd6be3e	fix(workspace): wrap delegate_task return with sanitize_a2a_result (CWE-117, closes #537) ... Issue #537: builtin_tools/a2a_tools.py:72 returns peer-sourced text from delegate_task() without OFFSEC-003 sanitization. Sibling regression to #491 / #492 in a different code path (google-adk delegation surface). Fix: import sanitize_a2a_result from _sanitize_a2a and wrap all 4 peer-controlled return sites in delegate_task() — parts[0].text path, empty-parts str(result) path, fallback str(result) path, and the error message path. Closes #537.	2026-05-11 19:09:18 +00:00
Molecule AI Infra-Runtime-BE	389613bb95	fix(tests): correct assert in test_sanitize_agent_error_stderr_and_exc ... The exc class IS the tag when stderr is provided: "Agent error (ValueError): rate limit exceeded" Fixes the incorrect assertion added in PR #517. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 18:21:19 +00:00
Molecule AI Fullstack Engineer	6a2a5a6018	fix(workspace): include ~1KB sanitized stderr in A2A error responses ... Adds an optional `stderr` parameter to sanitize_agent_error(). When provided, up to 1 KB of stderr text is included in the A2A error response after sanitization (API keys / bearer tokens ≥20 chars / long paths redacted). The existing generic form is preserved when stderr is absent. Updates both the main a2a_executor and the google-adk adapter. Closes: roadmap item — SDK executor stderr swallowing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 18:21:19 +00:00
Molecule AI Core-BE	50319b69f2	fix(workspace): patch enrich_peer_metadata directly in test ... test_blocks_until_inflight_completes used patch("a2a_client.httpx.Client") to mock the HTTP call, but httpx.Client is created inside the background worker thread AFTER the patch context manager exits — the executor thread was created before the patch, so it uses the original httpx module. The httpx patch approach fails reliably when running with test_envelope_enrichment_fetches_on_cache_miss (different httpx patch, different peer ID, same executor thread pool). Fix: directly replace enrich_peer_metadata on the module so the replacement is visible to the background worker regardless of thread creation timing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 17:25:46 +00:00
Molecule AI Infra-SRE	1380bf0907	fix(a2a): add cache-first check to enrich_peer_metadata_nonblocking ... enrich_peer_metadata_nonblocking (a2a_client.py) never checked the _peer_metadata cache before scheduling a background fetch — it always returned None and always fired the executor thread pool. The docstring promised "cache hit: return the cached record" but the code did not implement it. Fix: add the same TTL-check that enrich_peer_metadata uses before scheduling the worker. On a warm cache hit the function now returns immediately without touching the in-flight set or the executor. Closes the remaining 5 test failures in test_a2a_mcp_server.py on main that were not covered by PR #508's test-assertions fix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 16:59:54 +00:00
Molecule AI Infra-SRE	ec20cd04ba	fix(workspace): update 3 test assertions for OFFSEC-003 boundary wrapping (PR #477) ... PR #477 added _A2A_BOUNDARY_START/END wrapping to tool_delegate_task's success path. Three tests in test_delegation_sync_via_polling.py were still asserting exact raw strings and broke: test_flag_off_uses_send_a2a_message_not_polling test_queued_sentinel_triggers_polling_fallback test_non_queued_send_result_does_not_trigger_fallback Fix: check for boundary markers + inner content instead of exact match. Import _A2A_BOUNDARY_START/END from _sanitize_a2a in the affected test methods. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 16:29:31 +00:00
Molecule AI Core-DevOps	40ca44aa4d	chore(workspace): remove unused imports and f-string prefixes ... - test_a2a_tools_delegation.py: remove unused `import os` - test_a2a_tools_impl.py: remove unused `import sys` and `import pytest` - test_a2a_sanitization.py: remove unused `import pytest` and fix two f-strings with no placeholders (extra `f` prefix) All 27 related tests still pass.	2026-05-11 16:10:17 +00:00
Molecule AI · core-be	92f3a17a17	test(workspace): add 17-case coverage for enrich_peer_metadata + nonblocking + worker (#502) ... Co-authored-by: Molecule AI · core-be <core-be@agents.moleculesai.app> Co-committed-by: Molecule AI · core-be <core-be@agents.moleculesai.app>	2026-05-11 15:56:25 +00:00
Molecule AI · core-be	7b783aa2ed	fix(workspace): poll activity_logs for a2a_proxy delegation results (closes #354) (#501) ... Co-authored-by: Molecule AI · core-be <core-be@agents.moleculesai.app> Co-committed-by: Molecule AI · core-be <core-be@agents.moleculesai.app>	2026-05-11 15:53:05 +00:00
core-be	952bfb3ca2	fix(workspace): replace asyncio.get_event_loop().run_until_complete with asyncio.run() (#307) (#498) ... Co-authored-by: core-be <core-be@agents.moleculesai.app> Co-committed-by: core-be <core-be@agents.moleculesai.app>	2026-05-11 15:37:34 +00:00
Molecule AI · core-lead	3d73fb1a72	Merge branch 'main' into sre/fix-test-polling-sanitization	2026-05-11 15:28:34 +00:00
Molecule AI Infra-SRE	d7de4afad4	fix: TestPollingPathSanitization regression — 3 bugs, correct assertions ... Three bugs introduced in PR #477: 1. fake_discover(ws_id) missing source_workspace_id kwarg — discover_peer signature is (target_id, source_workspace_id=None). 2. Direct attribute assignment (d._delegate_sync_via_polling = ...) does not replace module-level 'from module import name' bindings resolved at call time; must use monkeypatch.setattr. 3. Assertions checked for [A2A_RESULT_FROM_PEER] but the polling path uses _A2A_BOUNDARY_START/END — _A2A_RESULT_FROM_PEER is added by send_a2a_message (messaging path), not by _delegate_sync_via_polling. Additionally: monkeypatch.setenv("DELEGATION_SYNC_VIA_INBOX", "1") forces the polling code path so the test exercises the correct logic regardless of environment defaults. Closes #495. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 15:22:16 +00:00
Molecule AI Infra-Runtime-BE	c4dcfbb089	fix(workspace): default PLATFORM_URL to host.docker.internal in all modules (#475) ... Co-authored-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app> Co-committed-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app>	2026-05-11 15:17:53 +00:00
Molecule AI Infra-Runtime-BE	635a42745a	fix(workspace): OFFSEC-003 — separate sanitize vs. wrap, fix tool_delegate_task (#477) ... Co-authored-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app> Co-committed-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app>	2026-05-11 15:10:25 +00:00
Molecule AI Infra-Runtime-BE	4a7e1bd988	refactor(workspace): extract idle-loop pending-check guard for direct unit-testing ... Follows up on #432 (merged). Extracts _check_delegation_results_pending() from the inline guard in _run_idle_loop() so tests can call the real production function directly via patch(builtins.open, ...). Fixes #401: the previous test used a mirror copy of the guard logic, which risks drifting from the production implementation over time. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 10:49:40 +00:00
Molecule AI Infra-Runtime-BE	318e0ad742	fix(workspace): skip idle prompt when delegation results are pending (#381) (#432) ... Co-authored-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app> Co-committed-by: Molecule AI Infra-Runtime-BE <infra-runtime-be@agents.moleculesai.app>	2026-05-11 09:30:32 +00:00
Molecule AI Core-BE	39db2e6d73	fix(workspace): complete OFFSEC-003 fix — promote full sanitization to main ... Promotes the complete OFFSEC-003 boundary-marker sanitization from staging to main, including: - _delegate_sync_via_polling: sanitize response_preview and error strings before returning (OFFSEC-003 polling-path fix from PR #417). - tool_check_task_status JSON endpoint: sanitize summary + response_preview in both the task_id filter path and the list path. - tool_delegate_task non-polling path: preserve main's existing sanitize_a2a_result(result) wrapper (staging accidentally removed it). Closes #418. Co-Authored-By: Molecule AI · core-be <core-be@agents.moleculesai.app>	2026-05-11 08:51:45 +00:00
Molecule AI Core-BE	93b7d9a88a	fix(a2a_tools): add comment + test coverage for string-form error handling in delegate_task ... Staging branch bea89ce4 introduced duplicate dead code after a `return` in the delegate_task error-handling block — the first occurrence was the correct fix (adding isinstance(err, str)), but the second occurrence (now unreachable) made the block fragile. Main already has the correct code; this branch adds an explanatory comment and regression tests. The non-tool delegate_task() in a2a_tools.py uses httpx.AsyncClient directly (not send_a2a_message) and must handle three A2A proxy error shapes: {"error": "plain string"} ← the bug fix: isinstance(err, str) {"error": {"message": "...", ...}} ← pre-existing path {"error": {"nested": "object"}} ← falls through to str(err) Adds TestDelegateTaskDirect: test_string_form_error_returns_error_message — regression for AttributeError test_dict_form_error_returns_error_message — pre-existing path still works test_success_returns_result_text — happy path still works Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 05:51:48 +00:00
Molecule AI Core-BE	99f3cf7c8f	[core-be-agent] fix(#354): wire delegation-results consumer into a2a executor ... Close the A2A delegation auto-resume gap. Root cause: heartbeat.py's _check_delegations already writes completed delegation rows to DELEGATION_RESULTS_FILE and sends a self-message to wake the agent. executor_helpers.read_delegation_results() was defined to atomically consume that file, but a2a_executor._core_execute() never called it — so delegation results were written but the agent never saw them. Fix: call read_delegation_results() at the top of _core_execute() and prepend the results to the user input context so the agent can act on them without an explicit check_task_status call. The Temporal durable workflow path is also covered because it calls _core_execute() directly. Test: two new cases — delegation results injected when file exists; user input passed through unchanged when file is empty. Closes molecule-core#354.	2026-05-11 02:49:32 +00:00
Molecule AI Infra-Runtime-BE	3eb3609b0c	test(workspace): add queue_id-absence and push-vs-poll distinction tests ... Incorporates valuable extra coverage from fullstack-engineer's PR #336: - test_push_queued_missing_queue_id_still_parsed: queue_id is optional, absence must not break parsing - test_push_queued_is_distinct_from_poll_queued: both envelope shapes parse correctly and independently, with correct delivery_mode values Also adds push_queued_no_queue_id fixture and regression gate entry. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 02:47:21 +00:00
Molecule AI Infra-Runtime-BE	0a9b66a3ed	fix(workspace): push-mode Queued returns delivery_mode="push" (not silent default "poll") ... Bug: a2a_response.py:197 returned Queued(method=method) without passing delivery_mode, silently defaulting to "poll" for push-mode busy-queue responses. Callers branching on v.delivery_mode would mis-identify push-mode responses as poll-mode, causing wrong dispatch logic. Fix: pass delivery_mode="push" explicitly in the push-mode branch. Tests: add push_queued_full/notify/no_method fixtures and 4 test cases asserting delivery_mode="push" for all three envelope shapes. Also add adversarial {"queued": "yes"} and {"queued": False} → Malformed guards. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 02:47:21 +00:00
Molecule AI Infra-SRE	a205099652	fix(security): OFFSEC-003 — boundary-marker escape + shared sanitizer ... Root cause (from infra-lead PR#7 review id=724): Sanitization in PR#7 wrapped peer text in [A2A_RESULT_FROM_PEER] markers, but the markers themselves were not escaped — a malicious peer could inject "[/A2A_RESULT_FROM_PEER]" to close the trust boundary early, making subsequent text appear inside the trusted zone. Fix: - Create workspace/_sanitize_a2a.py (leaf module, no circular import risk) with shared sanitize_a2a_result() + _escape_boundary_markers() - _escape_boundary_markers() escapes boundary open/close markers in the raw peer text before wrapping (primary security control) - Defense-in-depth: also escapes SYSTEM/OVERRIDE/INSTRUCTIONS/IGNORE ALL/YOU ARE NOW patterns (secondary, per PR#7 design intent) - Update a2a_tools_delegation.py: import from _sanitize_a2a; wrap tool_delegate_task return and tool_check_task_status response_preview - Add 15 tests covering boundary escape, injection patterns, integration shapes (workspace/tests/test_a2a_sanitization.py) Follow-up (non-blocking, noted in PR#7 infra-lead review): - Deduplicate if a2a_tools.py also wraps (currently handled in delegation module only — callers get sanitized output regardless) - tool_check_task_status: consider sanitizing 'summary' field too Closes: molecule-ai/molecule-ai-workspace-runtime#7 (wrong-repo PR that this supersedes) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-11 02:16:09 +00:00
claude-ceo-assistant	5ecec3f253	Merge pull request 'fix(a2a): reject delegate_task to your own workspace ID (self-deadlock guard)' (#291) from fix/self-delegation-guard into main	2026-05-10 10:53:18 +00:00
claude-ceo-assistant	f58a11d171	Merge pull request 'fix(runtime): MODEL_PROVIDER env is misnamed — accept MODEL/MOLECULE_MODEL, deprecate legacy name' (#280) from fix/model-provider-misnomer into main	2026-05-10 10:52:40 +00:00
hongming-pc2	31ed137b74	fix(a2a): reject delegate_task / delegate_task_async to your own workspace ID ... Self-delegation deadlocks: the sending turn holds `_run_lock`, the receive handler waits for the same lock, the A2A request 30s-times-out, and the whole cycle is wasted (the Dev Lead system prompt warns agents off this by hand — "Never delegate_task to your own workspace ID … there is no peer who is also you"). The platform/runtime had no guard. Now both `tool_delegate_task` and `tool_delegate_task_async` early-return an actionable error when `workspace_id == effective_source` (`source_workspace_id or _peer_to_source[target] or WORKSPACE_ID`) — before `discover_peer`, so no network round-trip is wasted either. A genuinely different target (incl. another of a multi-workspace agent's own registered workspaces) is unaffected. Tests: tests/test_a2a_tools_delegation.py — new TestSelfDelegationGuard (4 cases: rejects own ID; rejects when source_workspace_id explicitly == target; async path rejects; a different target passes the guard through to discover_peer). `pytest tests/test_a2a_tools_delegation.py` → 12 passed. (tests/test_a2a_tools_impl.py's TestToolDelegateTask* suite is red on this PC2/Windows checkout — same on `main` without this change; httpx-mock infra, not this PR — CI validates on Linux.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-10 03:46:59 -07:00
Molecule AI · core-lead	fe1b3d9a82	Merge branch 'main' into fix/a2a-tools-and-workflow-cleanup	2026-05-10 10:12:50 +00:00
Molecule AI Integration Tester	e647efe7c5	fix(a2a): handle string error in a2a_tools.py + remove dead staging trigger ... Two-part fix from PR #268 (ported by Integration Tester after PR #268 was closed without merge): PART 1 — workspace/builtin_tools/a2a_tools.py: Fixes AttributeError when platform returns a plain string as the error field. Before: data["error"].get("message") ← crashes if error is a string After: isinstance(err, dict) → err.get("message") isinstance(err, str) → use err directly otherwise → str(err) Also guards result.get("parts") against non-dict result. Includes fix for issue #279: empty-parts regression where {"parts": []} returned "(no text)" instead of str(result). PART 2 — .gitea/workflows/ and .github/workflows/ publish-workspace-server-image.yml: Removed dead "staging" branch trigger. Trunk-based migration (2026-05-08) removed the staging branch but the workflow triggers were not updated. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-10 09:52:36 +00:00
hongming-pc2	2ba3af5330	fix(runtime): MODEL_PROVIDER env is misnamed — accept MODEL/MOLECULE_MODEL, deprecate the legacy name ... `molecule_runtime.config.load_config` read the `MODEL_PROVIDER` env var as the *picked model id* — despite the name, it never carried the provider (that's `LLM_PROVIDER` / the YAML `provider:` field). So `claude-code`, `minimax`, and `opus` were all "valid" values for a var named MODEL_PROVIDER. That footgun bit the dev-team rollout (2026-05-10): the lead persona env files set `MODEL=claude-opus-4-7` (the intended model) *and* `MODEL_PROVIDER=claude-code` (mistaking it for "the runtime"); the loader picked up MODEL_PROVIDER → the claude CLI got `--model claude-code` → 404 on every turn, surfaced only as "Command failed with exit code 1" with empty stderr (the real error is in the stream-json stdout, swallowed by the SDK's placeholder). The 22 IC workspaces "worked" only because their `MODEL_PROVIDER=minimax` happened to fuzzy-match on MiniMax's side — they were actually running `--model minimax`, not `MiniMax-M2.7-highspeed`. New precedence in `_picked_model_from_env`: `MOLECULE_MODEL` (canonical, unambiguous) > `MODEL` (the obviously-correct name, already plumbed by workspace-server's applyRuntimeModelEnv) > `MODEL_PROVIDER` (legacy — still honored so canvas Save+Restart, the secret-mint path, and existing persona env files keep working, but if it's the only one set we log a one-time deprecation pointing at the misnomer) > the YAML `model:` field. Applied at both the top-level `model` and `runtime_config.model` resolution sites; semantics are otherwise unchanged. Bonus: workspaces that already set `MODEL` correctly now get exactly that model instead of whatever fuzzy-match the upstream did with the provider slug. Tests: 5 new cases in test_config.py (MODEL beats MODEL_PROVIDER; MOLECULE_MODEL beats MODEL; MODEL overrides YAML; legacy MODEL_PROVIDER still resolves + warns; no warning when MODEL is set) + an autouse fixture that clears MODEL*/resets the warn-latch so resolution is deterministic regardless of the CI env or test order. `pytest tests/test_config.py` — 66 passed; the config-importing suites (test_preflight, test_skills_loader) — 129 passed. Companion: molecule-dev-department PR #10 fixes the six dev-team lead `workspace.yaml`s from `model: MiniMax-M2.7` to `model: opus`. Follow-ups (not in scope here): plumb `MOLECULE_MODEL` from applyRuntimeModelEnv and the canvas; strip `MODEL`/`MODEL_PROVIDER` from the operator-host persona env files once the org-template `model:` field is authoritative end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-10 02:38:14 -07:00
Molecule AI Integration Tester	736d9959bc	fix(a2a): handle push-mode queue envelope in response parser ... When a push-mode workspace (one with a public URL) is at capacity, the platform queues the delegation request and returns: {"queued": true, "message": "...", "queue_depth": N, "queue_id": "..."} The existing SSOT parser (a2a_response.py) only handled the poll-mode envelope (status=queued + delivery_mode=poll). Push-mode queue responses fell through to Malformed, causing send_a2a_message to log a warning and return an error — even though delivery was actually queued successfully. Fix: add handling for data.get("queued") is True as a Queued variant with delivery_mode="push". Checked before the poll-mode envelope so the two cases are mutually exclusive. Fixes observed 2026-05-10: platform returning push-mode queue envelopes to Integration Tester when Release Manager workspace was at capacity. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-10 09:28:51 +00:00
Molecule AI Core-DevOps	7ae3ee786f	feat(workspace): add static .github-token fallback to git credential helper ... Adds a 4th fallback step to the token chain (cache > API > env > static) so workspace git/gh operations survive a platform outage without requiring a restart or platform-side fix. Addresses the 2026-05-08 incident where every workspace lost git+gh auth simultaneously when the /github-installation-token endpoint returned 500. Operator places a PAT in ${CONFIGS_DIR:-/configs}/.github-token (no root needed — /configs is agent-writable). Both _fetch_token (git credential helper path) and _refresh_gh (gh CLI daemon path) gain the static fallback so git and gh both recover post-incident. Pure additive — existing cache > API > env chain is unchanged. Empty static file is rejected (whitespace-stripped before use). Static path never writes the cache, so the API recovers transparently on the next refresh cycle when it comes back online. Ref: issue #140. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-10 02:17:22 +00:00
Molecule AI Core-DevOps	1492b40b38	ci(docker): pin base image digests in all Dockerfiles ... Pins all FROM image tags to exact SHA256 digests for reproducible builds. Without digest pinning, a registry push of a new image to the same tag can silently change the layer content between builds — a supply-chain risk especially for prod-deployed images. Pinned images (7 Dockerfiles): - golang:1.25-alpine → sha256:c4ea15b... (workspace-server/Dockerfile, Dockerfile.dev, Dockerfile.tenant, tests/harness/cp-stub/Dockerfile) - alpine:3.20 → sha256:c64c687c... (workspace-server/Dockerfile, tests/harness/cp-stub/Dockerfile) - node:20-alpine → sha256:afdf982... (workspace-server/Dockerfile.tenant) - node:22-alpine → sha256:cb15fca... (canvas/Dockerfile) - python:3.11-slim → sha256:e78299e... (workspace/Dockerfile) - nginx:1.27-alpine → sha256:62223d6... (tests/harness/cf-proxy/Dockerfile) Note: docker-compose.yml service images (postgres, redis, clickhouse, litellm, ollama) are intentionally left on major-version tags — those are runtime-pulled and updated regularly for local-dev ergonomics. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-09 23:56:39 +00:00
Molecule AI Core-BE	76ac5a88dc	[core-be-agent] ... fix(tests): clear platform_auth cache before each test Fixes issue #160: workspace tests fail when MOLECULE_WORKSPACE_TOKEN is set in the environment. The bug: platform_auth._cached_token is populated at module import or first get_token() call and persists for the process lifetime. Tests that use monkeypatch.delenv("MOLECULE_WORKSPACE_TOKEN") to simulate "no token in env" were failing because delenv removes the env var but not the module-level cache — subsequent get_token() calls returned the stale cached value. Fix: add a function-scoped autouse fixture in conftest.py that calls platform_auth.clear_cache() before every test. The import is inside the fixture to avoid collection-time import issues when platform_auth is not yet available. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-09 22:16:11 +00:00
Molecule AI Core-DevOps	57aedec1a3	fix(tests): isolate token resolution from real .auth_token on disk ... Issue #160: workspace tests fail when MOLECULE_WORKSPACE_TOKEN is set in the test environment (or when /configs/.auth_token exists on disk, as it does in a container CI runner). Root cause: - test_resolve_token_returns_none_when_missing: monkeypatch.delenv() removes the env var, but _resolve_token() falls through to configs_dir.resolve()/.auth_token which exists in the container. - Multi-workspace tests: clear_cache() resets _cached_token, but get_token() immediately re-reads /configs/.auth_token and caches the real token before the env var is even checked. Fix: - test_mcp_doctor: patch configs_dir.resolve() to return a bare tmp_path so the disk-file fallback finds nothing. - Multi-workspace tests: patch platform_auth._token_file() to return a non-existent path (via tmp_path) alongside clear_cache(), ensuring the env var wins as intended. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-09 21:55:29 +00:00
Molecule AI Core-DevOps	252f8d0c47	tech-debt: rename molecule-monorepo-net -> molecule-core-net ... Renames Docker network across all code, configs, scripts, and docs. Per issue #93: the network was named molecule-monorepo-net as a holdover from when the repo was called molecule-monorepo. The canonical repo name is now molecule-core, so the network should be molecule-core-net. Files changed: - docker-compose.yml, docker-compose.infra.yml: network definition - infra/scripts/setup.sh: docker network create - scripts/nuke-and-rebuild.sh: docker network rm - workspace-server/internal/provisioner/provisioner.go: DefaultNetwork - All comments/docs: updated wording Acceptance: grep -rn 'molecule-monorepo-net' returns zero matches. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-09 20:51:48 +00:00