5 Commits

Author	SHA1	Message	Date
orchestrator	a4fc04189c	fix(workspace): set git user.name/email from $GITEA_USER at boot ... Closes #155. Without this, every commit from a workspace booted via the standard provisioner lands with an empty `user.name`/`user.email` and Gitea attributes the work to whichever PAT pushed (typically the founder's `claude-ceo-assistant`), instead of the persona that actually authored the commit. That's the same fingerprint pattern that got us suspended on GitHub 2026-05-06. GITEA_USER is already injected per-workspace by the provisioner from workspace_secrets (verified: 8/8 Core-* workspaces have it set, correctly-named, on operator + local). Boot picks it up unconditionally; falls through cleanly if unset (e.g. legacy boxes without persona identity wiring). Email uses `bot.moleculesai.app` so agent commits are visually distinct from human-authored commits in Gitea history. The `gitconfig` copy from `/root/.gitconfig` to `/home/agent/.gitconfig` is now unconditional — previously it was nested inside the `molecule-git-token-helper.sh` block, which meant the per-persona identity wouldn't propagate to the agent user when the helper was unavailable. Also added an inline note that the github.com credential-helper block is post-suspension legacy. Full removal tracked under #171; this PR deliberately doesn't touch it (smaller blast radius). Tested: docker exec sets the same config in 8 running Core-* workspaces locally and they pick up correct identity for `git config -l`. Will reset when those containers restart, hence this PR for the persistent fix.	2026-05-09 12:52:17 -07:00
Hongming Wang	925a71887d	fix(workspace): credential helper security hardening (#1797) ... Four findings from security audit (internal/security/credential-token-backlog.md): 1. STDERR LEAK — molecule-git-token-helper.sh:146,153 logged ${response} on platform errors. The response body MAY contain the token in some failure modes (alternate JSON key shape on partial success). Now: - capture curl's stderr to a tmp file (not $response) so we can log the curl error message without ever interpolating the response body - on empty-token branch, log only response size (bytes) for debug 2. CHMOD 600 — already in place at lines 116, 124, 223 (verified, no change) 3. RESPAWN SUPERVISION — entrypoint.sh wrapped daemon launch in a while-true bash loop with 30s back-off. Without this, a daemon crash silently leaves the workspace stuck on an expired token until the container restarts. Logs to /home/agent/.gh-token-refresh.log (agent-writable; /var/log is root-owned). 4. JITTER — molecule-gh-token-refresh.sh: added 0..120s random offset to each sleep so 39 containers don't synchronize their refresh requests against the platform endpoint. Also: - Daemon now sends helper output to /dev/null instead of merging stderr, belt-and-suspenders against any future helper change that might write the token to stdout. - Daemon log lines include rc=$? on failure for actionable triage. Inherent risks (org-wide token blast, prompt-injection theft, bearer in volume, no audit log) tracked in internal/security/credential-token-backlog.md as separate roadmap items. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: molecule-ai[bot] <276602405+molecule-ai[bot]@users.noreply.github.com>	2026-04-23 18:14:55 +00:00
Hongming Wang	2885583d05	feat(workspace): 45-min gh-token refresh daemon + credential helper cache ... Extracted from the now-closed PR #1664 (Molecule-AI/molecule-core). - New scripts/molecule-gh-token-refresh.sh background daemon — every 45 min (TOKEN_REFRESH_INTERVAL_SEC) calls the credential helper's _refresh_gh action to keep both gh CLI auth and the on-disk cache fresh through the GitHub App installation token's ~60 min TTL. - scripts/molecule-git-token-helper.sh rewritten with a ~50 min on-disk cache (${CACHE_DIR}/gh_installation_token + _expiry companion file), a cache > API > env-var fallback chain, a new _refresh_gh action (invoked by the daemon above), a _invalidate_cache action, and path references flipped from /workspace/scripts/... to /app/scripts/... to match the runtime image layout. - Dockerfile copies the new refresh daemon and extends mkdir to create /home/agent/.molecule-token-cache at build time. - entrypoint.sh configures the git credential helper for github.com while still root (so the global gitconfig is written before the gosu handoff), creates + chowns the token cache dir, then as agent starts the refresh daemon in the background and does an initial gh auth login from GITHUB_TOKEN/GH_TOKEN so gh works before the first refresh fires. Dropped from PR #1664: cosmetic em-dash -> ASCII hyphen rewrites (charset-normalizer noise) that would conflict with the repo's existing em-dash convention used elsewhere in workspace/.	2026-04-22 19:52:46 -07:00
Hongming Wang	37ed319562	fix: update workspace script comments for workspace-template → workspace rename ... Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-18 01:48:05 -07:00
Hongming Wang	d8026347e5	chore: open-source restructure — rename dirs, remove internal files, scrub secrets ... Renames: - platform/ → workspace-server/ (Go module path stays as "platform" for external dep compat — will update after plugin module republish) - workspace-template/ → workspace/ Removed (moved to separate repos or deleted): - PLAN.md — internal roadmap (move to private project board) - HANDOFF.md, AGENTS.md — one-time internal session docs - .claude/ — gitignored entirely (local agent config) - infra/cloudflare-worker/ → Molecule-AI/molecule-tenant-proxy - org-templates/molecule-dev/ → standalone template repo - .mcp-eval/ → molecule-mcp-server repo - test-results/ — ephemeral, gitignored Security scrubbing: - Cloudflare account/zone/KV IDs → placeholders - Real EC2 IPs → <EC2_IP> in all docs - CF token prefix, Neon project ID, Fly app names → redacted - Langfuse dev credentials → parameterized - Personal runner username/machine name → generic Community files: - CONTRIBUTING.md — build, test, branch conventions - CODE_OF_CONDUCT.md — Contributor Covenant 2.1 All Dockerfiles, CI workflows, docker-compose, railway.toml, render.yaml, README, CLAUDE.md updated for new directory names. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-18 00:24:44 -07:00