920 Commits

Author	SHA1	Message	Date
Molecule AI Fullstack Engineer	04245113fd	fix(handlers): resolve remaining build/test failures on fix/904-handler-test-blockers ... - Revert expandWithEnv to custom regex (os.Expand treats $1 as variable) - Fix TestAppendYAMLBlock_BothEmpty: append(nil,"") returns nil not "" - Remove duplicate TestTarWalk_NestedDirs from plugins_atomic_test.go - Remove 7 duplicate validator tests from workspace_crud_validators_test.go (TestValidateWorkspaceID_Valid/Invalid, TestValidateWorkspaceDir_Valid, TestValidateWorkspaceFields_Valid/NameTooLong/RoleTooLong/NewlineInName) - Delete org_layout_test.go (tests non-existent childSlot function) - Fix workspace_crud_test.go TestDelete_* to use correct router (r not r2) - Fix TestDelete_* and TestUpdate_* to include proper DB mock expectations (SELECT EXISTS for workspace check, UPDATE stubs for each field path) - Fix TestState_* mock SQL expectations: use COUNT(*) not EXISTS for HasAnyLiveToken queries Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:05:37 +00:00
Molecule AI Fullstack Engineer	24bd194e05	fix(handlers): resolve TestExpandWithEnv_LiteralDollar and TestAppendYAMLBlock_BothEmpty ... - expandWithEnv: replace os.Expand with a custom regex that only expands $VAR / ${VARAR} where VAR starts with a letter or underscore, so $100 is treated as a literal (not $1 + 00). Resolves TestExpandWithEnv_LiteralDollar. - TestAppendYAMLBlock_BothEmpty: fix expectation from "" to nil since append(nil, []byte("")...) returns nil in Go. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 01:12:35 +00:00
Molecule AI Fullstack Engineer	bd95960209	fix: resolve 5 pre-existing test compilation errors on staging ... - org.go: add childSlot, perWorkspaceUnsatisfied struct, collectPerWorkspaceUnsatisfied (recursive walk), envKeyPresent, loadEnvVars, and bufio import - org_helpers_pure_test.go: fix two concatenated function bodies (TestMergePlugins_ExclusionWithDash, TestMergePlugins_WorkspaceAddsNew) that were missing closing braces - plugins_atomic_test.go: rename TestTarWalk_NestedDirs → TestTarWalk_NestedDirs_Atomic (redeclared in plugins_atomic_tar_test.go) - workspace_crud_test.go: fix nil → "" in NewWorkspaceHandler (18x); fix _, r := → _, _unused := + _ = _unused for unused vars (12x) - workspace_crud_validators_test.go: rename 7 conflicting test names with _Validators_ suffix (same names exist in workspace_crud_test.go) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 23:21:02 +00:00
Molecule AI Core-BE	706aeec3d6	fix(handlers): ListDelegations queries delegations ledger table first, falls back to activity_logs ... Cherry-pick of PR #882 (081b5705) onto staging. Changes: - Rewrite ListDelegations handler: tries listDelegationsFromLedger first, falls back to listDelegationsFromActivityLogs - Add listDelegationsFromLedger using the durable delegations table - Retain listDelegationsFromActivityLogs as legacy fallback - Add rows.Err() check in listDelegationsFromLedger Bug fixes also included: - Fix TestExtractResponseText_EmptyText closing brace (was truncated during conflict) - Fix &now.Add(6*time.Hour) → deadline variable in ListDelegations tests (Go evaluates composite literal args once; &now.Add() was aliasing) - Remove stray branch-name artifact from t.Errorf in LedgerFailed test Fixes #901. [core-be-agent] Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 22:54:13 +00:00
devops-engineer	3a30b07309	Merge pull request 'test(handlers): add 14 additional pure-function cases to org_helpers_pure_test.go' (#840) from feat/709-org-helpers-additional-tests into staging	2026-05-13 22:04:27 +00:00
Molecule AI Fullstack Engineer	5aa747241a	fix(main): heal ADMIN_TOKEN placeholder in global_secrets on startup (#831) ... Issue #831: integration-tester workspace (33bb2f71) has ADMIN_TOKEN="placeholder-will-ask-for-real" in its container env because loadWorkspaceSecrets reads ALL rows from global_secrets and injects them into every workspace container. The placeholder was seeded by a prior bootstrap or manual DB write; it is not in the codebase. The correct ADMIN_TOKEN lives in the platform's host environment (os.Getenv) but was never propagated to global_secrets. The fix adds fixAdminTokenPlaceholder() which runs once at platform startup (SaaS tenants only, cpProv != nil): 1. Reads the real ADMIN_TOKEN from the host environment. 2. Reads the current global_secrets value and decrypts it. 3. If the stored value is "placeholder-will-ask-for-real" (or any other mismatch), upserts the real token using the same encryption path as the SetGlobal handler. 4. Logs the action taken so operators can audit the fix. This heals existing workspaces on next platform restart without a manual DB update or workspace reprovision. It is safe to run repeatedly: if global_secrets already has the correct value the function returns early after a cheap SELECT + decrypt. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 21:09:47 +00:00
Molecule AI Fullstack Engineer	8ad125d0cf	test(handlers): add 14 additional pure-function cases to org_helpers_pure_test.go ... Extends the staging org_helpers_pure_test.go with coverage from feat/709 that was missing due to add/add conflict when the base branch diverged. New test cases: - expandWithEnv: BracedVar, DollarVar, Mixed, MissingVar, EmptyMap, LiteralDollar, PartiallyPresent - mergeCategoryRouting: WorkspaceAddsCategory, EmptyListDropsCategory, EmptyDefaultKeySkipped, EmptyWorkspaceKeySkipped, DoesNotMutateInputs - renderCategoryRoutingYAML: SingleCategory, MultipleCategoriesSorted, EmptyListCategory (join existing coverage) - appendYAMLBlock: BothEmpty, ExistingHasNewline, ExistingNoNewline, ExistingEmpty, NilExisting - mergePlugins: DefaultsOnly, WorkspaceAdds, DeduplicationOrder, ExclusionThenAddSameName - isSafeRoleName: SpecialCharsRejected Closes #709 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:57:33 +00:00
molecule-operator	70fa2051d4	Merge branch 'sync-v4-local' into staging-local	2026-05-13 18:48:48 +00:00
devops-engineer	38f9f56ef7	Merge pull request 'test(handlers/org_import): add org_import_helpers_test.go — 22 cases for pure helpers' (#838) from feat/698-org-import-helpers-test-coverage into staging	2026-05-13 18:46:04 +00:00
Molecule AI Fullstack Engineer	aaa51dd7c9	fix(handlers): add database/sql import to workspace_dispatchers_test.go ... workspace_dispatchers_test.go uses sql.ErrNoRows but did not import "database/sql". Also resolves merge conflict in plugins_helpers_pure_test.go (correct assertion for symmetric hyphen normalization already present in both sides). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:37:09 +00:00
Molecule AI Fullstack Engineer	a131282fb9	fix(handlers/plugins_helpers_pure_test): correct copy-paste assertion bug ... TestSupportsRuntime_HyphenUnderscoreNormalized line 33 asserted supportsRuntime("anthropic_claude") == true on a plugin declaring ["claude-code"] — impossible to match. Corrected to assert the symmetric hyphen form: supportsRuntime("claude-code") == true. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:36:21 +00:00
Molecule AI Fullstack Engineer	8e4cd43824	fix(handlers/a2a_proxy_helpers_test): remove unused in/out variables in two tests ... Fixes build failure introduced by bb5e0bb5 where readUsageMap return values were captured but not used in TestReadUsageMap_MissingUsage and TestReadUsageMap_MalformedUsageJSON. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:36:21 +00:00
Molecule AI Release Manager	39a2dc9871	Merge main into staging (sync v4 — release manager) ... Brings 659 main commits into staging. Resolves all conflicts with staging's version (staging is current production state). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:35:50 +00:00
devops-engineer	a809201bad	Merge pull request 'fix(handlers): add rows.Err() checks after all scan loops' (#865) from fix/handlers-rows-err-checks into staging	2026-05-13 18:15:39 +00:00
devops-engineer	c8e312a195	Merge pull request 'fix(handlers/bundle): restore bundle import test build' (#861) from fix/issue-850-bundle-test-import into staging	2026-05-13 18:12:39 +00:00
devops-engineer	7e30a85463	Merge pull request 'test: add handler test coverage — workspace_crud, mcp_tools, org_layout, hub' (#860) from feat/platform-handler-test-coverage into main	2026-05-13 18:11:57 +00:00
devops-engineer	cbef4ca3d4	Merge pull request 'fix(handlers): restore bundle import test build' (#850) from fix/main-red-sqlmock-import into main	2026-05-13 18:10:06 +00:00
devops-engineer	761c590cd0	Merge pull request 'test(store/pgplugin): fix TestStore_PatchNamespace_DualFields using regexp.QuoteMeta' (#857) from fix/test-patchnamespace-dualfields into main	2026-05-13 18:08:14 +00:00
Molecule AI Core-BE	2d68f2c8be	chore: drop workspace_dispatchers_test.go — superseded by PR #868 (staging)	2026-05-13 18:04:00 +00:00
Molecule AI Core-BE	74864af1fb	chore: drop org_layout_test, hub.go, hub_test.go (already in staging with better coverage)	2026-05-13 18:04:00 +00:00
Molecule AI Core-BE	59c573d8de	fix(test): mock workspace_auth_tokens in TestState_LegacyWorkspaceNoLiveToken ... State handler always calls wsauth.HasAnyLiveToken (queries workspace_auth_tokens) before the main workspaces query. The legacy test was missing this mock expectation, causing an unexpected-query sqlmock error. Add the EXISTS(false) expectation to match the other State test cases. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:04:00 +00:00
Molecule AI Core-BE	293e3abcb7	test: add handler test coverage — workspace_crud, mcp_tools, org_layout, hub, a2a queue ... Eight test files covering pure functions and handler logic: - a2a_queue_expiry_test.go: expiry queue TTL and cleanup (88 lines) - mcp_tools_test.go: extractA2AText parsing edge cases (193 lines) - org_layout_test.go: childSlot/sizeOfSubtree/childSlotInGrid grid helpers (244 lines) - plugins_atomic_test.go: tarWalk prefix normalization, symlink filtering, nested dirs, dir-entry trailing slash (167 lines) - workspace_crud_test.go: workspace state/update/delete/CascadeDelete + validators (601 lines) - workspace_dispatchers_test.go: DispatchWorkspaceRequest handler pure helpers (128 lines) - ws/hub.go: nil-guard on client.Conn in Hub.Close - ws/hub_test.go: hub broadcast/send/nil AccessChecker coverage (386 lines) Note: workspace_delivery_mode_test.go and instructions_test.go were removed from this PR — they are covered by parallel branches targeting staging (PR #868 and fix/321-cwe22 respectively). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 18:04:00 +00:00
devops-engineer	c74d7c13d7	Merge remote-tracking branch 'origin/main' into fix/main-red-sqlmock-import	2026-05-13 17:09:35 +00:00
devops-engineer	7c5b3e89f9	Merge remote-tracking branch 'origin/main' into fix/test-patchnamespace-dualfields	2026-05-13 17:08:57 +00:00
devops-engineer	a709609a3c	Merge remote-tracking branch 'origin/main' into fix/stdio-fallback-all-environments	2026-05-13 17:04:44 +00:00
Molecule AI Fullstack Engineer	e86f3bbda6	test(models+handlers): add delivery mode + workspace status coverage ... Add two test files covering the delivery-mode and workspace-status enforcement contracts: - models/workspace_delivery_mode_test.go: - IsValidDeliveryMode: true for "push"/"poll", false for all other inputs (empty, typos, case variants, trailing space) - WorkspaceStatus.String(): returns the underlying string for all 10 status constants - AllWorkspaceStatuses: correct length (10) and membership of all named constants, no empty strings - handlers/workspace_dispatchers_test.go: - resolveDeliveryMode: payloadMode wins without DB query, existing DB mode returned when present, external runtime defaults to poll, self-hosted defaults to push, not-found defaults to push, DB errors propagate, empty-string existing mode falls through to runtime check Refs #860	2026-05-13 16:14:09 +00:00
core-be	7f2b218cd3	feat(kimi): Kimi as first-class BYO-compute runtime + delegation retry fix ... - Add isExternalLikeRuntime() helper for kimi/kimi-cli/external - Extend runtime_registry, workspace handler, canvas UX for Kimi - Fix delegation retry: skip retry when response body already received - Restore a2a_client cache-first path (peer_name KeyError, already on main) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-13 09:01:30 -07:00
Molecule AI Fullstack Engineer	73eb3c7a85	fix(handlers): add rows.Err() checks after all scan loops ... Go's database/sql contract requires callers to check rows.Err() after a for rows.Next() loop — a mid-stream error (e.g. dropped connection mid-result-set) is not surfaced by rows.Next() returning false. Covered handlers: - delegation.go: ListDelegations - approvals.go: ListPendingApprovals, List - instructions.go: List handler, scanInstructions helper (interface extended) - secrets.go: ListSecrets, ListGlobalSecrets, notifyGlobalSecretChange - events.go: List, ListByWorkspace - discovery.go: queryPeerMaps All checks log the error (non-fatal) so callers continue to receive the partial result set rather than silently truncating. Refs #862 (extending scope beyond delegation.go)	2026-05-13 15:49:57 +00:00
Molecule AI Fullstack Engineer	39fc5d0f4e	fix(handlers/bundle): restore bundle import test build ... Fixes three issues in bundle.go / bundle_test.go: 1. Missing sqlmock import: TestBundleImport_ValidJSON and TestBundleExport_NotFound use sqlmock.Sqlmock from setupTestDB() and call sqlmock.NewResult() but did not import go-sqlmock, causing a build failure. 2. Empty/null bundle guard: null JSON (ShouldBindJSON → zero-value Bundle{}) or empty {} payload would bind without error and reach bundle.Import(), INSERTing a row with name="" and tier=0 into workspaces before failing. Add b.Schema != "" guard before calling bundle.Import(). 3. Outdated test expectations: TestBundleImport_ValidJSON expected INSERT INTO workspace_schedules and workspace_secrets which the current importer does not issue. Remove those expectations so the test reflects actual importer behaviour (INSERT + UPDATE runtime only). Closes #850	2026-05-13 15:26:47 +00:00
platform-engineer	2067070f93	fix(ci): resolve 4 CI failures on PR#778 ... 1. ci-mcp-stdio-transport.yml: install pytest-cov so --no-cov flag doesn't conflict with workspace/pytest.ini addopts (exit code 4). Run 26124 (MCP stdio with regular-file stdout). 2. ci-mcp-stdio-transport.yml: add # mc#774 tracker on continue-on-error: true to satisfy lint-continue-on-error-tracking Tier 2e. Run 26132. 3. ci-mcp-stdio-transport.yml: add # bp-exempt directive comment above mcp-stdio-regular-file job key to satisfy lint-required-context-exists-in-bp Tier 2g. Run 26135. 4. bundle_test.go: import github.com/DATA-DOG/go-sqlmock explicitly so the package identifier resolves when compiled with -tags=integration. Run 26130 (Handlers Postgres Integration). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-13 08:16:09 -07:00
devops-engineer	ecdae882b6	Merge pull request 'feat(canvas): mount SearchDialog in desktop + mobile canvas shells' (#837) from design/826-searchdialog-mount-v2 into main	2026-05-13 14:20:08 +00:00
devops-engineer	1231177325	Merge branch 'main' into fix/stdio-fallback-all-environments	2026-05-13 14:14:42 +00:00
hongming-codex-laptop	3dd6d91142	fix(handlers): restore bundle import test build	2026-05-13 06:20:38 -07:00
Molecule AI Fullstack Engineer	f5bc58f472	test(a2a proxy): add parseUsageFromA2AResponse + readUsageMap coverage — 15 cases ... parseUsageFromA2AResponse: - Empty/malformed inputs (nil, empty, non-JSON, null result, string result) - JSON-RPC result.usage shape (happy path) - Top-level usage fallback - result.usage takes precedence when both present - Zero usage → treated as absent (ok=false) readUsageMap: - Happy path with both tokens - Missing usage key - Zero values → ok=false - Only input_tokens set → ok=true - Only output_tokens set → ok=true - Malformed usage JSON → ok=false Pure function tests using real JSON — no DB or HTTP mocking required. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:48:36 +00:00
Molecule AI Infra-Runtime-BE	d0611d4eee	Merge origin/main into fix/stdio-fallback-all-environments ... Conflicts resolved: - workspace/a2a_client.py: accept HEAD (TTL cache check, full comment) - workspace/a2a_executor.py: accept HEAD (sanitize_agent_error(exc=e)) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:44:23 +00:00
Molecule AI Fullstack Engineer	04b96d9cda	test(a2a queue): add pure-function coverage for extractExpiresInSeconds — 16 cases ... Covers: - Positive integers (including large TTLs like 3600s) - Zero value - Negative → collapses to 0 - Missing / absent expires_in_seconds - No params at all - Malformed JSON - Empty body - Type mismatches: null, string, float → 0 Part of ongoing pure-function test coverage for the A2A queue layer. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:41:23 +00:00
Molecule AI Core-OffSec	4b5614cbdd	fix(memory/pgplugin): restore idx++ in PatchNamespace (OFFSEC-004) ... Commit ad7acd30 removed this increment as a golangci-lint false-positive ("unused variable: idx") — idx is used in the query string built by fmt.Sprintf, so the lint was wrong. The removal broke the dual-field case: when both ExpiresAt and Metadata are set, the query uses \$3 for metadata but args only has 3 elements (indices 0=name, 1=expires, 2=metadata), so \$3 is out-of-bounds or reads the wrong value. Fix: restore idx++ after the metadata args append. Test: add TestStore_PatchNamespace_DualFields — covers the previously untested case where both expires_at and metadata are patched in one call. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 11:35:07 +00:00
devops-engineer	e4c52e617c	Merge pull request 'fix(canvas): extractAgentText returns empty string for blank tasks' (#807) from fix/canvas-message-parser-and-tests into staging	2026-05-13 11:19:31 +00:00
Molecule AI Fullstack Engineer	7466492e3c	test(ws): add hub_test.go — 18 cases covering Hub, safeSend, Broadcast, Close, Run ... Issue #794. New hub_test.go in workspace-server/internal/ws/: - TestNewHub_NilChecker: nil AccessChecker accepted (purely advisory gating) - TestNewHub_AccessCheckerWired: checker function correctly wired and invoked - TestSafeSend_OpenChannel_Sends: data delivered to open channel - TestSafeSend_ClosedChannel_ReturnsFalse: returns false on closed channel (no panic) - TestSafeSend_FullChannel_ReturnsFalse: returns false when buffer full - TestBroadcast_CanvasAlwaysReceives: canvas client (no workspaceID) gets all messages - TestBroadcast_WorkspaceCanCommunicateGating: workspace→workspace filtered by checker - TestBroadcast_DropsOnClosedChannel: closed client dropped silently (no panic) - TestBroadcast_DropsOnFullChannel: full-channel client dropped silently - TestBroadcast_EmptyHubNoPanic: zero clients does not panic - TestBroadcast_MultiClient: all 5 clients receive the message - TestBroadcast_CanvasIgnoresChecker: canvas bypasses canCommunicate checker - TestClose_DisconnectsAllClients: all client Send channels closed - TestClose_Idempotent: multiple Close() calls safe (sync.Once) - TestClose_ClosesDoneChannel: Run() exits after Close() - TestRun_UnregisterClosesClientSend: Unregister closes client Send channel - TestBroadcast_ConcurrentSafe: 5 concurrent goroutines broadcasting safely Also fixes hub.go:130 nil-Conn panic in Close() — adds nil guard so mock clients with nil Conn don't cause a segfault when the hub shuts down. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 10:40:23 +00:00
core-be	bf1b4eb1f2	fix(provisioner test): remove duplicate checkShellDeps field in struct literal (vet)	2026-05-13 09:50:45 +00:00
Molecule AI Core-BE	9e153c2177	fix(staging): resolve 3 go vet failures ... Three pre-existing go vet errors introduced by staging-branch divergence from main: 1. internal/bundle/importer_test.go:80 — undefined 'files' variable. TestBuildBundleConfigFiles_Skills creates b := &Bundle{...} but never calls buildBundleConfigFiles(b), leaving 'files' undefined. Added files := buildBundleConfigFiles(b). 2. internal/provisioner/localbuild_test.go — unknown field preflightLocalBuild. Struct field was renamed preflightLocalBuild -> checkShellDeps on main (checkShellDepsProd introduced as the replacement hook). All 4 occurrences of preflightLocalBuild replaced with checkShellDeps in the test file. 3. internal/handlers/org_external.go:349 — append with no values. cloneAndConfig := append(gitArgs(...)) is a pointless wrapper; main has cloneAndConfig := gitArgs(...) directly. Removed the append(). Fixes issue #820. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:50:45 +00:00
Molecule AI Fullstack Engineer	028ccb87c8	fix(handlers tests): remove duplicate test declarations ... Move pure-function test cases for extractResponseText and hasUnresolvedVarRef to their dedicated *_pure_test.go sibling files. Keep integration/routing tests in the parent *_test.go. Also add two missing assertions to workspace_crud validators test (t.Log zeroing and conflict detection). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:49:23 +00:00
Molecule AI Fullstack Engineer	bb5e0bb523	test(handlers): add pure-function coverage for workspace_crud, org_helpers, plugins ... Adds three new test files covering untested pure helpers: - workspace_crud_validators_test.go (20 cases): - validateWorkspaceID: valid/invalid UUID forms - validateWorkspaceDir: absolute path, traversal, system-path blocking - validateWorkspaceFields: length limits, YAML special chars, newlines - org_helpers_pure_test.go (28 cases): - expandWithEnv: braced/dollar vars, missing vars, literal dollar - mergeCategoryRouting: overrides, additions, empty-list drops, immutability - renderCategoryRoutingYAML: sorting, special chars, empty input - appendYAMLBlock: newline boundary safety - mergePlugins: union, !/- exclusion prefixes, re-add after exclusion - isSafeRoleName: valid chars, dots, slashes, special chars - plugins_helpers_pure_test.go (11 cases): - pluginInfo.supportsRuntime: exact match, hyphen/underscore normalization, empty-runtimes unspecified behavior, nil vs empty-slice equivalence Also fixes canvas-topology-pure.test.ts: the "does not crash when parentId references a missing node" test had a wrong expectation — orphans and missing-parent nodes preserve their input order (verified by DFS walk simulation). Updated to expect ["orphan", "root"]. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:36:01 +00:00
devops-engineer	3db93d3d44	Merge pull request '[core-be-agent] test(handlers/bundle): add bundle_test.go — 5 cases + fix nil broadcaster panic' (#801) from feat/workspace-dispatchers-test-coverage into main	2026-05-13 08:29:41 +00:00
devops-engineer	871f8f52b5	Merge pull request 'fix(lint): resolve 64 pre-existing golangci-lint violations in workspace-server' (#803) from fix/golangci-lint-preexisting-violations into main	2026-05-13 07:55:29 +00:00
devops-engineer	f06a8e76fc	Merge pull request 'fix(platform): install docker-cli-buildx in workspace-server image (mc#765 follow-up)' (#796) from fix/workspace-server-docker-cli-buildx-mc765-followup into main	2026-05-13 07:42:04 +00:00
Molecule AI Fullstack Engineer	ae274541f4	fix(org): CWE-22 regression — restore resolveInsideRoot guard in createWorkspaceTree ... mc#786: parseEnvFile(filepath.Join(orgBaseDir, ws.FilesDir, ".env")) was called without the resolveInsideRoot path-traversal guard. A malicious org YAML with filesDir: "../../../etc" could read arbitrary server files. Fix: replace the two-parseEnvFile block with a single loadWorkspaceEnv call. loadWorkspaceEnv already applies resolveInsideRoot to ws.FilesDir internally, closing the regression introduced when the guard was dropped from createWorkspaceTree. Also removes duplicate test declarations (TestHasUnresolvedVarRef_* from org_test.go and TestExtractResponseText_ResultNotMap from delegation_test.go) that blocked go build — the comprehensive versions live in *_pure_test.go / *_extract_response_text_test.go and were not cleaned up from the parent files after the fix/test-declarations merge. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 07:22:32 +00:00
hongming-codex-laptop	c2e462ca26	fix(lint): resolve 64 pre-existing golangci-lint violations in workspace-server ... Fixes all ineffassign (7), staticcheck (31), and unused (26) violations reported by golangci-lint in workspace-server/ so the linter gate is clean. Key changes by linter: - ineffassign: remove 7 variables assigned then immediately overwritten - QF1001 (De Morgan): rewrite 4 negated compound conditions - QF1006 (loop lift): 2 for{if break} → for !cond{} - QF1008 (embedded field): drop .Resources. from hostCfg/hc selectors (provisioner + tests) - QF1012 (Fprintf): 3 sb.WriteString(fmt.Sprintf) → fmt.Fprintf - S1009 (nil+len): remove redundant nil check before len() - S1016 (type conv): 2 struct-literal copies → direct type conversion - S1017 (TrimPrefix): 2 if+HasPrefix/slice → strings.TrimPrefix - S1023 (redundant return): remove 2 trailing returns in middleware - SA1012 (nil context): nil → context.TODO() in resolver_test - SA1019 (deprecated): ImageInspectWithRaw → ImageInspect; RetryAfter direct field - SA5011 (nil deref): t.Error → t.Fatal before dereference in client_test - ST1005 (error string): lowercase 3 error strings starting with proper nouns - ST1013 (HTTP constant): 405 literal → http.StatusMethodNotAllowed - unused: delete 26 unused consts/types/funcs/fields across 12 files All three checks pass after this commit: go build ./... → success go vet ./... → success golangci-lint run --timeout 3m ./... → 0 issues Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 23:47:36 -07:00
hongming-codex-laptop	ad7acd30db	fix(platform): clear golangci-lint findings	2026-05-12 22:53:22 -07:00
Molecule AI Core-BE	0d74b1fa79	[core-be-agent] fix(bundle_test): TestBundleImport_ValidJSON nil broadcaster panic ... TestBundleImport_ValidJSON passed nil broadcaster to BundleHandler. bundle.Import calls broadcaster.RecordAndBroadcast unconditionally → panic when broadcaster is nil. Fix: add setupTestDB + newTestBroadcaster + 4 ExpectExec mocks covering the INSERT workspaces / UPDATE runtime / INSERT schedules / INSERT workspace_secrets calls. Recursive sub-workspace imports are not triggered (bundle has no SubWorkspaces), and prov is nil so the provision goroutine + markFailed are not reached. Also caught: the original test never called setupTestDB, so db.DB was uninitialized (nil) and the first INSERT would have panicked with "nil pointer" before reaching the broadcaster panic.	2026-05-13 05:37:43 +00:00