From ed25fa11daff3e3ec1081d224185644da11dc924 Mon Sep 17 00:00:00 2001 From: Hongming Wang Date: Wed, 15 Apr 2026 16:55:24 -0700 Subject: [PATCH] feat(template): add molecule-skill-code-review to Frontend/Backend/DevOps Engineer (#280) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes #280. Self-review rubric now runs on the same workspaces that raise PRs, not just on the reviewers. Dev Lead uses the same 16-criteria rubric in review, so catching issues pre-PR cuts the review loop. - Frontend Engineer: new plugins: [molecule-skill-code-review] - Backend Engineer: plugins extended from [molecule-hitl] to [molecule-hitl, molecule-skill-code-review] - DevOps Engineer: plugins extended from [molecule-hitl] to [molecule-hitl, molecule-skill-code-review] The issue didn't explicitly call out DevOps Engineer but the reasoning applies — DevOps Engineer writes Dockerfiles + CI workflows + infra scripts that Dev Lead reviews with the same rubric. Including here for consistency. Verified all 5 reviewer/engineer roles' plugin lists via walk-script: Dev Lead: [code-review, llm-judge] Frontend Eng: [code-review] ← NEW Backend Eng: [hitl, code-review] ← NEW DevOps Eng: [hitl, code-review] ← NEW Security Aud: [code-review, cross-vendor, llm-judge, security-scan, hitl] Co-Authored-By: Claude Opus 4.6 (1M context) --- org-templates/molecule-dev/org.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/org-templates/molecule-dev/org.yaml b/org-templates/molecule-dev/org.yaml index 30aed816..e3c79d2a 100644 --- a/org-templates/molecule-dev/org.yaml +++ b/org-templates/molecule-dev/org.yaml @@ -481,6 +481,9 @@ workspaces: tier: 3 model: opus files_dir: frontend-engineer + # #280: self-review rubric before raising a PR. Dev Lead uses + # the same rubric, so catching issues here cuts the review loop. + plugins: [molecule-skill-code-review] initial_prompt: | You just started as Frontend Engineer. Set up silently — do NOT contact other agents. 1. Clone the repo: git clone https://github.com/${GITHUB_REPO}.git /workspace/repo 2>/dev/null || (cd /workspace/repo && git pull) @@ -507,7 +510,9 @@ workspaces: # DB migrations + runtime config changes; the @requires_approval # decorator stops an unattended agent from shipping a prod # schema mutation without a human click. UNION with defaults. - plugins: [molecule-hitl] + # #280: molecule-skill-code-review — self-review rubric before + # raising a PR (same rubric Dev Lead applies in review). + plugins: [molecule-hitl, molecule-skill-code-review] initial_prompt: | You just started as Backend Engineer. Set up silently — do NOT contact other agents. 1. Clone the repo: git clone https://github.com/${GITHUB_REPO}.git /workspace/repo 2>/dev/null || (cd /workspace/repo && git pull) @@ -537,7 +542,9 @@ workspaces: # registry pushes, CI pipeline mutations. Any of these going # wrong affects every tenant; @requires_approval before # destructive infra ops is the point. - plugins: [molecule-hitl] + # #280: molecule-skill-code-review — self-review rubric for + # Dockerfiles, CI workflows, infra scripts before PR. + plugins: [molecule-hitl, molecule-skill-code-review] initial_prompt: | You just started as DevOps Engineer. Set up silently — do NOT contact other agents. 1. Clone the repo: git clone https://github.com/${GITHUB_REPO}.git /workspace/repo 2>/dev/null || (cd /workspace/repo && git pull)