fix(workflows): remove duplicate YAML keys + restore COMMENT_AUTHOR + add bp-required

Three fixes consolidated onto infra-sre's clean rebase of PR #1333:

1. review-refire-comments.yml: remove duplicate `runs-on:`/`steps:` YAML
   merge-conflict artifact. Python yaml parser keeps the LAST key, so the
   deprecated stub (exit 0) was silently replaced by the old refire logic.
   The file is supposed to be a pure no-op stub pending deletion.

2. sop-checklist.yml: restore COMMENT_AUTHOR=${{ github.event.comment.user.login }}
   to all three refire env blocks (qa-review, security-review,
   sop-tier-check). The scripts use it for status descriptions; without
   it, descriptions show "unknown" for the caller.

3. e2e-peer-visibility.yml: add `# bp-required: pending #1296` to both
   pr-validate and peer-visibility jobs. Satisfies the
   lint-required-context-exists-in-bp convention for the intentionally
   RED e2e-peer-visibility gate.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

.gitea/workflows/e2e-peer-visibility.yml

@@ -101,6 +101,7 @@ jobs:
   # push/dispatch/cron only (30+ min). This is NOT a fake-green mask of
   # the real assertion — it validates the driving script's bash syntax
   # and inline-python so a broken test script fails at PR time.
+  # bp-required: pending #1296  ← flip to required once e2e-peer-visibility is green
   pr-validate:
     name: E2E Peer Visibility
     runs-on: ubuntu-latest
@@ -118,6 +119,7 @@ jobs:
   # Real gate: provisions a throwaway org + sibling-per-runtime, drives
   # the LITERAL list_peers MCP call per runtime, asserts 200 + expected
   # peer set, then scoped teardown. push(main)/dispatch/cron only.
+  # bp-required: pending #1296  ← flip to required once e2e-peer-visibility is green
   peer-visibility:
     name: E2E Peer Visibility
     runs-on: ubuntu-latest

.gitea/workflows/review-refire-comments.yml

@@ -37,90 +37,3 @@ jobs:
         run: |
           echo "::warning::review-refire-comments.yml is deprecated. Refire logic is now in sop-checklist.yml review-refire job. This workflow is a no-op stub pending deletion (issue #1280)."
           exit 0
-    runs-on: ubuntu-latest
-    steps:
-      - name: Classify comment
-        id: classify
-        env:
-          COMMENT_BODY: ${{ github.event.comment.body }}
-          IS_PR: ${{ github.event.issue.pull_request != null }}
-        run: |
-          set -euo pipefail
-          {
-            echo "run_qa=false"
-            echo "run_security=false"
-            echo "run_tier=false"
-          } >> "$GITHUB_OUTPUT"
-          if [ "$IS_PR" != "true" ]; then
-            echo "::notice::not a PR comment; no-op"
-            exit 0
-          fi
-          first_line=$(printf '%s\n' "$COMMENT_BODY" | sed -n '1p')
-          case "$first_line" in
-            /qa-recheck*)
-              echo "run_qa=true" >> "$GITHUB_OUTPUT"
-              ;;
-            /security-recheck*)
-              echo "run_security=true" >> "$GITHUB_OUTPUT"
-              ;;
-            /refire-tier-check*)
-              echo "run_tier=true" >> "$GITHUB_OUTPUT"
-              ;;
-            *)
-              echo "::notice::no supported review refire slash command; no-op"
-              ;;
-          esac
-
-      - name: Check out BASE ref for trusted scripts
-        if: |
-          steps.classify.outputs.run_qa == 'true' ||
-          steps.classify.outputs.run_security == 'true' ||
-          steps.classify.outputs.run_tier == 'true'
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
-        with:
-          ref: ${{ github.event.repository.default_branch }}
-
-      - name: Refire qa-review status
-        if: steps.classify.outputs.run_qa == 'true'
-        env:
-          GITEA_TOKEN: ${{ secrets.RFC_324_TEAM_READ_TOKEN || secrets.GITHUB_TOKEN }}
-          GITEA_HOST: git.moleculesai.app
-          REPO: ${{ github.repository }}
-          PR_NUMBER: ${{ github.event.issue.number }}
-          DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
-          TEAM: qa
-          TEAM_ID: '20'
-          REVIEW_CHECK_DEBUG: '0'
-          REVIEW_CHECK_STRICT: '0'
-          COMMENT_AUTHOR: ${{ github.event.comment.user.login }}
-        run: |
-          set -euo pipefail
-          .gitea/scripts/review-refire-status.sh
-
-      - name: Refire security-review status
-        if: steps.classify.outputs.run_security == 'true'
-        env:
-          GITEA_TOKEN: ${{ secrets.RFC_324_TEAM_READ_TOKEN || secrets.GITHUB_TOKEN }}
-          GITEA_HOST: git.moleculesai.app
-          REPO: ${{ github.repository }}
-          PR_NUMBER: ${{ github.event.issue.number }}
-          DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
-          TEAM: security
-          TEAM_ID: '21'
-          REVIEW_CHECK_DEBUG: '0'
-          REVIEW_CHECK_STRICT: '0'
-          COMMENT_AUTHOR: ${{ github.event.comment.user.login }}
-        run: |
-          set -euo pipefail
-          .gitea/scripts/review-refire-status.sh
-
-      - name: Refire sop-tier-check status
-        if: steps.classify.outputs.run_tier == 'true'
-        env:
-          GITEA_TOKEN: ${{ secrets.SOP_TIER_CHECK_TOKEN || secrets.GITHUB_TOKEN }}
-          GITEA_HOST: git.moleculesai.app
-          REPO: ${{ github.repository }}
-          PR_NUMBER: ${{ github.event.issue.number }}
-          COMMENT_AUTHOR: ${{ github.event.comment.user.login }}
-          SOP_DEBUG: '0'
-        run: bash .gitea/scripts/sop-tier-refire.sh

.gitea/workflows/sop-checklist.yml

@@ -186,6 +186,7 @@ jobs:
           DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
           TEAM: qa
           TEAM_ID: '20'
+          COMMENT_AUTHOR: ${{ github.event.comment.user.login }}
           REVIEW_CHECK_DEBUG: '0'
           REVIEW_CHECK_STRICT: '0'
         run: |
@@ -202,6 +203,7 @@ jobs:
           DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
           TEAM: security
           TEAM_ID: '21'
+          COMMENT_AUTHOR: ${{ github.event.comment.user.login }}
           REVIEW_CHECK_DEBUG: '0'
           REVIEW_CHECK_STRICT: '0'
         run: |
@@ -215,5 +217,6 @@ jobs:
           GITEA_HOST: git.moleculesai.app
           REPO: ${{ github.repository }}
           PR_NUMBER: ${{ github.event.issue.number }}
+          COMMENT_AUTHOR: ${{ github.event.comment.user.login }}
           SOP_DEBUG: '0'
         run: bash .gitea/scripts/sop-tier-refire.sh