ci: revert coverage-gate split — measured peak is 1.33 GB, there was no OOM

Evidence-first correction (SOP). My earlier commit split the Canvas gate into a plain "vitest run" + a separate continue-on-error coverage step, on the theory that "vitest run --coverage" was OS-OOM-killing the runner. Measuring the actual footprint disproves that: full vitest + v8-coverage process TREE peak RSS = 1.33 GB (3358 tests) (The first measurement of 0.56 GB only saw the parent process; 1.33 GB is the whole tree incl. the worker fork.) 1.33 GB is comfortably within the runner, and the single "vitest run --coverage" gate was green on the prior head 3b1e705e — so there is no chronic coverage OOM. The two reds on b1da1456 were (a) the DisplayTab paste-race (real, fixed in this PR) and (b) an incomplete attempt-1 log captured when the re-run was triggered, NOT a kill. So the split was a workaround for a misdiagnosed problem. Restore the SINGLE "npx vitest run --coverage" as the gate+coverage SSOT (one invocation, html artifact preserved, coverage config untouched in its proper home). The genuine fix — DisplayTab waiting for the RFB connect before pasting — stays. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 00:47:03 -07:00
parent 3de9e05076
commit e6b6ec519c
1 changed files with 11 additions and 16 deletions
@@ -303,22 +303,17 @@ jobs:
      - if: ${{ needs.changes.outputs.canvas == 'true' }}
        run: npm run build
      - if: ${{ needs.changes.outputs.canvas == 'true' }}
-        name: Run tests (gate)
-        # The pass/fail GATE is the plain test run — light memory, deterministic.
-        # Coverage instrumentation (v8 + JSDOM, single worker per vitest.config.ts
-        # maxWorkers:1) accumulates memory across all 228 files and, under the
-        # shared runner's RAM pressure, OS-OOM-killed the run mid-suite — failing
-        # this required gate on a resource hiccup, not a test result. So coverage
-        # is split into a separate non-gating step below. (No threshold gate per
-        # #1815, so coverage was never a real gate — only an artifact baseline.)
-        run: npx vitest run
-      - if: ${{ needs.changes.outputs.canvas == 'true' }}
-        name: Collect coverage (non-gating artifact)
-        # continue-on-error: coverage is a memory-heavy baseline artifact (#1815),
-        # NOT a merge gate. If it OOMs/partials on a constrained runner the gate
-        # above has already decided pass/fail; the upload step tolerates partials
-        # via if-no-files-found: warn.
-        continue-on-error: true
+        name: Run tests with coverage
+        # Coverage instrumentation is configured in canvas/vitest.config.ts
+        # (provider: v8, reporters: text + html + json-summary). Step 2 of
+        # #1815 — wires coverage into CI so we get a baseline visible on
+        # every PR. No threshold gate yet; thresholds dial in (Step 3, also
+        # tracked in #1815) after the team sees what current coverage is.
+        # Memory: the full vitest+v8-coverage process tree peaks at ~1.33 GB
+        # (measured 2026-06-08), comfortably within the runner — so this single
+        # run is BOTH the pass/fail gate and the coverage artifact (one SSOT, no
+        # split). The earlier intermittent red here was a DisplayTab paste-race
+        # (fixed in this PR), NOT a coverage OOM.
        run: npx vitest run --coverage
      - name: Upload coverage summary as artifact
        if: ${{ needs.changes.outputs.canvas == 'true' }}