From dbd086c7adc327ce03d15fb49f3b2bfd249386d9 Mon Sep 17 00:00:00 2001 From: Hongming Wang Date: Fri, 1 May 2026 16:07:33 -0700 Subject: [PATCH] test(mcp): comment empty except in bridge test cleanup Address github-code-quality review on PR #2465: explain why the OSError swallow in pipe teardown is intentional (best-effort cleanup of a possibly-already-closed fd). Co-Authored-By: Claude Opus 4.7 (1M context) --- workspace/tests/test_a2a_mcp_server.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/workspace/tests/test_a2a_mcp_server.py b/workspace/tests/test_a2a_mcp_server.py index c567b8c9..a4cf3fe2 100644 --- a/workspace/tests/test_a2a_mcp_server.py +++ b/workspace/tests/test_a2a_mcp_server.py @@ -456,6 +456,8 @@ async def test_inbox_bridge_emits_channel_notification_to_writer(): try: os.close(read_fd) except OSError: + # read_fd may already be closed if writer.close() tore down the pair + # during teardown — best-effort cleanup, no signal worth surfacing. pass