fix(sop-checklist): permit author self-acks through team probe (internal#760)

Authors are expected to ack their own SOP checklist per normal SOP.
Previously self-acks were hard-rejected before the team-membership probe,
which blocked every PR where the author is in the required team.

Now self-acks flow through the same probe as peer acks, so an author
satisfies items whose required_teams they belong to (e.g. engineers).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

.gitea/scripts/sop-checklist.py

@@ -351,7 +351,10 @@ def compute_ack_state(
             latest_directive[(user, slug)] = kind
 
     # Step 2: build candidate ackers per slug.
-    # Filter out self-acks and unknown slugs.
+    # Filter out unknown slugs. Author self-acks are permitted per SOP
+    # (authors fill out and ack their own checklist as normal process).
+    # Self-acks still flow through the team-membership probe so an author
+    # only satisfies items whose required_teams they actually belong to.
     ackers_per_slug: dict[str, list[str]] = {s: [] for s in items_by_slug}
     rejected_self: dict[str, list[str]] = {s: [] for s in items_by_slug}
     pending_team_check: dict[str, list[str]] = {s: [] for s in items_by_slug}
@@ -364,9 +367,6 @@ def compute_ack_state(
             # under a synthetic key for diagnostic surfacing. Don't add
             # to any item.
             continue
-        if user == pr_author:
-            rejected_self[slug].append(user)
-            continue
         pending_team_check[slug].append(user)
 
     # Step 3: team membership probe per slug (batched per slug to keep

.gitea/scripts/tests/test_sop_checklist.py

@@ -291,13 +291,14 @@ class TestComputeAckState(unittest.TestCase):
         )
         self.assertEqual(state["comprehensive-testing"]["ackers"], ["bob"])
 
-    def test_self_ack_rejected(self):
+    def test_self_ack_permitted_when_author_in_team(self):
+        # Author self-acks are normal SOP; they count when the author
+        # passes the team-membership probe (same as peer acks).
         comments = [_comment("alice", "/sop-ack comprehensive-testing")]
         state = sop.compute_ack_state(
             comments, "alice", self.items, self.aliases, self._approve_all
         )
-        self.assertEqual(state["comprehensive-testing"]["ackers"], [])
-        self.assertEqual(state["comprehensive-testing"]["rejected"]["self_ack"], ["alice"])
+        self.assertEqual(state["comprehensive-testing"]["ackers"], ["alice"])
 
     def test_not_in_team_rejected(self):
         comments = [_comment("eve", "/sop-ack comprehensive-testing")]
@@ -722,16 +723,16 @@ class TestRootCauseAckEligibilityWidened(unittest.TestCase):
         )
         self.assertEqual(state["root-cause"]["ackers"], ["hongming"])
 
-    def test_self_ack_still_forbidden_even_with_widened_eligibility(self):
-        # Author cannot self-ack — widening teams must NOT weaken
-        # the non-author rule.
+    def test_self_ack_permitted_with_widened_eligibility(self):
+        # Author self-acks count when the author is in the required
+        # team (same as peer acks); widening teams does not weaken
+        # the gate, it just includes the author as a valid acker.
         comments = [_comment("alice", "/sop-ack root-cause")]
         probe = self._approve_only({"alice"})
         state = sop.compute_ack_state(
             comments, "alice", self.items, self.aliases, probe, high_risk=False
         )
-        self.assertEqual(state["root-cause"]["ackers"], [])
-        self.assertIn("alice", state["root-cause"]["rejected"]["self_ack"])
+        self.assertEqual(state["root-cause"]["ackers"], ["alice"])
 
 
 class TestHighRiskClassUsesElevatedListInConfig(unittest.TestCase):