diff --git a/.gitea/workflows/ci.yml b/.gitea/workflows/ci.yml index fe53a9de..a49e71b6 100644 --- a/.gitea/workflows/ci.yml +++ b/.gitea/workflows/ci.yml @@ -126,8 +126,29 @@ jobs: name: Platform (Go) needs: changes runs-on: ubuntu-latest - # Phase 4 (RFC #219 §1): confirmed green on main 2026-05-12. - continue-on-error: false + # mc#664 (interim): re-mask platform-build pending fix-forward. Phase 4 + # (#656) flipped this to continue-on-error: false based on a Phase-3-masked + # "green on main 2026-05-12" — the prior continue-on-error: true had + # been hiding failing tests in workspace-server/internal/handlers/. + # Two distinct failure classes surfaced on 0e5152c3: + # (1) 4x delegation_test.go (lines 1110/1176/1228/1271): helpers + # expectExecuteDelegationBase/Success/Failed are missing sqlmock + # expectations for queries production has issued since ~2026-04-21 + # (last_outbound_at UPDATE, lookupDeliveryMode/Runtime SELECTs, + # a2a_receive INSERT activity_logs, recordLedgerStatus writes). + # Halt cond #3 applies (regression > 7 days → broader sweep). + # (2) 1x mcp_test.go:433 (TestMCPHandler_CommitMemory_GlobalScope_Blocked): + # commit 7d1a189f (2026-05-10) hardened mcp.go to scrub err.Error() + # from JSON-RPC responses (OFFSEC-001), but the test asserts the + # error message contains "GLOBAL". Production-vs-test contract + # collision — needs design call, not mock update. + # Time-boxed Option A (90 min) did not fit the cross-cutting scope. + # This is a sequenced revert→fix→reflip per + # feedback_strict_root_only_after_class_a emergency clause — NOT + # a permanent re-mask. Re-flip blocked on mc#664 fix-forward landing. + # Other 4 #656 flips (changes, canvas-build, shellcheck, python-lint) + # retain continue-on-error: false; only platform-build regresses. + continue-on-error: true # mc#664 fix-forward in flight; re-flip when tests pass defaults: run: working-directory: workspace-server