fix(canvas/mobile): remove ?? [] from agentMessages selector — infinite re-render

The Zustand selector `s.agentMessages[agentId] ?? []` creates a new
empty array on every store update when the key is absent (undefined),
causing React error #185 (infinite re-render).

Fix: selector returns undefined (stable reference), ?? [] applied only
in useState initializer which runs once at mount.

Also restores the comment explaining why ?? [] must not appear in the
selector itself.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Molecule AI · core-fe 2026-05-12 09:40:24 +00:00 committed by molecule-operator
parent 930d31aa6e
commit d20e14db41

View File

@ -54,11 +54,9 @@ export function MobileChat({
// user sees their prior thread on entry. The store is updated by the
// socket → ChatTab flows the desktop runs; on mobile we read from the
// same buffer to keep state coherent across viewports.
// NOTE: do NOT use `?? []` in the selector — Zustand uses Object.is
// for selector equality. A fallback `?? []` creates a new [] reference on
// every store update when agentMessages[agentId] is undefined, causing an
// infinite re-render loop (React error #185 / Maximum update depth
// exceeded). The undefined case is handled by the initializer below.
// NOTE: selector returns undefined (stable) — do NOT use ?? [] here,
// that creates a new [] reference on every store update when the key is
// absent, causing infinite re-render (React error #185).
const storedMessages = useCanvasStore((s) => s.agentMessages[agentId]);
const [messages, setMessages] = useState<ChatMessage[]>(() =>
(storedMessages ?? []).map((m) => ({